Skip to contentSkip to conversation

arm: socfpga: sr1500: Remove USB_GADGET

PATCH In review Semen Protsenko 5 participants 7 messages Apr 1, 2016 – Apr 12, 2016

lore
Share & tools
lore

Semen Protsenko

author
#0 lore raw

PATCH 1/1 arm: socfpga: sr1500: Remove USB_GADGET

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Signed-off-by Sam Protsenko <[email protected]>
---
 configs/socfpga_sr1500_defconfig | 2 --
 1 file changed, 2 deletions(-)
configs/socfpga_sr1500_defconfig +0 -2
index 2842fba..d499a14 100644
@@ -21,5 +21,3 @@ CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_SYS_NS16550=y
 CONFIG_CADENCE_QSPI=y
-CONFIG_USB=y
-CONFIG_USB_GADGET=y
Signature · 1 line
2.8.0.rc3
author
#2 lore raw

PATCH 1/1 arm: socfpga: sr1500: Remove USB_GADGET

Quoted 8 lines · Stefan Roese
Quoted 7 lines · Semen Protsenko

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Quoted 8 lines
Quoted 1 line
Signed-off-by Sam Protsenko <[email protected]>
Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

Tom,

Can you please take a look and merge this patch?

Thanks.

#3 lore raw

PATCH 1/1 arm: socfpga: sr1500: Remove USB_GADGET

Quoted 14 lines · Sam Protsenko
Quoted 13 lines · Stefan Roese
Quoted 8 lines · Semen Protsenko

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Signed-off-by Sam Protsenko <[email protected]>
Acked-by Stefan Roese <[email protected]>
Quoted 7 lines
Quoted 3 lines

Thanks,
Stefan

Tom,

Can you please take a look and merge this patch?

It would be fantastic if you kept me on CC. Such patches should go through the socfpga tree. But it would be easier for Tom to pick it this time so I dont have to roll another PR before rc1.

Signature · 2 lines
Best regards,
Marek Vasut
author
#4 lore raw

PATCH 1/1 arm: socfpga: sr1500: Remove USB_GADGET

Quoted 19 lines · Marek Vasut
Quoted 18 lines · Sam Protsenko
Quoted 16 lines · Stefan Roese
Quoted 8 lines · Semen Protsenko

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Signed-off-by Sam Protsenko <[email protected]>
Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

Quoted 7 lines
Quoted 3 lines

Tom,

Can you please take a look and merge this patch?

It would be fantastic if you kept me on CC. Such patches should go through the socfpga tree. But it would be easier for Tom to pick it this time so I dont have to roll another PR before rc1.

Sure thing. I guess "get_maintainer.pl" didn't show you for this patch, because it only affects configs/. But it's indeed socfpga related, so I'll be more careful next time.

Quoted 4 lines

--
Best regards,
Marek Vasut

#5 lore raw

PATCH 1/1 arm: socfpga: sr1500: Remove USB_GADGET

Quoted 24 lines · Sam Protsenko
Quoted 23 lines · Marek Vasut
Quoted 21 lines · Sam Protsenko
Quoted 8 lines · Stefan Roese
Quoted 7 lines · Semen Protsenko

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Quoted 8 lines
Quoted 1 line
Signed-off-by Sam Protsenko <[email protected]>
Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

Tom,

Can you please take a look and merge this patch?

Quoted 7 lines
Quoted 3 lines

It would be fantastic if you kept me on CC. Such patches should go through the socfpga tree. But it would be easier for Tom to pick it this time so I dont have to roll another PR before rc1.

Sure thing. I guess "get_maintainer.pl" didn't show you for this patch, because it only affects configs/. But it's indeed socfpga related, so I'll be more careful next time.

Thanks. All socfpga stuff goes to/through Dinh, Chin and me.

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw
In reply to Semen Protsenko
Quoted 8 lines · Semen Protsenko

From: Sam Protsenko <[email protected]>

"buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state.

Signed-off-by Sam Protsenko <[email protected]>
Acked-by Stefan Roese <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160411/0d59752b/attachment.sig>