Skip to contentSkip to conversation

gunzip.c: use block layer for writes

PATCH In review Eric Nelson 4 participants 7 messages Apr 11, 2016 – Apr 21, 2016 Library code

lore
Share & tools
lore

Eric Nelson

author
#0 lore raw

PATCH 1/1 gunzip.c: use block layer for writes

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Signed-off-by Eric Nelson <[email protected]>
---
 lib/gunzip.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
lib/gunzip.c +2 -3
index 6d65ccc..bc746d6 100644
@@ -232,9 +232,8 @@ int gzwrite(unsigned char *src, int len,
 			gzwrite_progress(iteration++,
 					 totalfilled,
 					 szexpected);
-			blocks_written = dev->block_write(dev, outblock,
-							  writeblocks,
-							  writebuf);
+			blocks_written = blk_dwrite(dev, outblock,
+						    writeblocks, writebuf);
 			outblock += blocks_written;
 			if (ctrlc()) {
 				puts("abort\n");
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 gunzip.c: use block layer for writes

Quoted 2 lines · Eric Nelson

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Reviewed-by Stephen Warren <[email protected]>

You probably wanted to Cc whichever maintainer will apply this though. Hopefully they'll see it in patchwork.

author
#2 lore raw

PATCH 1/1 gunzip.c: use block layer for writes

Thanks Stephen,

Quoted 8 lines · Stephen Warren
Quoted 2 lines · Eric Nelson

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Reviewed-by Stephen Warren <[email protected]>

You probably wanted to Cc whichever maintainer will apply this though. Hopefully they'll see it in patchwork.

I'm not sure who that might be and I included everyone on the output of get_maintainer.pl.

Tom's the last one to commit and comment on the gzwrite piece of code, so perhaps it's him.

#3 lore raw

PATCH 1/1 gunzip.c: use block layer for writes

Quoted 9 lines · Eric Nelson

Thanks Stephen,

Quoted 6 lines · Stephen Warren
Quoted 2 lines · Eric Nelson

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Reviewed-by Stephen Warren <[email protected]>
Quoted 8 lines
Quoted 2 lines

You probably wanted to Cc whichever maintainer will apply this though. Hopefully they'll see it in patchwork.

I'm not sure who that might be and I included everyone on the output of get_maintainer.pl.

Tom's the last one to commit and comment on the gzwrite piece of code, so perhaps it's him.

Indeed, last resort is me :) I suppose the top of my head question is, do we have some gunzip tests that test.py will kick off?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160412/579a2d7b/attachment-0001.sig>
#4 lore raw

PATCH 1/1 gunzip.c: use block layer for writes

Quoted 13 lines · Tom Rini
Quoted 12 lines · Eric Nelson

Thanks Stephen,

Quoted 8 lines · Stephen Warren
Quoted 2 lines · Eric Nelson

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Reviewed-by Stephen Warren <[email protected]>

You probably wanted to Cc whichever maintainer will apply this though. Hopefully they'll see it in patchwork.

Quoted 8 lines
Quoted 5 lines

I'm not sure who that might be and I included everyone on the output of get_maintainer.pl.

Tom's the last one to commit and comment on the gzwrite piece of code, so perhaps it's him.

Indeed, last resort is me :) I suppose the top of my head question is, do we have some gunzip tests that test.py will kick off?

I don't believe we do for the command. IIRC there's a sandbox test for the core gunzip routine itself, but not the gzwrite command that uses it.

#6 lore raw
In reply to Eric Nelson
Quoted 5 lines · Eric Nelson

Call blk_dwrite to ensure that the block cache is notified if enabled and remove build breakage when CONFIG_BLK is enabled.

Signed-off-by Eric Nelson <[email protected]>
Reviewed-by Stephen Warren <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/153f3eed/attachment.sig>