iwcm: Fix a sparse warning

PATCH In review Bart Van Assche 2 participants 2 messages Apr 12, 2016 1 message not in the archive InfiniBand

lore

Share & tools

lore

Bart Van Assche

author

2016-04-12 21:43 UTC #0 lore raw

PATCH 1/1 iwcm: Fix a sparse warning

Avoid that sparse complains about the comparison of s_addr with INADDR_ANY.

Signed-off-by Bart Van Assche <[email protected]>

Cc Steve Wise <[email protected]>

Cc Faisal Latif <[email protected]>

---
 drivers/infiniband/core/iwcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/infiniband/core/iwcm.c +1 -1

index e28a160..fe0bd6c 100644
@@ -459,7 +459,7 @@ static void iw_cm_check_wildcard(struct sockaddr_storage *pm_addr,
 	if (pm_addr->ss_family == AF_INET) {
 		struct sockaddr_in *pm4_addr = (struct sockaddr_in *)pm_addr;
 
-		if (pm4_addr->sin_addr.s_addr == INADDR_ANY) {
+		if (pm4_addr->sin_addr.s_addr == htonl(INADDR_ANY)) {
 			struct sockaddr_in *cm4_addr =
 				(struct sockaddr_in *)cm_addr;
 			struct sockaddr_in *cm4_outaddr =

Signature · 6 lines

2.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Steve Wise

Reviewed-by

2016-04-12 21:46 UTC #2 lore raw

Quoted 4 lines · Bart Van Assche

Avoid that sparse complains about the comparison of s_addr with INADDR_ANY.

Looks good.

Reviewed-by Steve Wise <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html