Skip to contentSkip to conversation

dragonboard410c: Fix environment variables

PATCH In review Andreas Färber 2 participants 3 messages Apr 13, 2016 – Apr 21, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dragonboard410c: Fix environment variables

Some variables for the distro boot commands were missing, using some custom name instead. Rename them.

Cc Mateusz Kulikowski <[email protected]>
---
 include/configs/dragonboard410c.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/configs/dragonboard410c.h +4 -4
index a63440f..6dd5fbf 100644
@@ -126,10 +126,10 @@ REFLASH(dragonboard/u-boot.img, 8)\
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
 	"linux_image=Image\0" \
-	"linux_addr=0x81000000\0"\
-	"fdt_image=apq8016-sbc.dtb\0" \
-	"fdt_addr=0x83000000\0"\
-	"ramdisk_addr=0x84000000\0"\
+	"kernel_addr_r=0x81000000\0"\
+	"fdtfile=apq8016-sbc.dtb\0" \
+	"fdt_addr_r=0x83000000\0"\
+	"ramdisk_addr_r=0x84000000\0"\
 	BOOTENV
 
 #define CONFIG_ENV_IS_NOWHERE
Signature · 1 line
2.6.6
#1 lore raw

PATCH 1/1 dragonboard410c: Fix environment variables

Hi Daniel,

Am 13.04.2016 um 14:16 schrieb Andreas F?rber:

Quoted 18 lines

Some variables for the distro boot commands were missing, using some custom name instead. Rename them.

Cc Mateusz Kulikowski <[email protected]>
---
 include/configs/dragonboard410c.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/configs/dragonboard410c.h +0 -1
index a63440f..6dd5fbf 100644
@@ -126,10 +126,10 @@ REFLASH(dragonboard/u-boot.img, 8)\
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
 	"linux_image=Image\0" \
-	"linux_addr=0x81000000\0"\

include/configs/dragonboard410c.h REFLASH(dragonboard/u-boot.img, 8)\ · line 135

Quoted 10 lines
include/configs/dragonboard410c.h +4 -3
-	"fdt_image=apq8016-sbc.dtb\0" \
-	"fdt_addr=0x83000000\0"\
-	"ramdisk_addr=0x84000000\0"\
+	"kernel_addr_r=0x81000000\0"\
+	"fdtfile=apq8016-sbc.dtb\0" \
+	"fdt_addr_r=0x83000000\0"\
+	"ramdisk_addr_r=0x84000000\0"\
 	BOOTENV
 
 #define CONFIG_ENV_IS_NOWHERE

Forgot about investigating scriptaddr you mentioned. We can either add it in a v2 if there's something else, or you can follow up after this.

EFI was still not working for me and I did not yet test boot.scr.

Regards,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
#2 lore raw
In reply to Andreas Färber
Quoted 5 lines · Andreas F?rber

Some variables for the distro boot commands were missing, using some custom name instead. Rename them.

Cc Mateusz Kulikowski <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/711b4117/attachment.sig>