efi_loader: Always flush in cache line size granularity
PATCH 1/1 efi_loader: Always flush in cache line size granularity
The cache line flush helpers only work properly when they get aligned start and end addresses. Round our flush range to cache line size. It's safe because we're guaranteed to flush within a single page which has the same cache attributes.
---
v1 -> v2:
- Fix compilation on systems without CONFIG_SYS_CACHELINE_SIZE
lib/efi_loader/efi_runtime.c +9 -1
@@ -20,6 +20,13 @@ static efi_status_t EFI_RUNTIME_TEXT EFIAPI efi_unimplemented(void); static efi_status_t EFI_RUNTIME_TEXT EFIAPI efi_device_error(void); static efi_status_t EFI_RUNTIME_TEXT EFIAPI efi_invalid_parameter(void); +#ifdef CONFIG_SYS_CACHELINE_SIZE +#define EFI_CACHELINE_SIZE CONFIG_SYS_CACHELINE_SIZE +#else +/* Just use the greatest cache flush alignment requirement I'm aware of */ +#define EFI_CACHELINE_SIZE 128 +#endif +#if defined(CONFIG_ARM64 )#define R_RELATIVE 1027#define R_MASK 0xffffffffULL
@@ -194,7 +201,8 @@ void efi_runtime_relocate(ulong offset, struct efi_mem_desc *map)#endif *p = newaddr; -flush_dcache_range ((ulong )p, (ulong)&p[1 ]); +flush_dcache_range ((ulong )p & ~(EFI_CACHELINE_SIZE -1 ), +ALIGN ((ulong)&p[1 ],EFI_CACHELINE_SIZE )); }#ifndef IS_RELA
PATCH 1/1 efi_loader: Always flush in cache line size granularity
Am 11.04.2016 um 23:20 schrieb Alexander Graf:
Quoted 7 lines
The cache line flush helpers only work properly when they get aligned start and end addresses. Round our flush range to cache line size. It's safe because we're guaranteed to flush within a single page which has the same cache attributes.
Reported-by Marek Vasut <[email protected]>Signed-off-by Alexander Graf <[email protected]>
Thanks,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)
Quoted 9 lines · Alexander Graf
The cache line flush helpers only work properly when they get aligned start and end addresses. Round our flush range to cache line size. It's safe because we're guaranteed to flush within a single page which has the same cache attributes.
Reported-by Marek Vasut <[email protected]>Signed-off-by Alexander Graf <[email protected]>Reviewed-by Andreas F?rber <[email protected]>Tested-by Andreas F?rber <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/5f0de3a7/attachment.sig>