Skip to contentSkip to conversation

ARM: keystone: Enable CPU hotplug

PATCH New Keerthy 3 participants 7 messages Apr 4, 2016 – Apr 14, 2016

Subsystems (2)
lore
Share & tools
lore

Keerthy

author
#0 lore raw

cover ARM: keystone: Enable CPU hotplug

Series enables CPU hotplug for K2HK. CPU Hotplug tested on K2HK-EVM.

It is on top of 4.6-rc2.

Keerthy (2):
keystone: dts: add psci command definition
ARM: configs: keystone: Add CPU Hotplug related options

 arch/arm/boot/dts/keystone.dtsi     | 8 ++++++++
 arch/arm/configs/keystone_defconfig | 2 ++
 2 files changed, 10 insertions(+)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 keystone: dts: add psci command definition

From: Vitaly Andrianov <[email protected]>

This commit adds definition for cpu_on, cpu_off and cpu_suspend commands. These definitions must match the corresponding PSCI definitions in boot monitor.

Having those command and corresponding PSCI support in boot monitor allows run time CPU hot plugin.

---
 arch/arm/boot/dts/keystone.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/keystone.dtsi +8 -0
index 3f27282..0076489 100644
@@ -59,6 +59,14 @@
 			     <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>;
 	};
 
+	psci {
+		compatible	= "arm,psci";
+		method		= "smc";
+		cpu_suspend	= <0x84000001>;
+		cpu_off		= <0x84000002>;
+		cpu_on		= <0x84000003>;
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 2/2 ARM: configs: keystone: Add CPU Hotplug related options

In reply to Keerthy

Add the config options needed to get CPU hotplug functional.

---
 arch/arm/configs/keystone_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/keystone_defconfig +2 -0
index 5bcc9cf..faba04d 100644
@@ -30,6 +30,8 @@ CONFIG_PCI=y
 CONFIG_PCI_MSI=y
 CONFIG_PCI_KEYSTONE=y
 CONFIG_SMP=y
+CONFIG_HOTPLUG_CPU=y
+CONFIG_ARM_PSCI=y
 CONFIG_PREEMPT=y
 CONFIG_AEABI=y
 CONFIG_HIGHMEM=y
Signature · 1 line
1.9.1
#3 lore raw

cover ARM: keystone: Enable CPU hotplug

In reply to Keerthy
Quoted 9 lines · Keerthy

Series enables CPU hotplug for K2HK. CPU Hotplug tested on K2HK-EVM.

It is on top of 4.6-rc2.

Keerthy (2):
keystone: dts: add psci command definition
ARM: configs: keystone: Add CPU Hotplug related options

Looks fine to me. Will add it to the 4.7 queue. Thanks !!

Reagrds,
Santosh

#4 lore raw

cover ARM: keystone: Enable CPU hotplug

Quoted 11 lines · santosh shilimkar
Quoted 9 lines · Keerthy

Series enables CPU hotplug for K2HK. CPU Hotplug tested on K2HK-EVM.

It is on top of 4.6-rc2.

Keerthy (2):
keystone: dts: add psci command definition
ARM: configs: keystone: Add CPU Hotplug related options

Looks fine to me. Will add it to the 4.7 queue. Thanks !!

Just to note that this is required to get CPU hotplug working with the TI keystone2 skern implementation, which is different to the uboot psci code.

Now that I've been able to upgrade my board to a recent uboot and skern, I can add this:

Now... if we could get the damn CPU fan under control, I might be able to stand leaving the board powered on for longer, instead of reaching for the power plug at the earliest possibility!

Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#5 lore raw

cover ARM: keystone: Enable CPU hotplug

Quoted 3 lines · Russell King - ARM Linux

Now... if we could get the damn CPU fan under control, I might be able to stand leaving the board powered on for longer, instead of reaching for the power plug at the earliest possibility!

This evening, I've received a complaint about the noise of the fan, which can be heard throughout the house.

PLEASE can we sort something out about this damned fan? I know that there's a PWM control of it, so let's get it more under control. If no one is interested in writing a driver for it, then please supply me with the information so that I can sort this out, and stop it being so annoying.

Like I've said above, right now the board doesn't stay on for very long, and it's actually a very big _demotivator_ to powering the board on.

This board is also *never* going anywhere near my boot farm because it's just too damned noisy to be powered up during the night, even if we do get the fan more under control once the kernel is running.

If that's not enough to get some help with this, I'll instead snip the fan wire and solder a resistor in series with the fan to slow the damned thing down to reduce the noise level.

Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#6 lore raw

cover ARM: keystone: Enable CPU hotplug

Quoted 8 lines · Russell King - ARM Linux
Quoted 3 lines · Russell King - ARM Linux

Now... if we could get the damn CPU fan under control, I might be able to stand leaving the board powered on for longer, instead of reaching for the power plug at the earliest possibility!

This evening, I've received a complaint about the noise of the fan, which can be heard throughout the house.

:-) Fan is noisy.

Quoted 6 lines

PLEASE can we sort something out about this damned fan? I know that there's a PWM control of it, so let's get it more under control. If no one is interested in writing a driver for it, then please supply me with the information so that I can sort this out, and stop it being so annoying.

Am not sure if this fan is wired to PWM controller though.

Quoted 4 lines

Like I've said above, right now the board doesn't stay on for very long, and it's actually a very big _demotivator_ to powering the board on.

Quoted 8 lines

This board is also *never* going anywhere near my boot farm because it's just too damned noisy to be powered up during the night, even if we do get the fan more under control once the kernel is running.

If that's not enough to get some help with this, I'll instead snip the fan wire and solder a resistor in series with the fan to slow the damned thing down to reduce the noise level.

You should do that. I have less hope of other options.

Regards,
Santosh