Skip to contentSkip to conversation

arm: dts: vf6: fix DTC unit warnings

PATCH New Heiko Schocher 3 participants 6 messages Apr 15, 2016 – Apr 18, 2016 Arm (32-bit)

lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node /soc/ifc at 1530000/board-control at 3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/aips-bus at 40000000 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40080000 has a unit name, but no reg property

Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880431

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238780

 arch/arm/dts/ls1021a-qds.dtsi | 2 +-
 arch/arm/dts/vf.dtsi          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/ls1021a-qds.dtsi +1 -1
index ca9e835..4cb6337 100644
@@ -138,7 +138,7 @@
 		device-width = <1>;
 		ranges = <0 3 0 0x100>;
 
-		mdio-mux-emi1 {
+		mdio-mux-emi1 at 54 {
 			compatible = "mdio-mux-mmioreg";
 			mdio-parent-bus = <&mdio0>;
 			#address-cells = <1>;
arch/arm/dts/vf.dtsi +2 -2
index 1530d2f..99f3269 100644
@@ -28,7 +28,7 @@
 		compatible = "simple-bus";
 		ranges;
 
-		aips0: aips-bus at 40000000 {
+		aips0: aips-bus_40000000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;

@@ -115,7 +115,7 @@
 			};
 		};
 
-		aips1: aips-bus at 40080000 {
+		aips1: aips-bus_40080000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

Quoted 5 lines · Heiko Schocher

Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node /soc/ifc at 1530000/board-control at 3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/aips-bus at 40000000 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40080000 has a unit name, but no reg property

May be this fix[1] which Stefan Agner submitted lately is also applicable here.

[1] https://lkml.org/lkml/2016/4/2/11

Quoted 54 lines
Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880431

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238780

  arch/arm/dts/ls1021a-qds.dtsi | 2 +-
  arch/arm/dts/vf.dtsi          | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/ls1021a-qds.dtsi +1 -1
index ca9e835..4cb6337 100644
@@ -138,7 +138,7 @@
  		device-width = <1>;
  		ranges = <0 3 0 0x100>;
 
-		mdio-mux-emi1 {
+		mdio-mux-emi1 at 54 {
  			compatible = "mdio-mux-mmioreg";
  			mdio-parent-bus = <&mdio0>;
  			#address-cells = <1>;
arch/arm/dts/vf.dtsi +2 -2
index 1530d2f..99f3269 100644
@@ -28,7 +28,7 @@
  		compatible = "simple-bus";
  		ranges;
 
-		aips0: aips-bus at 40000000 {
+		aips0: aips-bus_40000000 {
  			compatible = "fsl,aips-bus", "simple-bus";
  			#address-cells = <1>;
  			#size-cells = <1>;

@@ -115,7 +115,7 @@
  			};
  		};
 
-		aips1: aips-bus at 40080000 {
+		aips1: aips-bus_40080000 {
  			compatible = "fsl,aips-bus", "simple-bus";
  			#address-cells = <1>;
  			#size-cells = <1>;
Signature · 2 lines
Best regards,
Bhuvan
author
#2 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

Hello Bhuvanchandra DV,

Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:

Quoted 11 lines · Heiko Schocher
Quoted 6 lines

Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node /soc/ifc at 1530000/board-control at 3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40000000 has a unit name, but no reg property Warning (unit_address_vs_reg): Node /soc/aips-bus at 40080000 has a unit name, but no reg property

May be this fix[1] which Stefan Agner submitted lately is also applicable here.

[1] https://lkml.org/lkml/2016/4/2/11

Yes, better (as it adds the reg property). I hoped for such a comment, as I cannot search for all missing reg properties!

post a v2 soon.

Thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

Quoted 17 lines · Heiko Schocher

Hello Bhuvanchandra DV,

Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:

Quoted 14 lines · Heiko Schocher
Quoted 9 lines

Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node
/soc/ifc at 1530000/board-control at 3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40000000 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40080000 has a unit name, but no reg property

May be this fix[1] which Stefan Agner submitted lately is also applicable here.

Quoted 6 lines
Quoted 1 line

[1] https://lkml.org/lkml/2016/4/2/11

Yes, better (as it adds the reg property). I hoped for such a comment, as I cannot search for all missing reg properties!

post a v2 soon.

Sure! will submit the patch.

Quoted 5 lines

Thanks!

bye,
Heiko

Signature · 2 lines
Best regards,
Bhuvan
author
#4 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

Hello Bhuvanchandra DV,

Am 18.04.2016 um 10:37 schrieb Bhuvanchandra DV:

Quoted 18 lines · Heiko Schocher
Quoted 17 lines

Hello Bhuvanchandra DV,

Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:

Quoted 14 lines · Heiko Schocher
Quoted 9 lines

Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node
/soc/ifc at 1530000/board-control at 3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40000000 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/aips-bus at 40080000 has a unit name, but no reg property

May be this fix[1] which Stefan Agner submitted lately is also applicable here.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

[1] https://lkml.org/lkml/2016/4/2/11

Yes, better (as it adds the reg property). I hoped for such a comment, as I cannot search for all missing reg properties!

post a v2 soon.

Sure! will submit the patch.

Worked in the changes from the post on lkml, I post a v2, thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#5 lore raw

PATCH 1/1 arm: dts: vf6: fix DTC unit warnings

In reply to Heiko Schocher
Quoted 1 line · Heiko Schocher

Fix following warnings for all vf6 based boards:

We're going to defer on this patch for now, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160418/da69bcc9/attachment.sig>