arm: dts: socfpga: fix DTC unit name warnings

Fix following DTC warnings for all socfpga boards:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or ranges property, but no unit name

Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name, but no reg property

Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880430

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238779

 arch/arm/dts/skeleton.dtsi                     |  2 +-
 arch/arm/dts/socfpga.dtsi                      | 40 +++++++++++++-------------
 arch/arm/dts/socfpga_arria5_socdk.dts          |  2 +-
 arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts |  2 +-
 arch/arm/dts/socfpga_cyclone5_mcvevk.dts       |  2 +-
 arch/arm/dts/socfpga_cyclone5_socdk.dts        |  2 +-
 arch/arm/dts/socfpga_cyclone5_sockit.dts       |  2 +-
 arch/arm/dts/socfpga_cyclone5_socrates.dts     |  2 +-
 8 files changed, 27 insertions(+), 27 deletions(-)

arch/arm/dts/skeleton.dtsi +0 -0

index b41d241..a20da0a 100644

Quoted 14 lines

Fix following DTC warnings for all socfpga boards:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or ranges property, but no unit name

Quoted 8 lines

Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name, but no reg property

How come Linux isn't affected by this ?

Quoted 22 lines

Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880430

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238779

  arch/arm/dts/skeleton.dtsi                     |  2 +-
  arch/arm/dts/socfpga.dtsi                      | 40 +++++++++++++-------------
  arch/arm/dts/socfpga_arria5_socdk.dts          |  2 +-
  arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts |  2 +-
  arch/arm/dts/socfpga_cyclone5_mcvevk.dts       |  2 +-
  arch/arm/dts/socfpga_cyclone5_socdk.dts        |  2 +-
  arch/arm/dts/socfpga_cyclone5_sockit.dts       |  2 +-
  arch/arm/dts/socfpga_cyclone5_socrates.dts     |  2 +-
  8 files changed, 27 insertions(+), 27 deletions(-)

arch/arm/dts/skeleton.dtsi line 13

Quoted 11 lines

arch/arm/dts/skeleton.dtsi +1 -1

index b41d241..a20da0a 100644
@@ -9,5 +9,5 @@
  	#size-cells = <1>;
  	chosen { };
  	aliases { };
-	memory { device_type = "memory"; reg = <0 0>; };
+	memory at 0 { device_type = "memory"; reg = <0 0>; };
  };

Can you split this into skeleton.dtsi patch and socfpga-only patch? That'd help containing the changes.

Hello Marek,

Am 15.04.2016 um 16:18 schrieb Marek Vasut:

Quoted 64 lines · Heiko Schocher

Quoted 62 lines

Fix following DTC warnings for all socfpga boards:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name, but no reg property

Quoted 1 line

How come Linux isn't affected by this ?

I think linux is also affected!

Quoted 23 lines

Quoted 23 lines

Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880430

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238779

  arch/arm/dts/skeleton.dtsi                     |  2 +-
  arch/arm/dts/socfpga.dtsi                      | 40
+++++++++++++-------------
  arch/arm/dts/socfpga_arria5_socdk.dts          |  2 +-
  arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts |  2 +-
  arch/arm/dts/socfpga_cyclone5_mcvevk.dts       |  2 +-
  arch/arm/dts/socfpga_cyclone5_socdk.dts        |  2 +-
  arch/arm/dts/socfpga_cyclone5_sockit.dts       |  2 +-
  arch/arm/dts/socfpga_cyclone5_socrates.dts     |  2 +-
  8 files changed, 27 insertions(+), 27 deletions(-)

Quoted 14 lines

arch/arm/dts/skeleton.dtsi line 13

Quoted 11 lines

arch/arm/dts/skeleton.dtsi +1 -1

index b41d241..a20da0a 100644
@@ -9,5 +9,5 @@
      #size-cells = <1>;
      chosen { };
      aliases { };
-    memory { device_type = "memory"; reg = <0 0>; };
+    memory at 0 { device_type = "memory"; reg = <0 0>; };
  };

Can you split this into skeleton.dtsi patch and socfpga-only patch? That'd help containing the changes.

Yes, of course!

Quoted 67 lines

Hello Marek,

Am 15.04.2016 um 16:18 schrieb Marek Vasut:

Quoted 64 lines · Heiko Schocher

Quoted 62 lines

Fix following DTC warnings for all socfpga boards:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name, but no reg property

Quoted 3 lines

Quoted 1 line

How come Linux isn't affected by this ?

I think linux is also affected!

You might want to bring it up on the LKML, like Pavel suggested.

Quoted 39 lines

Quoted 24 lines

Quoted 24 lines

Signed-off-by Heiko Schocher <[email protected]>

---
This warnings pop up with the DTC compiler:

$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880430

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238779

   arch/arm/dts/skeleton.dtsi                     |  2 +-
   arch/arm/dts/socfpga.dtsi                      | 40
+++++++++++++-------------
   arch/arm/dts/socfpga_arria5_socdk.dts          |  2 +-
   arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts |  2 +-
   arch/arm/dts/socfpga_cyclone5_mcvevk.dts       |  2 +-
   arch/arm/dts/socfpga_cyclone5_socdk.dts        |  2 +-
   arch/arm/dts/socfpga_cyclone5_sockit.dts       |  2 +-
   arch/arm/dts/socfpga_cyclone5_socrates.dts     |  2 +-
   8 files changed, 27 insertions(+), 27 deletions(-)

Quoted 14 lines

arch/arm/dts/skeleton.dtsi line 13

Quoted 11 lines

arch/arm/dts/skeleton.dtsi +1 -1

index b41d241..a20da0a 100644
@@ -9,5 +9,5 @@
       #size-cells = <1>;
       chosen { };
       aliases { };
-    memory { device_type = "memory"; reg = <0 0>; };
+    memory at 0 { device_type = "memory"; reg = <0 0>; };
   };

Can you split this into skeleton.dtsi patch and socfpga-only patch? That'd help containing the changes.

Quoted 1 line

Yes, of course!

Please hold the patch for a bit, see above.

Hello Marek,

Am 18.04.2016 um 12:36 schrieb Marek Vasut:

Quoted 68 lines · Heiko Schocher

Quoted 67 lines

Hello Marek,

Am 15.04.2016 um 16:18 schrieb Marek Vasut:

Quoted 64 lines · Heiko Schocher

Quoted 62 lines

Fix following DTC warnings for all socfpga boards:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mpuclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/mainclk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/dbg_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_qspi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/main_nand_sdmmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/main_pll/cfg_h2f_usr0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac0_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/emac1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_qsi_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_nand_mmc_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/per_base_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/periph_pll/h2f_usr1_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_2x_dqs_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/ddr_dq_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node
/soc/clkmgr at ffd04000/clocks/sdram_pll/h2f_usr2_clk has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name, but no reg property

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

How come Linux isn't affected by this ?

I think linux is also affected!

You might want to bring it up on the LKML, like Pavel suggested.

Do we have the same DTS as linux?
(If so, isn;t it a bad idea to hold the files on 2 places?)

Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
but no reg property

arch/arm/dts/socfpga.dtsi +1 -1

@@ -128,7 +128,7 @@
 						compatible = "fixed-clock";
 					};
 
-					main_pll: main_pll {
+					main_pll: main_pll at 40 {
 						#address-cells = <1>;
 						#size-cells = <0>;
 						#clock-cells = <0>;

Hi!

Quoted 2 lines

Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
but no reg property

I don't know who produces the warnings, but perhaps fix the tool, instead?

arch/arm/dts/skeleton.dtsi line 13

Quoted 7 lines

arch/arm/dts/skeleton.dtsi +1 -1

@@ -9,5 +9,5 @@
  	#size-cells = <1>;
  	chosen { };
  	aliases { };
-	memory { device_type = "memory"; reg = <0 0>; };
+	memory at 0 { device_type = "memory"; reg = <0 0>; };
  };

This does not look like an improvement to me...

Quoted 13 lines

arch/arm/dts/socfpga.dtsi +1 -1

@@ -128,7 +128,7 @@
  						compatible = "fixed-clock";
  					};
 
-					main_pll: main_pll {
+					main_pll: main_pll at 40 {
  						#address-cells = <1>;
  						#size-cells = <0>;
  						#clock-cells = <0>;

@@ -136,7 +136,7 @@
  						clocks = <&osc1>;
  						reg = <0x40>;
 

arch/arm/dts/socfpga.dtsi line 142

Quoted 5 lines

arch/arm/dts/socfpga.dtsi +1 -1

-						mpuclk: mpuclk {
+						mpuclk: mpuclk at 48 {
  							#clock-cells = <0>;
  							compatible = "altr,socfpga-perip-clk";
  							clocks = <&main_pll>;

Neither do these, actually. So we have clock at fixed addresses. Why is it wrong?

arch/arm/dts/socfpga.dtsi line 748

Quoted 9 lines

arch/arm/dts/socfpga.dtsi +1 -1

@@ -742,7 +742,7 @@
  			reg = <0xffd05000 0x1000>;
  		};
 
-		usbphy0: usbphy at 0 {
+		usbphy0: usbphy {
  			#phy-cells = <0>;
  			compatible = "usb-nop-xceiv";
  			status = "okay";

And this sounds like a bug waiting to happen..

Quoted 7 lines

Hi!

Quoted 2 lines

Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
but no reg property

I don't know who produces the warnings, but perhaps fix the tool, instead?

This warnigns poping up with new DTC compilers, introduced from dtc commit:

ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies
that any

Quoted 7 lines

arch/arm/dts/socfpga.dtsi line 748

Quoted 5 lines

arch/arm/dts/socfpga.dtsi +1 -1

-		usbphy0: usbphy at 0 {
+		usbphy0: usbphy {
 			#phy-cells = <0>;
 			compatible = "usb-nop-xceiv";
 			status = "okay";

And this sounds like a bug waiting to happen..

Better fix would be to add the reg property .. could you help me?

Hi!

Quoted 5 lines

Quoted 5 lines

Hi!

Quoted 2 lines

Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
but no reg property

Quoted 5 lines

Quoted 2 lines

I don't know who produces the warnings, but perhaps fix the tool, instead?

This warnigns poping up with new DTC compilers, introduced from dtc commit:

IMO compiler should be fixed.

Quoted 2 lines

ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies
that any

This is arm. This is not powerpc. It is 2016, not 1997.

Quoted 8 lines

Quoted 7 lines

arch/arm/dts/socfpga.dtsi line 748

Quoted 5 lines

arch/arm/dts/socfpga.dtsi +1 -1

-		usbphy0: usbphy at 0 {
+		usbphy0: usbphy {
 			#phy-cells = <0>;
 			compatible = "usb-nop-xceiv";
 			status = "okay";

And this sounds like a bug waiting to happen..

Quoted 1 line

Better fix would be to add the reg property .. could you help me?

Introduce fake "reg" property to shut up warning?

I guess this should be solved on the kernel list

and I believe the
warnings are wrong.

Best regards,

Pavel

Hi!

Quoted 5 lines

Quoted 5 lines

Hi!

Quoted 2 lines

Warning (unit_address_vs_reg): Node /soc/usbphy at 0 has a unit name,
but no reg property

Quoted 5 lines

Quoted 2 lines

I don't know who produces the warnings, but perhaps fix the tool, instead?

This warnigns poping up with new DTC compilers, introduced from dtc commit:

IMO compiler should be fixed.

Quoted 2 lines

ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies
that any

This is arm. This is not powerpc. It is 2016, not 1997.

Quoted 9 lines

Quoted 7 lines

arch/arm/dts/socfpga.dtsi line 748

Quoted 5 lines

arch/arm/dts/socfpga.dtsi +1 -1

-		usbphy0: usbphy at 0 {
+		usbphy0: usbphy {
  			#phy-cells = <0>;
  			compatible = "usb-nop-xceiv";
  			status = "okay";

And this sounds like a bug waiting to happen..

Better fix would be to add the reg property .. could you help me?

Introduce fake "reg" property to shut up warning?

I guess this should be solved on the kernel list, and I believe the warnings are wrong.

Fix following DTC warnings for all socfpga boards:

Quoted 1 line · Heiko Schocher

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Quoted 6 lines · Tom Rini

Quoted 1 line · Heiko Schocher

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Can you elaborate please?

Quoted 8 lines · Marek Vasut

Quoted 6 lines · Tom Rini

Quoted 1 line · Heiko Schocher

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Can you elaborate please?

Yes, I did in another of the threads here (aside, I wish this was done a series and there was a 0/N, but, oh well). We import these from the kernel, as this isn't a U-Boot change, we're the wrong place to start making these changes by and large. In some quick googling around, the various SoC trees are updating to fix these problems and we'll pull them in whenever our relevant custodian is happy. Or when someone can say "resync with $hash from the kernel" and get them Acked-by or whatever.

Quoted 10 lines · Marek Vasut

Quoted 8 lines · Tom Rini

Quoted 6 lines · Heiko Schocher

Quoted 2 lines

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Can you elaborate please?

Quoted 8 lines

Yes, I did in another of the threads here (aside, I wish this was done a series and there was a 0/N, but, oh well). We import these from the kernel, as this isn't a U-Boot change, we're the wrong place to start making these changes by and large. In some quick googling around, the various SoC trees are updating to fix these problems and we'll pull them in whenever our relevant custodian is happy. Or when someone can say "resync with $hash from the kernel" and get them Acked-by or whatever.

You will want to backport this patch, it's in linux-next too:

http://www.spinics.net/lists/linux-kbuild/msg12538.html

Hello Marek,

Am 18.04.2016 um 19:52 schrieb Marek Vasut:

Quoted 19 lines · Tom Rini

Quoted 10 lines · Marek Vasut

Quoted 8 lines · Tom Rini

Quoted 6 lines · Heiko Schocher

Quoted 2 lines

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Can you elaborate please?

Quoted 8 lines

Yes, I did in another of the threads here (aside, I wish this was done a series and there was a 0/N, but, oh well). We import these from the kernel, as this isn't a U-Boot change, we're the wrong place to start making these changes by and large. In some quick googling around, the various SoC trees are updating to fix these problems and we'll pull them in whenever our relevant custodian is happy. Or when someone can say "resync with $hash from the kernel" and get them Acked-by or whatever.

Quoted 3 lines

You will want to backport this patch, it's in linux-next too:

http://www.spinics.net/lists/linux-kbuild/msg12538.html

Yes ... we ignore warnings ... maybe an agreement ...

I can prepare a patch for this, but I prefer to add this build flag for each arch, so we can at least remove it for each arch, when all warnings are fixed in linux and we did a sync with linux ...

Would this be OK?

Quoted 8 lines · Tom Rini

Quoted 6 lines · Heiko Schocher

Quoted 2 lines

Fix following DTC warnings for all socfpga boards:

We're going to defer on this patch for now, thanks.

Can you elaborate please?

Yes, I did in another of the threads here (aside, I wish this was done a series and there was a 0/N, but, oh well). We import these from the

kernel, as this isn't a U-Boot change, we're the wrong place to start making these changes by and large. In some quick googling around, the various SoC trees are updating to fix these problems and we'll pull them in whenever our relevant custodian is happy. Or when someone can say "resync with $hash from the kernel" and get them Acked-by or whatever.