arm: mx5: Fix NAND image generation
Subsystems (2)
PATCH 1/1 arm: mx5: Fix NAND image generation
The echo -ne "\xNN" does not work in certain bourne-compatible shells, like dash. The recommended way of hex->char conversion is using printf(1), but there is a pitfall here. The GNU printf does support "\xNN" format, but according to the opengroup documentation, this is not part of POSIX. The POSIX printf only defines "\NNN" where N is octal. Thus, for the sake of compatibility, we use that.
--- arch/arm/imx-common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/imx-common/Makefile +1 -1
@@ -86,7 +86,7 @@ u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE $(call if_changed,pad_cat) quiet_cmd_u-boot-nand-spl_imx = GEN $@ -cmd_u-boot-nand-spl_imx = (echo -ne '\x00\x00\x00\x00\x46\x43\x42\x20\x01' && \ +cmd_u-boot-nand-spl_imx = (printf '\000\000\000\000\106\103\102\040\001' && \ dd bs=1015 count=1 if=/dev/zero 2>/dev/null) | cat - $< > $@ spl/u-boot-nand-spl.imx: SPL FORCE
Signature · 1 line
2.8.0.rc3
PATCH 1/1 arm: mx5: Fix NAND image generation
Quoted 19 lines · Marek Vasut
The echo -ne "\xNN" does not work in certain bourne-compatible shells, like dash. The recommended way of
hex->charconversion is using printf(1), but there is a pitfall here. The GNU printf does support "\xNN" format, but according to the opengroup documentation, this is not part of POSIX. The POSIX printf only defines "\NNN" where N is octal. Thus, for the sake of compatibility, we use that.Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>--- arch/arm/imx-common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/imx-common/Makefile +0
-0
arch/arm/imx-common/Makefile u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE · line 92
Quoted 8 lines
arch/arm/imx-common/Makefile +1
-1@@ -86,7 +86,7 @@ u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE $(call if_changed,pad_cat) quiet_cmd_u-boot-nand-spl_imx = GEN $@ -cmd_u-boot-nand-spl_imx = (echo -ne '\x00\x00\x00\x00\x46\x43\x42\x20\x01' && \ +cmd_u-boot-nand-spl_imx = (printf '\000\000\000\000\106\103\102\040\001' && \ dd bs=1015 count=1 if=/dev/zero 2>/dev/null) | cat - $< > $@ spl/u-boot-nand-spl.imx: SPL FORCE
Can this be applied? This fixes real bug.
Signature · 2 lines
Best regards, Marek Vasut
Stefano Babic
AppliedPATCH 1/1 arm: mx5: Fix NAND image generation
In reply to Marek VasutQuoted 19 lines · Marek Vasut
The echo -ne "\xNN" does not work in certain bourne-compatible shells, like dash. The recommended way of
hex->charconversion is using printf(1), but there is a pitfall here. The GNU printf does support "\xNN" format, but according to the opengroup documentation, this is not part of POSIX. The POSIX printf only defines "\NNN" where N is octal. Thus, for the sake of compatibility, we use that.Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>--- arch/arm/imx-common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/imx-common/Makefile +0
-0
arch/arm/imx-common/Makefile u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE · line 92
Quoted 8 lines
arch/arm/imx-common/Makefile +1
-1@@ -86,7 +86,7 @@ u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE $(call if_changed,pad_cat) quiet_cmd_u-boot-nand-spl_imx = GEN $@ -cmd_u-boot-nand-spl_imx = (echo -ne '\x00\x00\x00\x00\x46\x43\x42\x20\x01' && \ +cmd_u-boot-nand-spl_imx = (printf '\000\000\000\000\106\103\102\040\001' && \ dd bs=1015 count=1 if=/dev/zero 2>/dev/null) | cat - $< > $@ spl/u-boot-nand-spl.imx: SPL FORCE
Applied to master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================