btrfs-progs: prop: remove an unnecessary condition on parse_args

PATCH Applied Satoru Takeuchi 2 participants 2 messages Apr 20, 2016 – Apr 25, 2016 Btrfs file system

lore

Share & tools

lore

Satoru Takeuchi

author

2016-04-20 06:33 UTC #0 lore raw

PATCH 1/1 btrfs-progs: prop: remove an unnecessary condition on parse_args

Quoted 1 line

From commit c742debab11f ('btrfs-progs: fix a regression that

"property" with -t option doesn't work'), the number of arguments is checked strictly. So the following condition never be satisfied.

Signed-off-by Satoru Takeuchi <[email protected]>

---
 cmds-property.c | 5 -----
 1 file changed, 5 deletions(-)

cmds-property.c +0 -5

index eed5f4a..48a8945 100644
@@ -352,11 +352,6 @@ static void parse_args(int argc, char **argv,
 	if (value && optind < argc)
 		*value = argv[optind++];
 
-	if (optind != argc) {
-		error("unexpected agruments found");
-		usage(usage_str);
-	}
-
 	if (!*types && object && *object) {
 		ret = autodetect_object_types(*object, types);
 		if (ret < 0) {

Signature · 1 line

2.5.5

David Sterba

Applied

2016-04-25 12:02 UTC #1 lore raw

Quoted 6 lines · Satoru Takeuchi

Quoted 1 line
From commit c742debab11f ('btrfs-progs: fix a regression that
"property" with -t option doesn't work'), the number of arguments is checked strictly. So the following condition never be satisfied.
Signed-off-by Satoru Takeuchi <[email protected]>

Applied, thanks.