Skip to contentSkip to conversation

tag.c: remove extern keyword from function definition

PATCH In review Ramsay Jones 2 participants 2 messages Jun 16, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tag.c: remove extern keyword from function definition

---

Hi Santiago,

If you need to re-roll your 'st/verify-tag' branch, could you please squash this into the relevant patch (commit c5213b40, "verify-tag: move tag verification code to tag.c", 19-04-2016).

Although not actually an error, it is very unusual for an extern keyword to be used on a function definition (it seems to be getting quite unusual on a function declaration these days!), which causes sparse to issue a warning.

Thanks!

ATB,
Ramsay Jones

 tag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tag.c +1 -1
index ace619a..93c6ae6 100644
@@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
 	return ret;
 }
 
-extern int gpg_verify_tag(const unsigned char *sha1,
+int gpg_verify_tag(const unsigned char *sha1,
 		const char *name_to_report, unsigned flags)
 {
 	enum object_type type;
Signature · 1 line
2.8.0
#1 lore raw
Quoted 6 lines · Ramsay Jones

---

Hi Santiago,

Quoted 8 lines

If you need to re-roll your 'st/verify-tag' branch, could you please squash this into the relevant patch (commit c5213b40, "verify-tag: move tag verification code to tag.c", 19-04-2016).

Although not actually an error, it is very unusual for an extern keyword to be used on a function definition (it seems to be getting quite unusual on a function declaration these days!), which causes sparse to issue a warning.

Oh sure! I'm waiting to see if there are more reviews regarding this and I'll re-roll. It's defintely unecessary to have the extern keyword there.

Thanks for pointing it out!

-Santiago.