Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

PATCH New Zhao Qiang 2 participants 6 messages Apr 11, 2016 – Jul 20, 2016 PCI

lore

Share & tools

lore

Zhao Qiang

author

2016-04-11 08:53 UTC #0 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.

The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS
down-training issue, we need to revert it and find the root cause for T2080QDS
down-training issue.

Signed-off-by Zhao Qiang <[email protected]>

---
 drivers/pci/fsl_pci_init.c | 15 ---------------
 include/configs/T208xQDS.h |  1 -
 2 files changed, 16 deletions(-)

drivers/pci/fsl_pci_init.c +0 ~~-15~~

index 52792dc..1143178 100644
@@ -444,21 +444,6 @@ void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
 			ltssm = (in_be32(&pci->pex_csr0)
 				& PEX_CSR0_LTSSM_MASK) >> PEX_CSR0_LTSSM_SHIFT;
 			enabled = (ltssm == 0x11) ? 1 : 0;
-#ifdef CONFIG_FSL_PCIE_RESET
-			int i;
-			/* assert PCIe reset */
-			setbits_be32(&pci->pdb_stat, 0x08000000);
-			(void) in_be32(&pci->pdb_stat);
-			udelay(1000);
-			/* clear PCIe reset */
-			clrbits_be32(&pci->pdb_stat, 0x08000000);
-			asm("sync;isync");
-			for (i = 0; i < 100 && ltssm < PCI_LTSSM_L0; i++) {
-				pci_hose_read_config_word(hose, dev, PCI_LTSSM,
-							  &ltssm);
-				udelay(1000);
-			}
-#endif
 		} else {
 		/* pci_hose_read_config_word(hose, dev, PCI_LTSSM, &ltssm); */
 		/* enabled = ltssm >= PCI_LTSSM_L0; */

include/configs/T208xQDS.h +0 -1

index 5957fa8..c895818 100644
@@ -559,7 +559,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_PCIE2		/* PCIE controler 2 */
 #define CONFIG_PCIE3		/* PCIE controler 3 */
 #define CONFIG_PCIE4		/* PCIE controler 4 */
-#define CONFIG_FSL_PCIE_RESET
 #define CONFIG_FSL_PCI_INIT	/* Use common FSL init code */
 #define CONFIG_SYS_PCI_64BIT	/* enable 64-bit PCI resources */
 /* controller 1, direct to uli, tgtid 3, Base address 20000 */

Signature · 1 line

2.1.0.27.g96db324

York Sun

2016-04-20 16:57 UTC #1 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

Quoted 7 lines · Zhao Qiang

This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.
The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS
down-training issue, we need to revert it and find the root cause for T2080QDS
down-training issue.

You have a bad wrap-back in commit message.

Does the workaround block anything? Can you revert it after figuring out the root cause?

York

Quoted 46 lines

Signed-off-by Zhao Qiang <[email protected]>

---
 drivers/pci/fsl_pci_init.c | 15 ---------------
 include/configs/T208xQDS.h |  1 -
 2 files changed, 16 deletions(-)

drivers/pci/fsl_pci_init.c +0 ~~-15~~

index 52792dc..1143178 100644
@@ -444,21 +444,6 @@ void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
 			ltssm = (in_be32(&pci->pex_csr0)
 				& PEX_CSR0_LTSSM_MASK) >> PEX_CSR0_LTSSM_SHIFT;
 			enabled = (ltssm == 0x11) ? 1 : 0;
-#ifdef CONFIG_FSL_PCIE_RESET
-			int i;
-			/* assert PCIe reset */
-			setbits_be32(&pci->pdb_stat, 0x08000000);
-			(void) in_be32(&pci->pdb_stat);
-			udelay(1000);
-			/* clear PCIe reset */
-			clrbits_be32(&pci->pdb_stat, 0x08000000);
-			asm("sync;isync");
-			for (i = 0; i < 100 && ltssm < PCI_LTSSM_L0; i++) {
-				pci_hose_read_config_word(hose, dev, PCI_LTSSM,
-							  &ltssm);
-				udelay(1000);
-			}
-#endif
 		} else {
 		/* pci_hose_read_config_word(hose, dev, PCI_LTSSM, &ltssm); */
 		/* enabled = ltssm >= PCI_LTSSM_L0; */

include/configs/T208xQDS.h +0 -1

index 5957fa8..c895818 100644
@@ -559,7 +559,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_PCIE2		/* PCIE controler 2 */
 #define CONFIG_PCIE3		/* PCIE controler 3 */
 #define CONFIG_PCIE4		/* PCIE controler 4 */
-#define CONFIG_FSL_PCIE_RESET
 #define CONFIG_FSL_PCI_INIT	/* Use common FSL init code */
 #define CONFIG_SYS_PCI_64BIT	/* enable 64-bit PCI resources */
 /* controller 1, direct to uli, tgtid 3, Base address 20000 */

Qiang Zhao

author

2016-04-21 01:05 UTC #2 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

Quoted 11 lines · York Sun

-----Original Message-----
From: York Sun [mailto:york.sun at nxp.com]
Sent: Thursday, April 21, 2016 12:58 AM
To: Qiang Zhao <[email protected]>
Cc: Xiaobo Xie <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Quoted 2 lines · Zhao Qiang
This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.

Quoted 9 lines

Quoted 3 lines
The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS down-training issue, we need to revert it and find the root cause for T2080QDS down-training issue.
You have a bad wrap-back in commit message.
Does the workaround block anything? Can you revert it after figuring out the root cause?

Yes, it blocks t2080RDB and c29x when using them as iNIC. If revert it after figuring out the root cause, how about iNIC? And I am afraid of it is a hard way to find the root cause.

Quoted 51 lines

drivers/pci/fsl_pci_init.c void fsl_pci_init(struct pci_controller *hose, struct
Quoted 13 lines
Signed-off-by Zhao Qiang <[email protected]>
---
 drivers/pci/fsl_pci_init.c | 15 ---------------
include/configs/T208xQDS.h |  1 -
 2 files changed, 16 deletions(-)
drivers/pci/fsl_pci_init.c +0 -0
index 52792dc..1143178 100644
@@ -444,21 +444,6 @@ void fsl_pci_init(struct pci_controller *hose, struct
fsl_pci_info *pci_info)
drivers/pci/fsl_pci_init.c void fsl_pci_init(struct pci_controller *hose, struct · line 445
Quoted 2 lines
drivers/pci/fsl_pci_init.c +0 -0
 			ltssm = (in_be32(&pci->pex_csr0)
 				& PEX_CSR0_LTSSM_MASK) >>
PEX_CSR0_LTSSM_SHIFT;
drivers/pci/fsl_pci_init.c void fsl_pci_init(struct pci_controller *hose, struct · line 446
Quoted 1 line
drivers/pci/fsl_pci_init.c +0 -0
 			enabled = (ltssm == 0x11) ? 1 : 0; -#ifdef
CONFIG_FSL_PCIE_RESET
drivers/pci/fsl_pci_init.c void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
Quoted 10 lines
drivers/pci/fsl_pci_init.c +0 ~~-10~~
-			int i;
-			/* assert PCIe reset */
-			setbits_be32(&pci->pdb_stat, 0x08000000);
-			(void) in_be32(&pci->pdb_stat);
-			udelay(1000);
-			/* clear PCIe reset */
-			clrbits_be32(&pci->pdb_stat, 0x08000000);
-			asm("sync;isync");
-			for (i = 0; i < 100 && ltssm < PCI_LTSSM_L0; i++) {
-				pci_hose_read_config_word(hose, dev,
PCI_LTSSM,
drivers/pci/fsl_pci_init.c void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
Quoted 6 lines
drivers/pci/fsl_pci_init.c +0 -4
-							  &ltssm);
-				udelay(1000);
-			}
-#endif
 		} else {
 		/* pci_hose_read_config_word(hose, dev, PCI_LTSSM, &ltssm);
*/
Quoted 14 lines
drivers/pci/fsl_pci_init.c +0 -0
 		/* enabled = ltssm >= PCI_LTSSM_L0; */ diff --git
a/include/configs/T208xQDS.h b/include/configs/T208xQDS.h index 5957fa8..c895818 100644
include/configs/T208xQDS.h +0 -1
@@ -559,7 +559,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_PCIE2		/* PCIE controler 2 */
 #define CONFIG_PCIE3		/* PCIE controler 3 */
 #define CONFIG_PCIE4		/* PCIE controler 4 */
-#define CONFIG_FSL_PCIE_RESET
 #define CONFIG_FSL_PCI_INIT	/* Use common FSL init code */
 #define CONFIG_SYS_PCI_64BIT	/* enable 64-bit PCI resources */
 /* controller 1, direct to uli, tgtid 3, Base address 20000 */

York Sun

2016-04-21 01:12 UTC #3 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

+Roy to comment on iNIC.

Quoted 18 lines · Qiang Zhao

Quoted 17 lines · York Sun
-----Original Message-----
From: York Sun [mailto:york.sun at nxp.com]
Sent: Thursday, April 21, 2016 12:58 AM
To: Qiang Zhao <[email protected]>
Cc: Xiaobo Xie <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Quoted 5 lines · Zhao Qiang
This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.
The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS down-training issue, we need to revert it and find the root cause for T2080QDS down-training issue.
You have a bad wrap-back in commit message.

Quoted 8 lines

Quoted 3 lines
Does the workaround block anything? Can you revert it after figuring out the root cause?
Yes, it blocks t2080RDB and c29x when using them as iNIC. If revert it after figuring out the root cause, how about iNIC? And I am afraid of it is a hard way to find the root cause.

Qiang,

You delete the code gated by CONFIG_FSL_PCIE_RESET, and the macro for T208xQDS. How does that affect T2080RDB or C29x?

York

york sun

2016-07-19 22:04 UTC #4 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

Quoted 30 lines · York Sun

+Roy to comment on iNIC.
Quoted 18 lines · Qiang Zhao
Quoted 17 lines · York Sun
-----Original Message-----
From: York Sun [mailto:york.sun at nxp.com]
Sent: Thursday, April 21, 2016 12:58 AM
To: Qiang Zhao <[email protected]>
Cc: Xiaobo Xie <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Quoted 5 lines · Zhao Qiang
This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.
The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS down-training issue, we need to revert it and find the root cause for T2080QDS down-training issue.
You have a bad wrap-back in commit message.
Quoted 8 lines
Quoted 3 lines
Does the workaround block anything? Can you revert it after figuring out the root cause?
Yes, it blocks t2080RDB and c29x when using them as iNIC. If revert it after figuring out the root cause, how about iNIC? And I am afraid of it is a hard way to find the root cause.

Quoted 5 lines

Qiang,
You delete the code gated by CONFIG_FSL_PCIE_RESET, and the macro for T208xQDS. How does that affect T2080RDB or C29x?

Qiang,

Do you have an update? If not, I will defer this patch.

York

Qiang Zhao

author

2016-07-20 01:27 UTC #5 lore raw

PATCH 1/1 Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"

Quoted 42 lines · York Sun

-----Original Message-----
From: york sun
Sent: Wednesday, July 20, 2016 6:05 AM
To: Qiang Zhao <[email protected]>
Cc: Xiaobo Xie <[email protected]>; u-boot at lists.denx.de; Roy Zang <[email protected]>
Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Quoted 32 lines · York Sun
+Roy to comment on iNIC.
Quoted 18 lines · Qiang Zhao
Quoted 17 lines · York Sun
-----Original Message-----
From: York Sun [mailto:york.sun at nxp.com]
Sent: Thursday, April 21, 2016 12:58 AM
To: Qiang Zhao <[email protected]>
Cc: Xiaobo Xie <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] Revert "T2080QDS/PCIe: Soft Reset PCIe on T2080QDS for down-training issue"
Quoted 5 lines · Zhao Qiang
This reverts commit 5066e62847bddf6030262ade2aa3e7bcdc930037.
The reverted patch will block t2080RDB iNiC, it was a workaround for T2080QDS down-training issue, we need to revert it and find the root cause for T2080QDS down-training issue.
You have a bad wrap-back in commit message.
Quoted 8 lines
Quoted 3 lines
Does the workaround block anything? Can you revert it after figuring out the root cause?
Yes, it blocks t2080RDB and c29x when using them as iNIC. If revert it after figuring out the root cause, how about iNIC? And I am afraid of it is a hard way to find the root cause.
Qiang,

Quoted 9 lines

Quoted 1 line
You delete the code gated by CONFIG_FSL_PCIE_RESET, and the macro for
T208xQDS.
Quoted 2 lines
How does that affect T2080RDB or C29x?
Qiang,
Do you have an update? If not, I will defer this patch.

There is no any update.

-Zhao Qiang