Skip to contentSkip to conversation

fix xf86-video-omapfb and grub_git for armv7a

PATCH In review Robert Yang 2 participants 7 messages Apr 18, 2016 – Apr 22, 2016

lore
Share & tools
lore
#0 lore raw

cover fix xf86-video-omapfb and grub_git for armv7a

The following changes since commit 37aac647d510557323083c77c3114476440a325d:

fs-perms.txt: fix ROOT_HOME's permission (2016-04-15 06:58:49 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/arm
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/arm

Robert Yang (2):
xf86-video-omapfb: remove EXTRA_OECONF_armv7a
grub_git: set COMPATIBLE_HOST_armv7a to null

 meta/recipes-bsp/grub/grub_git.bb                          | 1 +
 meta/recipes-graphics/xorg-driver/xf86-video-omapfb_git.bb | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.8.0
#1 lore raw

PATCH 1/2 xf86-video-omapfb: remove EXTRA_OECONF_armv7a

Fixe when build with armv7a:
gcc -c ../../git/src/sw-exa.c -fPIC -DPIC -o .libs/sw-exa.o
{standard input}: Assembler messages:
{standard input}:179: Error: selected processor does not support vld1.u8 {d0},[r1]!' in ARM mode {standard input}:182: Error: selected processor does not support vld1.u8 {d1},[r4]!' in ARM mode {standard input}:183: Error: selected processor does not support vld1.u8 {q1},[r0]!' in ARM mode {standard input}:184: Error: selected processor does not support vzip.u8 d0,d1' in ARM mode {standard input}:185: Error: selected processor does not support vld1.u8 {q2},[ip]!' in ARM mode {standard input}:186: Error: selected processor does not support vst2.u8 {q0,q1},[fp]!' in ARM mode {standard input}:187: Error: selected FPU does not support instruction -- vmov.u8 q1,q2' {standard input}:188: Error: selected processor does not support vst2.u8 {q0,q1},[lr]!' in ARM mode {standard input}:239: Error: selected processor does not support vld1.u8 {d0},[r1]!' in ARM mode {standard input}:242: Error: selected processor does not support vld1.u8 {d1},[r4]!' in ARM mode {standard input}:243: Error: selected processor does not support vld1.u8 {q1},[r0]!' in ARM mode {standard input}:244: Error: selected processor does not support vzip.u8 d0,d1' in ARM mode {standard input}:245: Error: selected processor does not support vld1.u8 {q2},[ip]!' in ARM mode {standard input}:246: Error: selected processor does not support vst2.u8 {q0,q1},[fp]!' in ARM mode {standard input}:247: Error: selected FPU does not support instruction -- vmov.u8 q1,q2' {standard input}:248: Error: selected processor does not support vst2.u8 {q0,q1},[lr]!' in ARM mode make[2]: *** [image-format-conversions.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
../../git/src/omapfb-crtc.c: In function 'OMAPFBCrtcResize':
../../git/src/omapfb-crtc.c:34:12: warning: unused variable 'ofb' [-Wunused-variable]

  OMAPFBPtr ofb = OMAPFB(pScrn);
            ^
../../git/src/omapfb-xv.c:66:43: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     { XvSettable | XvGettable, 0, 0xffff, "XV_COLORKEY" },
---
 meta/recipes-graphics/xorg-driver/xf86-video-omapfb_git.bb | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-graphics/xorg-driver/xf86-video-omapfb_git.bb +0 -1
index 3ccd870..7ebb960 100644
@@ -29,7 +29,6 @@ SRC_URI = "git://anonscm.debian.org/collab-maint/xf86-video-omapfb.git \
 
 S = "${WORKDIR}/git"
 
-EXTRA_OECONF_armv7a = " --enable-neon "
 CFLAGS += " -I${STAGING_INCDIR}/xorg "
 
 # Use overlay 2 on omap3 to enable other apps to use overlay 1 (e.g. dmai or omapfbplay)
Signature · 1 line
2.8.0
#2 lore raw

PATCH 2/2 grub_git: set COMPATIBLE_HOST_armv7a to null

In reply to Robert Yang

It doesn't work with armv7a:

| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [reboot.mod] Error 1
| make[3]: *** Waiting for unfinished jobs....
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [halt.mod] Error 1
| make[3]: *** [cat.mod] Error 1
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [disk.mod] Error 1
| make[3]: *** [gptsync.mod] Error 1
| make[3]: *** [eval.mod] Error 1
| build-grub-module-verifier: error:build-grub-module-verifier: error:  unsupported relocation 0x2bunsupported relocation 0x2b.
---
 meta/recipes-bsp/grub/grub_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-bsp/grub/grub_git.bb +1 -0
index 6919c9a..8f8c5ed 100644
@@ -18,6 +18,7 @@ SRC_URI = "git://git.savannah.gnu.org/grub.git \
 S = "${WORKDIR}/git"
 
 COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
+COMPATIBLE_HOST_armv7a = 'null'
 
 inherit autotools gettext texinfo
 
Signature · 1 line
2.8.0
#3 lore raw

Re: [PATCH 2/2] grub_git: set COMPATIBLE_HOST_armv7a to null

Andre's comment from the last time you submitted this is still valid:

Unless you have verified that armv4, armv5, armv6 and armv7ve all work

Quoted 2 lines

correctly then blacklisting only armv7a is probably not the correct approach.

Have you tested all the other architectures?

Ross

Quoted 44 lines · Robert Yang

It doesn't work with armv7a:

| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [reboot.mod] Error 1
| make[3]: *** Waiting for unfinished jobs....
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [halt.mod] Error 1
| make[3]: *** [cat.mod] Error 1
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| build-grub-module-verifier: error: unsupported relocation 0x2b.
| make[3]: *** [disk.mod] Error 1
| make[3]: *** [gptsync.mod] Error 1
| make[3]: *** [eval.mod] Error 1
| build-grub-module-verifier: error:build-grub-module-verifier: error:

unsupported relocation 0x2bunsupported relocation 0x2b.

---
 meta/recipes-bsp/grub/grub_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-bsp/grub/ renamed from meta/recipes-bsp/grub/grub_git.bb +0 -0

grub_git.bb
index 6919c9a..8f8c5ed 100644

meta/recipes-bsp/grub/grub_git.bb +1 -1
@@ -18,6 +18,7 @@ SRC_URI = "git://git.savannah.gnu.org/grub.git \
 S = "${WORKDIR}/git"
 
 COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
+COMPATIBLE_HOST_armv7a = 'null'
 
 inherit autotools gettext texinfo
 
--

2.8.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 2/2] grub_git: set COMPATIBLE_HOST_armv7a to null

Quoted 8 lines · Ross

Andre's comment from the last time you submitted this is still valid:

Unless you have verified that armv4, armv5, armv6 and armv7ve all work correctly then blacklisting only armv7a is probably not the correct approach.

Have you tested all the other architectures?

No, I will have a try.

// Robert

Quoted 54 lines

Ross

On 18 April 2016 at 10:29, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

    It doesn't work with armv7a:
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [reboot.mod] Error 1
    | make[3]: *** Waiting for unfinished jobs....
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [halt.mod] Error 1
    | make[3]: *** [cat.mod] Error 1
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [disk.mod] Error 1
    | make[3]: *** [gptsync.mod] Error 1
    | make[3]: *** [eval.mod] Error 1
    | build-grub-module-verifier: error:build-grub-module-verifier: error:
    unsupported relocation 0x2bunsupported relocation 0x2b.

    Signed-off-by: Robert Yang <[email protected]
    <mailto:[email protected]>>
    ---
      meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb> | 1 +
      1 file changed, 1 insertion(+)

    diff --git a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    index 6919c9a..8f8c5ed 100644
    --- a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    +++ b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    @@ -18,6 +18,7 @@ SRC_URI = "git://git.savannah.gnu.org/grub.git
    <http://git.savannah.gnu.org/grub.git> \
      S = "${WORKDIR}/git"

      COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
    +COMPATIBLE_HOST_armv7a = 'null'

      inherit autotools gettext texinfo

    --
    2.8.0

    --
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#5 lore raw

Re: [PATCH 2/2] grub_git: set COMPATIBLE_HOST_armv7a to null

Quoted 5 lines · Robert Yang
Quoted 2 lines · Ross

Andre's comment from the last time you submitted this is still valid:

Quoted 8 lines
Quoted 6 lines

Unless you have verified that armv4, armv5, armv6 and armv7ve all work correctly then blacklisting only armv7a is probably not the correct approach.

Have you tested all the other architectures?

No, I will have a try.

I tried:
armv7a
armv7at
armv4
armv5

There isn't anything *more* wrong with grub_git except armv7a, so I think that mark it COMPATIBLE_HOST_armv7a = 'null' is OK, but I did find other recipes failed to build, I will send a new PULL.

We have quite a lot of arm tunes, I think that we need a script or tool to auto test them. What's your opinion, please ?

// Robert

Quoted 57 lines

// Robert

Quoted 54 lines

Ross

On 18 April 2016 at 10:29, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

    It doesn't work with armv7a:
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [reboot.mod] Error 1
    | make[3]: *** Waiting for unfinished jobs....
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [halt.mod] Error 1
    | make[3]: *** [cat.mod] Error 1
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [disk.mod] Error 1
    | make[3]: *** [gptsync.mod] Error 1
    | make[3]: *** [eval.mod] Error 1
    | build-grub-module-verifier: error:build-grub-module-verifier: error:
    unsupported relocation 0x2bunsupported relocation 0x2b.

    Signed-off-by: Robert Yang <[email protected]
    <mailto:[email protected]>>
    ---
      meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb> | 1 +
      1 file changed, 1 insertion(+)

    diff --git a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    index 6919c9a..8f8c5ed 100644
    --- a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    +++ b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    @@ -18,6 +18,7 @@ SRC_URI = "git://git.savannah.gnu.org/grub.git
    <http://git.savannah.gnu.org/grub.git> \
      S = "${WORKDIR}/git"

      COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
    +COMPATIBLE_HOST_armv7a = 'null'

      inherit autotools gettext texinfo

    --
    2.8.0

    --
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#6 lore raw

Re: [PATCH 2/2] grub_git: set COMPATIBLE_HOST_armv7a to null

Quoted 15 lines · Robert Yang
Quoted 12 lines · Robert Yang
Quoted 8 lines · Ross

Andre's comment from the last time you submitted this is still valid:

Unless you have verified that armv4, armv5, armv6 and armv7ve all work correctly then blacklisting only armv7a is probably not the correct approach.

Have you tested all the other architectures?

Quoted 7 lines
Quoted 1 line

No, I will have a try.

I tried:
armv7a
armv7at
armv4
armv5

Also armv6.

// Robert

Quoted 67 lines

There isn't anything *more* wrong with grub_git except armv7a, so I think that mark it COMPATIBLE_HOST_armv7a = 'null' is OK, but I did find other recipes failed to build, I will send a new PULL.

We have quite a lot of arm tunes, I think that we need a script or tool to auto test them. What's your opinion, please ?

// Robert

Quoted 57 lines

// Robert

Quoted 54 lines

Ross

On 18 April 2016 at 10:29, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

    It doesn't work with armv7a:
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [reboot.mod] Error 1
    | make[3]: *** Waiting for unfinished jobs....
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [halt.mod] Error 1
    | make[3]: *** [cat.mod] Error 1
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | build-grub-module-verifier: error: unsupported relocation 0x2b.
    | make[3]: *** [disk.mod] Error 1
    | make[3]: *** [gptsync.mod] Error 1
    | make[3]: *** [eval.mod] Error 1
    | build-grub-module-verifier: error:build-grub-module-verifier: error:
    unsupported relocation 0x2bunsupported relocation 0x2b.

    Signed-off-by: Robert Yang <[email protected]
    <mailto:[email protected]>>
    ---
      meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb> | 1 +
      1 file changed, 1 insertion(+)

    diff --git a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    index 6919c9a..8f8c5ed 100644
    --- a/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    +++ b/meta/recipes-bsp/grub/grub_git.bb <http://grub_git.bb>
    @@ -18,6 +18,7 @@ SRC_URI = "git://git.savannah.gnu.org/grub.git
    <http://git.savannah.gnu.org/grub.git> \
      S = "${WORKDIR}/git"

      COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*)-(linux.*|freebsd.*)'
    +COMPATIBLE_HOST_armv7a = 'null'

      inherit autotools gettext texinfo

    --
    2.8.0

    --
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core