travis: turn off dtc unit address warnings
Subsystems (7)
PATCH 1/1 travis: turn off dtc unit address warnings
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".
If all DTS are fixed, we can remove this flag again.
---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/
travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
arch/arc/dts/Makefile +2 -0
@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/arm/dts/Makefile +2 -1
@@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/microblaze/dts/Makefile +2 -0
@@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/mips/dts/Makefile +2 -1
@@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/nios2/dts/Makefile +2 -0
@@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/powerpc/dts/Makefile +2 -0
@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/sandbox/dts/Makefile +2 -0
@@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/x86/dts/Makefile +2 -0
@@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
Signature · 1 line
2.5.0
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 11 lines · Heiko Schocher
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.
Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016
Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
Isn't there some common place in scripts/ or so where we can disable this warning using an one-liner ?
Quoted 107 lines
arch/arc/dts/Makefile +2
-0@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/arm/dts/Makefile +2
-1@@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/microblaze/dts/Makefile +2
-0@@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/mips/dts/Makefile +2
-1@@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/nios2/dts/Makefile +2
-0@@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/powerpc/dts/Makefile +2
-0@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/sandbox/dts/Makefile +2
-0@@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/x86/dts/Makefile +2
-0@@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 travis: turn off dtc unit address warnings
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?
I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
bye,
Heiko
Quoted 110 lines
Quoted 108 lines
arch/arc/dts/Makefile +2
-0@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/arm/dts/Makefile +2
-1@@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/microblaze/dts/Makefile +2
-0@@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/mips/dts/Makefile +2
-1@@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/nios2/dts/Makefile +2
-0@@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/powerpc/dts/Makefile +2
-0@@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/sandbox/dts/Makefile +2
-0@@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))arch/x86/dts/Makefile +2
-0@@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 35 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 16 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 36 lines · Marek Vasut
Quoted 35 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 16 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Agreed.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/306e97a8/attachment.sig>
PATCH 1/1 travis: turn off dtc unit address warnings
In reply to Marek VasutHi,
Quoted 36 lines · Marek Vasut
Quoted 35 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 16 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Wouldn't it be better to fix the problems?
Regards,
Simon
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 42 lines · Simon Glass
Hi,
Quoted 39 lines · Marek Vasut
Quoted 38 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 34 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Wouldn't it be better to fix the problems?
My impression was that these warnings are just the result of over-eagerness of DTC, that's why Linux prints them only if you increase the W= (warning) verbosity. I might be wrong tho.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 46 lines · Marek Vasut
Quoted 45 lines · Simon Glass
Hi,
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Wouldn't it be better to fix the problems?
My impression was that these warnings are just the result of over-eagerness of DTC, that's why Linux prints them only if you increase the W= (warning) verbosity. I might be wrong tho.
They are minor problems. For the vast majority of the dts files we have, the fixes will come in via re-syncs with the kernel and in at least some cases it's not just a simple regex but also "oh, lets give things better names". With respect to dts files that we really do own (ie x86) yes, we should fix them.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/3099776f/attachment.sig>
PATCH 1/1 travis: turn off dtc unit address warnings
Hello Tom,
Am 21.04.2016 um 15:53 schrieb Tom Rini:
Quoted 56 lines · Marek Vasut
Quoted 46 lines · Simon Glass
Quoted 45 lines
Hi,
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Wouldn't it be better to fix the problems?
My impression was that these warnings are just the result of over-eagerness of DTC, that's why Linux prints them only if you increase the W= (warning) verbosity. I might be wrong tho.
Quoted 5 lines
They are minor problems. For the vast majority of the dts files we have, the fixes will come in via re-syncs with the kernel and in at least some cases it's not just a simple regex but also "oh, lets give things better names". With respect to dts files that we really do own (ie x86) yes, we should fix them.
So, this patch from me could be still an option?
http://patchwork.ozlabs.org/patch/610866/
(at least for the sandbox fixes?)
(I have a v2 where I worked in the comments from Bin ...)
bye,
Heiko
Signature · 3 lines
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 travis: turn off dtc unit address warnings
Quoted 65 lines · Heiko Schocher
Hello Tom,
Am 21.04.2016 um 15:53 schrieb Tom Rini:
Quoted 56 lines · Marek Vasut
Quoted 46 lines · Simon Glass
Quoted 45 lines
Hi,
Quoted 42 lines · Marek Vasut
Quoted 40 lines · Heiko Schocher
Hello Marek,
Am 21.04.2016 um 14:51 schrieb Marek Vasut:
Quoted 32 lines · Heiko Schocher
Quoted 11 lines
suppress a lot of
"reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg".If all DTS are fixed, we can remove this flag again.
Signed-off-by Heiko Schocher <[email protected]>---
There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want.Yep
Quoted 7 lines
With this patch and patch:
http://patchwork.ozlabs.org/patch/609150/travis build passes, see:
https://travis-ci.org/hsdenx/u-boot/builds/124723016Quoted 9 lines
arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)Quoted 2 lines
Isn't there some common place in
scripts/or so where we can disable this warning using an one-liner ?I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ...
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
Wouldn't it be better to fix the problems?
My impression was that these warnings are just the result of over-eagerness of DTC, that's why Linux prints them only if you increase the W= (warning) verbosity. I might be wrong tho.
Quoted 5 lines
They are minor problems. For the vast majority of the dts files we have, the fixes will come in via re-syncs with the kernel and in at least some cases it's not just a simple regex but also "oh, lets give things better names". With respect to dts files that we really do own (ie x86) yes, we should fix them.
Quoted 6 lines
So, this patch from me could be still an option?
http://patchwork.ozlabs.org/patch/610866/
(at least for the sandbox fixes?)
(I have a v2 where I worked in the comments from Bin ...)
Yes, but I want to make sure we think about the renames and aren't trying to silence the warning. I'm sorry but the MIPS "fixes" have me leery of other blind changes.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/cd8f26c0/attachment.sig>