i386: properly define BR2_ARCH for all x86 subarchitectures
PATCH 1/1 i386: properly define BR2_ARCH for all x86 subarchitectures
We were not defining BR2_ARCH for two of the x86 subarchitecture, which means the architecture part of the GNU_TARGET_NAME tuple was empty, leading to weird build failures.
This commit fixes that by defining the appropriate values.
Fixes bug #8861.
--- arch/Config.in.x86 | 2 ++ 1 file changed, 2 insertions(+)
arch/Config.in.x86 +2 -0
@@ -226,6 +226,8 @@ config BR2_ARCH default "i686" if BR2_x86_nocona && BR2_i386 default "i686" if BR2_x86_core2 && BR2_i386 default "i686" if BR2_x86_corei7 && BR2_i386 + default "i686" if BR2_x86_corei7_avx && BR2_i386 + default "i686" if BR2_x86_corei7_avx2 && BR2_i386 default "i686" if BR2_x86_atom && BR2_i386 default "i686" if BR2_x86_opteron && BR2_i386 default "i686" if BR2_x86_opteron_sse3 && BR2_i386
Signature · 1 line
2.6.4
PATCH 1/1 i386: properly define BR2_ARCH for all x86 subarchitectures
Quoted 9 lines · Thomas Petazzoni
We were not defining
BR2_ARCHfor two of the x86 subarchitecture, which means the architecture part of theGNU_TARGET_NAMEtuple was empty, leading to weird build failures.This commit fixes that by defining the appropriate values.
Fixes bug #8861.
Signed-off-by Thomas Petazzoni <[email protected]>
It would be nice if we would have a way to check something like that...
Regards,
Arnout
Quoted 18 lines
--- arch/Config.in.x86 | 2 ++ 1 file changed, 2 insertions(+)arch/Config.in.x86 +2
-0@@ -226,6 +226,8 @@ config BR2_ARCH default "i686" if BR2_x86_nocona && BR2_i386 default "i686" if BR2_x86_core2 && BR2_i386 default "i686" if BR2_x86_corei7 && BR2_i386 + default "i686" if BR2_x86_corei7_avx && BR2_i386 + default "i686" if BR2_x86_corei7_avx2 && BR2_i386 default "i686" if BR2_x86_atom && BR2_i386 default "i686" if BR2_x86_opteron && BR2_i386 default "i686" if BR2_x86_opteron_sse3 && BR2_i386
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 i386: properly define BR2_ARCH for all x86 subarchitectures
Hello,
Quoted 1 line · Arnout Vandecappelle
Thanks!
Quoted 1 line
It would be nice if we would have a way to check something like that...
ifeq ($(call qstrip,$(BR2_ARCH)),)
$(error Blurp!)
endif
?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 i386: properly define BR2_ARCH for all x86 subarchitectures
Quoted 6 lines · Thomas Petazzoni
Hello,
Quoted 1 line · Arnout Vandecappelle
Quoted 7 lines
Thanks!
Quoted 1 line
It would be nice if we would have a way to check something like that...
ifeq ($(call qstrip,$(BR2_ARCH)),)
$(error Blurp!)
endif
I meant statically, somehow. This will only be hit by users who actually
select that arch option, not by autobuilders.
Regards,
Arnout
Quoted 5 lines
?
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile) Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF