DaVinci NAND: disable subpage write (28c015)
Hi,
this email refers to the commit: 28c015a9daabe4ed3aeb0ccf669a3f1c2b8b81d5 on drivers/mtd/nand/davinci-nand.c. This commit sets the NAND_NO_SUBPAGE_WRITE option for "ti,keystone-nand" to workaround a HW issue on the controller.
Disabling subpage write however should be made a general option because some NAND chips do not support subpage write at all. Subpage write is a feature of the NAND chip, not the NAND interface. In combination with "ti,davinci-nand" there is no option to disable subpage write. In my case I'm struggling with this issue on the AM1808 with a 1Gb Micron NAND (MT29F1GxxABB).
My proposal would be to add a boolean property "ti,davinci-disable-subpage-write" or similar, which sets the NAND_NO_SUBPAGE_WRITE option. I'm also wondering why no other binding is addressing this, as it is a general problem.
I wanted to collect your opinion before submitting a patch.
Thanks
Petr
Hi Petr,
Quoted 7 lines · On Fri, 22 Apr 2016 10:20:09 +0200 Petr Kulhavy <[email protected]> wrote:
Hi,
this email refers to the commit:
28c015a9daabe4ed3aeb0ccf669a3f1c2b8b81d5ondrivers/mtd/nand/davinci-nand.c. This commit sets theNAND_NO_SUBPAGE_WRITEoption for "ti,keystone-nand" to workaround a HW issue on the controller.
Quoted 6 lines
Disabling subpage write however should be made a general option because some NAND chips do not support subpage write at all. Subpage write is a feature of the NAND chip, not the NAND interface. In combination with "ti,davinci-nand" there is no option to disable subpage write. In my case I'm struggling with this issue on the AM1808 with a 1Gb Micron NAND (MT29F1GxxABB).
That's true that subpage write is initially a feature exposed by NAND chips (actually called subpage in datasheets), but the controller can say that it does not support writing subpages.
The problem is, in most drivers we don't have the concept of controllers, hence the reason we're asking NAND controllers to explicitly modify chip->options and set the NAND_NO_SUBPAGE_WRITE flag manually.
Note that, unless the CHIP supports subpage write, mtd->subpage_sft will be 0, which should prevent subpage writes [1].
Quoted 4 lines
My proposal would be to add a boolean property "ti,davinci-disable-subpage-write" or similar, which sets the
NAND_NO_SUBPAGE_WRITEoption.
Hm, that's not a good idea IMO. This limitation is controller specific. If some versions of your controller are supporting subpage writes, then they should not set this flag. So, setting NAND_NO_SUBPAGE_WRITE depending on the compatible string looks like the good approach here.
Regards,
Boris
[1]http://lxr.free-electrons.com/source/drivers/mtd/nand/nand_base.c#L4350
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Hi Boris,
Quoted 26 lines · Boris Brezillon
Hi Petr,
Quoted 7 lines · On Fri, 22 Apr 2016 10:20:09 +0200 Petr Kulhavy <[email protected]> wrote:
Hi,
this email refers to the commit:
28c015a9daabe4ed3aeb0ccf669a3f1c2b8b81d5ondrivers/mtd/nand/davinci-nand.c. This commit sets theNAND_NO_SUBPAGE_WRITEoption for "ti,keystone-nand" to workaround a HW issue on the controller.Quoted 6 lines
Disabling subpage write however should be made a general option because some NAND chips do not support subpage write at all. Subpage write is a feature of the NAND chip, not the NAND interface. In combination with "ti,davinci-nand" there is no option to disable subpage write. In my case I'm struggling with this issue on the AM1808 with a 1Gb Micron NAND (MT29F1GxxABB).
That's true that subpage write is initially a feature exposed by NAND chips (actually called subpage in datasheets), but the controller can say that it does not support writing subpages.
The problem is, in most drivers we don't have the concept of controllers, hence the reason we're asking NAND controllers to explicitly modifychip->optionsand set theNAND_NO_SUBPAGE_WRITEflag manually.
Quoted 2 lines
Note that, unless the CHIP supports subpage write,
mtd->subpage_sftwill be 0, which should prevent subpage writes [1].
Thank you for the explanation. Do you mean that the controller should detect if the chip supports subpage writing? Where is the piece of code doing the detection?
That is interesting, because in my case the detection does not work. Using compatible string "ti,davinci-nand" causes heavy ECC errors with UBI (which extensively uses subpage writes) and after setting the compatible string to "ti,keystone-nand" the errors are gone...
Regards
Petr
Quoted 29 lines · On Fri, 22 Apr 2016 13:49:53 +0200 Petr Kulhavy <[email protected]> wrote:
Hi Boris,
Quoted 26 lines · Boris Brezillon
Hi Petr,
Quoted 7 lines · On Fri, 22 Apr 2016 10:20:09 +0200 Petr Kulhavy <[email protected]> wrote:
Hi,
this email refers to the commit:
28c015a9daabe4ed3aeb0ccf669a3f1c2b8b81d5ondrivers/mtd/nand/davinci-nand.c. This commit sets theNAND_NO_SUBPAGE_WRITEoption for "ti,keystone-nand" to workaround a HW issue on the controller.Quoted 6 lines
Disabling subpage write however should be made a general option because some NAND chips do not support subpage write at all. Subpage write is a feature of the NAND chip, not the NAND interface. In combination with "ti,davinci-nand" there is no option to disable subpage write. In my case I'm struggling with this issue on the AM1808 with a 1Gb Micron NAND (MT29F1GxxABB).
That's true that subpage write is initially a feature exposed by NAND chips (actually called subpage in datasheets), but the controller can say that it does not support writing subpages.
The problem is, in most drivers we don't have the concept of controllers, hence the reason we're asking NAND controllers to explicitly modifychip->optionsand set theNAND_NO_SUBPAGE_WRITEflag manually.
Quoted 5 lines
Quoted 2 lines
Note that, unless the CHIP supports subpage write,
mtd->subpage_sftwill be 0, which should prevent subpage writes [1].Thank you for the explanation. Do you mean that the controller should detect if the chip supports subpage writing?
No, the controller should just care about what it supports, not what the chip supports.
Quoted 2 lines
Where is the piece of code
doing the detection?
Actually, according to the code I pointed out, all SLC NANDs support subpage write. For NANDs with really small pages (<= 512bytes), you'll always have pagesize == subpagesize, because step usually is 512 or 1024.
For SLC NANDs with larger pages (>= 2K), then your subpage size will depend on the number of ECC steps your have in a single page.
I realize that this approach is not entirely safe, because ecc->steps is deduced from ecc->size which can be overloaded by NAND controller drivers. Maybe this should be extracted from ->ecc_step_size_ds, or even better, be encoded into a separate field, but I'm not sure this is related to the problem you're facing.
Quoted 1 line
That is interesting, because in my case the detection does not work.
What do you get in chip->subpagesize.
According to the MT29F1GxxABB datasheet you can program a single page up to 8 times without needing an erase operation:
"
PROGRAM PAGE 80h-10h
Micron NAND Flash devices also support partial-page programming operations. This means that any single bit can only be programmed one time before an erase is required; however, the page can be partitioned so that a maximum of eight programming operations are supported before an erase is required.
"
Which means your NAND exposes subpages, and according to the code I pointed out, you should have 4 subpages inside a page, each of them containing 512 bytes.
Quoted 3 lines
Using compatible string "ti,davinci-nand" causes heavy ECC errors with UBI (which extensively uses subpage writes) and after setting the compatible string to "ti,keystone-nand" the errors are gone...
Then, maybe this is your controller (or the driver implementation) that does not support writing subpages...
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com