unicore32: mm: Add missing parameter to arch_vma_access_permitted
PATCH 1/1 unicore32: mm: Add missing parameter to arch_vma_access_permitted
unicore32 fails to compile with the following errors.
mm/memory.c: In function ‘__handle_mm_fault’:mm/memory.c:3381: error:
too many arguments to function ‘arch_vma_access_permitted’mm/gup.c: In function ‘check_vma_flags’:mm/gup.c:456: error:
too many arguments to function ‘arch_vma_access_permitted’mm/gup.c: In function ‘vma_permits_fault’:mm/gup.c:640: error:
too many arguments to function ‘arch_vma_access_permitted’
--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/unicore32/include/asm/mmu_context.h +1 -1
@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, }static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool foreign) +bool write,bool execute,bool foreign) {/* by default, allow everything */ return true;
Signature · 1 line
2.5.0
Quoted 12 lines
unicore32 fails to compile with the following errors.
mm/memory.c: In function 鈥榑_handle_mm_fault鈥�:mm/memory.c:3381: error:too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榗heck_vma_flags鈥�: mm/gup.c:456: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榲ma_permits_fault鈥�: mm/gup.c:640: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥�
Quoted 6 lines
Fixes d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instructionfetches")
Cc Dave Hansen <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Thanks.
Quoted 22 lines
--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/unicore32/include/asm/mmu_context.h +1
-1@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, }static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool foreign) +bool write,bool execute,bool foreign) {/* by default, allow everything */ return true;
--
2.5.0
Quoted 19 lines · Xuetao Guan
Quoted 12 lines
unicore32 fails to compile with the following errors.
mm/memory.c: In function 鈥榑_handle_mm_fault鈥�:mm/memory.c:3381: error:too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榗heck_vma_flags鈥�: mm/gup.c:456: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榲ma_permits_fault鈥�: mm/gup.c:640: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥�Quoted 6 lines
Fixes d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instructionfetches")
Cc Dave Hansen <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Quoted 4 lines
Thanks.
Acked-by Guan Xuetao <[email protected]>
Who is going to send the patch upstream ?
Guenter
Quoted 23 lines
Quoted 22 lines
--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/unicore32/include/asm/mmu_context.h +1
-1@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, }static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool foreign) +bool write,bool execute,bool foreign) {/* by default, allow everything */ return true;
--
2.5.0
Quoted 24 lines · Xuetao Guan
Quoted 23 lines
Quoted 5 lines
unicore32 fails to compile with the following errors.
mm/memory.c: In function 閳ユ_handle_mm_fault閳��:mm/memory.c:3381: error:
too many arguments to function閳ユrch_vma_access_permitted閳��
Quoted 3 lines
mm/gup.c: In function 閳ユheck_vma_flags閳��:mm/gup.c:456: error:
too many arguments to function閳ユrch_vma_access_permitted閳��
Quoted 3 lines
mm/gup.c: In function 閳ユΣma_permits_fault閳��:mm/gup.c:640: error:
too many arguments to function閳ユrch_vma_access_permitted閳��
Quoted 2 lines
Fixes d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiateinstruction
Quoted 5 lines
fetches")
Cc Dave Hansen <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Quoted 7 lines
Quoted 4 lines
Thanks.
Acked-by Guan Xuetao <[email protected]>Who is going to send the patch upstream ?
Guenter
I will do. Thanks.
Xuetao
Quoted 27 lines
Quoted 26 lines
arch/unicore32/include/asm/mmu_context.h static inline void arch_bprm_mm_init(struct
Quoted 11 lines
--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/unicore32/include/asm/mmu_context.h +0
-0@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
mm_structarch/unicore32/include/asm/mmu_context.h static inline void arch_bprm_mm_init(struct · line 101
Quoted 4 lines
arch/unicore32/include/asm/mmu_context.h +0
-0*mm, } static inline bool arch_vma_access_permitted(struct vm_area_struct*vma,
Quoted 8 lines
arch/unicore32/include/asm/mmu_context.h +1
-1- bool write, bool foreign) + bool write, bool execute, bool foreign) {/* by default, allow everything */ return true;
--
2.5.0
ping ... still not upstream.
Quoted 35 lines · Guenter Roeck
unicore32 fails to compile with the following errors.
mm/memory.c: In function ‘__handle_mm_fault’:mm/memory.c:3381: error:
too many arguments to function ‘arch_vma_access_permitted’mm/gup.c: In function ‘check_vma_flags’:mm/gup.c:456: error:
too many arguments to function ‘arch_vma_access_permitted’mm/gup.c: In function ‘vma_permits_fault’:mm/gup.c:640: error:
too many arguments to function ‘arch_vma_access_permitted’Fixes d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")Cc Dave Hansen <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/unicore32/include/asm/mmu_context.h +1
-1@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, }static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool foreign) +bool write,bool execute,bool foreign) {/* by default, allow everything */ return true;
Quoted 1 line
ping ... still not upstream.
I'm sorry.
I'll do it in next week.
Xuetao
Quoted 42 lines · Guenter Roeck
Quoted 39 lines
unicore32 fails to compile with the following errors.
mm/memory.c: In function 鈥榑_handle_mm_fault鈥�:mm/memory.c:3381: error:too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榗heck_vma_flags鈥�: mm/gup.c:456: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥� mm/gup.c: In function 鈥榲ma_permits_fault鈥�: mm/gup.c:640: error: too many arguments to function 鈥榓rch_vma_access_permitted鈥�Fixes d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instructionfetches")
Cc Dave Hansen <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Ingo Molnar <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--- arch/unicore32/include/asm/mmu_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/unicore32/include/asm/mmu_context.h +1
-1@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, }static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool foreign) +bool write,bool execute,bool foreign) {/* by default, allow everything */ return true;