Skip to contentSkip to conversation

ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

PATCH New Sekhar Nori 2 participants 6 messages Apr 7, 2016 – Apr 25, 2016 Arm (32-bit)

lore
Share & tools
lore

Sekhar Nori

author
#0 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions.

So lets enable it for DaVinci platforms as well.

Signed-off-by Sekhar Nori <[email protected]>
---
 arch/arm/configs/davinci_all_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/davinci_all_defconfig +1 -0
index 235842c9ba96..d1b3799c08cc 100644
@@ -2,6 +2,7 @@ CONFIG_EXPERIMENTAL=y
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
+CONFIG_FHANDLE=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
 CONFIG_LOG_BUF_SHIFT=14
Signature · 1 line
2.6.3
#1 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Quoted 2 lines · Sekhar Nori

CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions.

There's a bunch more options required for basic systemd support also[1], so those should probably be added with the changelog referencing the source[1]

Kevin

[1] https://github.com/systemd/systemd/blob/master/README#L37

author
#2 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Quoted 8 lines · Kevin Hilman
Quoted 2 lines · Sekhar Nori

CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions.

There's a bunch more options required for basic systemd support also[1], so those should probably be added with the changelog referencing the source[1]

Good point. Will send a v2.

Regards,
Sekhar

author
#3 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Quoted 11 lines · Sekhar Nori
Quoted 8 lines · Kevin Hilman
Quoted 2 lines · Sekhar Nori

CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions.

There's a bunch more options required for basic systemd support also[1], so those should probably be added with the changelog referencing the source[1]

Good point. Will send a v2.

I looked at this bit more closely. CONFIG_EPOLL, CONFIG_SIGNALFD, and CONFIG_TIMERFD are all default y and so actually get removed when the next 'make savedefconfig' syncup will be done. Same thing for PROC_FS and SYSFS.

Looking at the list of required options, FHANDLE is the only one which needs to get enabled explicitly. Also, CONFIG_INOTIFY is actually a stale entry that can be removed.

Based on this, I think the updated patch can be:

---8<---
From: Sekhar Nori <[email protected]>
Date: Fri, 15 Apr 2016 14:19:26 +0530
Subject: [PATCH] ARM: davinci_all_defconfig: support systemd

CONFIG_FHANDLE is required by systemd[1], which is the default init system in more and more distributions. So lets enable it for DaVinci platforms as well.

While at it, remove stale entry CONFIG_INOTIFY=y

[1] https://github.com/systemd/systemd/blob/master/README#L37

Signed-off-by Sekhar Nori <[email protected]>
---
 arch/arm/configs/davinci_all_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/configs/davinci_all_defconfig
index c5bccd9d010e..776fd8ad792f 100644

arch/arm/configs/davinci_all_defconfig +1 -1
@@ -2,6 +2,7 @@ CONFIG_EXPERIMENTAL=y
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
+CONFIG_FHANDLE=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
 CONFIG_LOG_BUF_SHIFT=14

@@ -188,7 +189,6 @@ CONFIG_TI_EDMA=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 CONFIG_XFS_FS=m
-CONFIG_INOTIFY=y
 CONFIG_AUTOFS4_FS=m
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y
Signature · 1 line
2.6.3
#4 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Quoted 33 lines · Sekhar Nori
Quoted 11 lines · Sekhar Nori
Quoted 8 lines · Kevin Hilman
Quoted 2 lines · Sekhar Nori

CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions.

There's a bunch more options required for basic systemd support also[1], so those should probably be added with the changelog referencing the source[1]

Good point. Will send a v2.

I looked at this bit more closely. CONFIG_EPOLL, CONFIG_SIGNALFD, and CONFIG_TIMERFD are all default y and so actually get removed when the next 'make savedefconfig' syncup will be done. Same thing for PROC_FS and SYSFS.

Looking at the list of required options, FHANDLE is the only one which needs to get enabled explicitly. Also, CONFIG_INOTIFY is actually a stale entry that can be removed.

Based on this, I think the updated patch can be:

---8<---
From: Sekhar Nori <[email protected]>
Date: Fri, 15 Apr 2016 14:19:26 +0530
Subject: [PATCH] ARM: davinci_all_defconfig: support systemd

CONFIG_FHANDLE is required by systemd[1], which is the default init system in more and more distributions. So lets enable it for DaVinci platforms as well.

Quoted 5 lines

While at it, remove stale entry CONFIG_INOTIFY=y

[1] https://github.com/systemd/systemd/blob/master/README#L37

Signed-off-by Sekhar Nori <[email protected]>
Acked-by Kevin Hilman <[email protected]>
author Applied
#5 lore raw

PATCH 1/1 ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Quoted 10 lines · Kevin Hilman
Quoted 8 lines · Sekhar Nori

From: Sekhar Nori <[email protected]>
Date: Fri, 15 Apr 2016 14:19:26 +0530
Subject: [PATCH] ARM: davinci_all_defconfig: support systemd

CONFIG_FHANDLE is required by systemd[1], which is the default init system in more and more distributions. So lets enable it for DaVinci platforms as well.

Quoted 7 lines
Quoted 5 lines

While at it, remove stale entry CONFIG_INOTIFY=y

[1] https://github.com/systemd/systemd/blob/master/README#L37

Signed-off-by Sekhar Nori <[email protected]>
Acked-by Kevin Hilman <[email protected]>

Applied.

Thanks,
Sekhar