Skip to contentSkip to conversation

4.1.18 introduced spurious copy of renamed iwlwifi trans.c

DISCUSSION Jens Rottmann 1 participant 1 message Apr 25, 2016 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi,

some time after 4.1
drivers/net/wireless/iwlwifi/pcie/trans.c
got moved to
drivers/net/wireless/intel/iwlwifi/pcie/trans.c

Later upstream commit 62d7476d958ce06d7a10b02bdb30006870286fe2 "iwlwifi: pcie: properly configure the debug buffer size for 8000" fixed something in the new intel/iwlwifi/pcie/trans.c

The patch was backported and included in 4.1.18 as commit d9d42b679e3653759b107ff99daf8da9c21aaec7. It does nicely apply to the old file iwlwifi/pcie/trans.c, _however_ by mistake the patch also introduces a useless copy of the complete file at it's modern home intel/iwlwifi/pcie/trans.c

The 'fix' would be to delete the surplus file again. I don't know if you want this, the 2nd copy of trans.c is never compiled, so strictly speaking it does no harm - except that it confused me enough to write this mail. :-)

Regards,
Jens