ARM: dts: imx28-m28: Fix unit-address for partitions
Subsystems (2)
PATCH 1/1 ARM: dts: imx28-m28: Fix unit-address for partitions
According to ePAPR v1.1: "The unit-address must match the first address specified in the reg property of the node"
So do as recommended.
Signed-off-by Fabio Estevam <[email protected]>
--- arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx28-m28.dtsi +4 -4
@@ -34,22 +34,22 @@ read-only; }; - partition at 1 { + partition at 300000 { label = "environment"; reg = <0x00300000 0x00080000>; }; - partition at 2 { + partition at 380000 { label = "redundant-environment"; reg = <0x00380000 0x00080000>; }; - partition at 3 { + partition at 400000 { label = "kernel"; reg = <0x00400000 0x00400000>; }; - partition at 4 { + partition at 800000 { label = "filesystem"; reg = <0x00800000 0x0f800000>; };
Signature · 1 line
1.9.1
PATCH 1/1 ARM: dts: imx28-m28: Fix unit-address for partitions
Quoted 4 lines · Fabio Estevam
According to ePAPR v1.1: "The unit-address must match the first address specified in the reg property of the node"
So do as recommended.
Looks good, but if I may, I would suggest something more drastic. Would you instead remove the whole partitioning from the M28 DT? We always pass mtdparts from command line, so having some sort of default partitioning is quite pointless.
Thanks for spotting this though, it's a good reminder to review older boards.
Quoted 37 lines
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx28-m28.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/imx28-m28.dtsi +4
-4@@ -34,22 +34,22 @@ read-only; }; - partition at 1 { + partition at 300000 { label = "environment"; reg = <0x00300000 0x00080000>; }; - partition at 2 { + partition at 380000 { label = "redundant-environment"; reg = <0x00380000 0x00080000>; }; - partition at 3 { + partition at 400000 { label = "kernel"; reg = <0x00400000 0x00400000>; }; - partition at 4 { + partition at 800000 { label = "filesystem"; reg = <0x00800000 0x0f800000>; };
Signature · 2 lines
Best regards, Marek Vasut