Skip to contentSkip to conversation

f2fs: fix to clear private data in page

PATCH In review Chao Yu 2 participants 3 messages Apr 28, 2016 – Apr 29, 2016 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/4 f2fs: fix to clear private data in page

From: Chao Yu <[email protected]>

Private data in page should be removed during ->releasepage or ->invalidatepage, otherwise garbage data would be remained in that page.

Signed-off-by Chao Yu <[email protected]>
---
 fs/f2fs/data.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/data.c +0 -0
index 38ce5d6..888f178 100644
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int

offset,
if (IS_ATOMIC_WRITTEN_PAGE(page))
return;

+ set_page_private(page, 0);
ClearPagePrivate(page);
}

@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
if (IS_ATOMIC_WRITTEN_PAGE(page))
return 0;

+ set_page_private(page, 0);
ClearPagePrivate(page);
return 1;
}

Signature · 1 line
2.7.2
maintainer
#1 lore raw

Hi Chao,

Could you check your email setting?
All the patches are corrupted, as git am says.

Thanks,

Quoted 33 lines · Chao Yu

From: Chao Yu <[email protected]>

Private data in page should be removed during ->releasepage or ->invalidatepage, otherwise garbage data would be remained in that page.

Signed-off-by Chao Yu <[email protected]>
---
 fs/f2fs/data.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/data.c +2 -0
index 38ce5d6..888f178 100644
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
 offset,
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return;
 
+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 }

@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return 0;
 
+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 	return 1;
 }
Signature · 1 line
2.7.2
author maintainer
#2 lore raw

Hi Jaegeuk,

Quoted 4 lines · Jaegeuk Kim

Hi Chao,

Could you check your email setting?
All the patches are corrupted, as git am says.

My bad, I use thunderbird for sending patches, but yesterday I upgrade it to version 45.0, it forces wrapping long line for email content, so the patches become corrupted to git-am.

Later, I will resend them.

Thanks,

Quoted 37 lines

Thanks,

Quoted 33 lines · Chao Yu

From: Chao Yu <[email protected]>

Private data in page should be removed during ->releasepage or ->invalidatepage, otherwise garbage data would be remained in that page.

Signed-off-by Chao Yu <[email protected]>
---
 fs/f2fs/data.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/data.c +2 -0
index 38ce5d6..888f178 100644
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
 offset,
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return;
 
+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 }

@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
 	if (IS_ATOMIC_WRITTEN_PAGE(page))
 		return 0;
 
+	set_page_private(page, 0);
 	ClearPagePrivate(page);
 	return 1;
 }
Signature · 1 line
2.7.2