UFS patchset
Hi Martin,
Could you please give me feedback about the UFS patch-set?
The patches have been acked by various developers, so maybe could it be possible to put it into the 4.7 queue?
Patch-set Cover Letter:
http://www.spinics.net/lists/linux-scsi/msg95664.html
Thank you,
Joao
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Joao" == Joao Pinto <[email protected]> writes:
Joao,
Joao> Could you please give me feedback about the UFS patch-set? The Joao> patches have been acked by various developers, so maybe could it Joao> be possible to put it into the 4.7 queue?
It is on my list.
I think we are OK from a SCSI perspective but I believe there were still a couple of concerns in the ARM/device tree department. So I would like some confirmation from those developers that the code is now acceptable.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 9 lines · Martin K. Petersen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Joao" == Joao Pinto <[email protected]> writes:
Joao,
Joao> Could you please give me feedback about the UFS patch-set? The Joao> patches have been acked by various developers, so maybe could it Joao> be possible to put it into the 4.7 queue?
It is on my list.
Ok, great!
Quoted 5 lines
I think we are OK from a SCSI perspective but I believe there were still a couple of concerns in the ARM/device tree department. So I would like some confirmation from those developers that the code is now acceptable.
The concerns were from Rob Herring about mixing PHY and controller in the compatibility string, but that was justified. Check the extract:
">>
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Combining the phy and controller compatible strings is a bit strange. Generally, they would be separate nodes using the common phy binding.
Correct, but in this case is just the compatibility string is just to tell the dw ufs host that it has a 40-bit or a 20-bit test chip connected. The Test chip is initialized by a unipro command sequence and
there is no more ops related to it.
Quoted 3 lines
Okay. In that case, I think it should be a separate property unless the controller h/w is synthesized for one or the other.
Yes, the hardware must be synthesized for a certain PHY type, 20 or 40-bit.
Quoted 3 lines
Rob
Joao"
Thanks,
Joao
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Joao" == Joao Pinto <[email protected]> writes:
Joao,
Quoted 1 line
Quoted 1 line
It is on my list.
Joao> Ok, great!
In a previous email you said you had sent v14 to linux-scsi. However, I don't see neither v14, nor v13 in patchworks. The latest I have is v12 and it does not apply to 4.7/scsi-queue.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Martin" == Martin K Petersen <[email protected]> writes:
Joao,
Martin> In a previous email you said you had sent v14 to Martin> linux-scsi. However, I don't see neither v14, nor v13 in Martin> patchworks. The latest I have is v12 and it does not apply to Martin> 4.7/scsi-queue.
I found v14 in my mailbox. Not sure why it's not in patchworks.
In any case: It still doesn't apply to 4.7/scsi-queue and there are several checkpatch warnings throughout the series. Please fix.
Also make sure to prefix your patch subject lines with "ufs:" so it's easy to identify which subsystem they go into.
Thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Hi Martin!
Quoted 9 lines · Martin K. Petersen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Martin" == Martin K Petersen <[email protected]> writes:
Joao,
Martin> In a previous email you said you had sent v14 to Martin> linux-scsi. However, I don't see neither v14, nor v13 in Martin> patchworks. The latest I have is v12 and it does not apply to Martin> 4.7/scsi-queue.
Quoted 4 lines
I found v14 in my mailbox. Not sure why it's not in patchworks.
In any case: It still doesn't apply to 4.7/scsi-queue and there are several checkpatch warnings throughout the series. Please fix.
The patch were made based on a 4.7-queue from about 1 or 2 months. I will do the needed fixes and send you the v15.
Quoted 6 lines
Also make sure to prefix your patch subject lines with "ufs:" so it's easy to identify which subsystem they go into.
Thanks!
Thanks.
Hi Martin,
Quoted 11 lines · Martin K. Petersen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Martin" == Martin K Petersen <[email protected]> writes:
Joao,
Martin> In a previous email you said you had sent v14 to Martin> linux-scsi. However, I don't see neither v14, nor v13 in Martin> patchworks. The latest I have is v12 and it does not apply to Martin> 4.7/scsi-queue.
I found v14 in my mailbox. Not sure why it's not in patchworks.
Quoted 8 lines
In any case: It still doesn't apply to 4.7/scsi-queue and there are several checkpatch warnings throughout the series. Please fix.
Also make sure to prefix your patch subject lines with "ufs:" so it's easy to identify which subsystem they go into.
Thanks!
As promissed I sent you a new patch set based on the latest 4.7 queue branch, with "ufs:" prefix and completely tested and validated by checkpatch.
Thanks.
Joao