Skip to contentSkip to conversation

gst1-plugins-bad: remove mpg123 plugin option

PATCH New Gustavo Zacarias 3 participants 7 messages May 3, 2016 – May 5, 2016

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/3 gst1-plugins-bad: remove mpg123 plugin option

The plugin was moved from -bad to -ugly so remove the option. Support in -ugly was added via 30cde9a3.
Add legacy entry to notify users of this, however we can't automatically select the ugly variant since ugly might be disabled.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 Config.in.legacy                                        | 7 +++++++
 package/gstreamer1/gst1-plugins-bad/Config.in           | 7 -------
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 7 -------
 3 files changed, 7 insertions(+), 14 deletions(-)
Config.in.legacy +7 -0
index 9f694f8..9901cf6 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2016.05"
 
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123
+	bool "gst1-plugins-bad mpg123 plugin moved to ugly"
+	select BR2_LEGACY
+	help
+	  The mpg123 plugin has been moved from gst1-plugins-bad to
+	  gst1-plugins-ugly.
+
 config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC
 	bool "PowerPC Sourcery toolchain has been removed"
 	select BR2_LEGACY
package/gstreamer1/gst1-plugins-bad/Config.in +0 -7
index a9667af..16bb36d 100644
@@ -553,13 +553,6 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEG2ENC
 	help
 	  High-quality MPEG-1/2 video encoder
 
-config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123
-	bool "mpg123"
-	select BR2_PACKAGE_MPG123
-	depends on BR2_USE_MMU # mpg123
-	help
-	  mp3 decoding based on the mpg123 library
-
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MUSEPACK
 	bool "musepack"
 	select BR2_PACKAGE_MUSEPACK
package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +0 -7
index a92c4a6..80bdee8 100644
@@ -692,13 +692,6 @@ else
 GST1_PLUGINS_BAD_CONF_OPTS += --disable-mpeg2enc
 endif
 
-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123),y)
-GST1_PLUGINS_BAD_CONF_OPTS += --enable-mpg123
-GST1_PLUGINS_BAD_DEPENDENCIES += mpg123
-else
-GST1_PLUGINS_BAD_CONF_OPTS += --disable-mpg123
-endif
-
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MUSEPACK),y)
 GST1_PLUGINS_BAD_CONF_OPTS += --enable-musepack
 GST1_PLUGINS_BAD_DEPENDENCIES += musepack
Signature · 1 line
2.7.3
author
#1 lore raw

PATCH 2/3 gst1-plugins-bad: remove rtp plugin option

The plugin was moved from -bad to -good so remove the option. Support in -good was added via 301e8ffb.
Add legacy entry to notify users of this, however we can't automatically select the good variant since good might be disabled.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 Config.in.legacy                                        | 7 +++++++
 package/gstreamer1/gst1-plugins-bad/Config.in           | 3 ---
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 6 ------
 3 files changed, 7 insertions(+), 9 deletions(-)
Config.in.legacy +7 -0
index 9901cf6..5317dde 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2016.05"
 
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
+	bool "gst1-plugins-bad rtp plugin moved to good"
+	select BR2_LEGACY
+	help
+	  The rtp plugin has been moved from gst1-plugins-base to
+	  gst1-plugins-good.
+
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPG123
 	bool "gst1-plugins-bad mpg123 plugin moved to ugly"
 	select BR2_LEGACY
package/gstreamer1/gst1-plugins-bad/Config.in +0 -3
index 16bb36d..53ce589 100644
@@ -382,9 +382,6 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
 	help
 	  Removes silence from an audio stream
 
-config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
-	bool "rtp"
-
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
 	bool "sdi"
package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +0 -6
index 80bdee8..6d8cac7 100644
@@ -479,12 +479,6 @@ else
 GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
 endif
 
-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP),y)
-GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtp
-else
-GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtp
-endif
-
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)
 GST1_PLUGINS_BAD_CONF_OPTS += --enable-sdi
 else
Signature · 1 line
2.7.3
#2 lore raw

PATCH 2/3 gst1-plugins-bad: remove rtp plugin option

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

The plugin was moved from -bad to -good so remove the option. Support in -good was added via 301e8ffb.
Add legacy entry to notify users of this, however we can't automatically select the good variant since good might be disabled.

Signed-off-by Gustavo Zacarias <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#3 lore raw

PATCH 3/3 gst1-plugins-bad: add rtmp support

In reply to Gustavo Zacarias

As pointed by sonnex on the mailing list.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/gstreamer1/gst1-plugins-bad/Config.in           | 6 ++++++
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 7 +++++++
 2 files changed, 13 insertions(+)
package/gstreamer1/gst1-plugins-bad/Config.in +6 -0
index 53ce589..5248c4d 100644
@@ -382,6 +382,12 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
 	help
 	  Removes silence from an audio stream
 
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
+	bool "rtmp"
+	select BR2_PACKAGE_RTMPDUMP
+	help
+	  RTMP plugni
+
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
 	bool "sdi"
package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +7 -0
index 6d8cac7..e2446a3 100644
@@ -479,6 +479,13 @@ else
 GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
 endif
 
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP),y)
+GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtmp
+GST1_PLUGINS_BAD_DEPENDENCIES += rtmpdump
+else
+GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtmp
+endif
+
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)
 GST1_PLUGINS_BAD_CONF_OPTS += --enable-sdi
 else
Signature · 1 line
2.7.3
#4 lore raw

PATCH 3/3 gst1-plugins-bad: add rtmp support

Am 03.05.2016 um 21:44 schrieb Gustavo Zacarias:

Quoted 13 lines

As pointed by sonnex on the mailing list.

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/gstreamer1/gst1-plugins-bad/Config.in           | 6 ++++++
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 7 +++++++
 2 files changed, 13 insertions(+)
package/gstreamer1/gst1-plugins-bad/Config.in +0 -0
index 53ce589..5248c4d 100644

package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE · line 389

Quoted 8 lines
package/gstreamer1/gst1-plugins-bad/Config.in +5 -0
@@ -382,6 +382,12 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
 	help
 	  Removes silence from an audio stream
 
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
+	bool "rtmp"
+	select BR2_PACKAGE_RTMPDUMP
+	help
+	  RTMP plugni

just caught that typo while looking at the patch...

author
#5 lore raw

PATCH 3/3 gst1-plugins-bad: add rtmp support

Quoted 7 lines · Andr? Hentschel

package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE · line 389

Quoted 5 lines
package/gstreamer1/gst1-plugins-bad/Config.in +5 -0
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
+	bool "rtmp"
+	select BR2_PACKAGE_RTMPDUMP
+	help
+	  RTMP plugni

just caught that typo while looking at the patch...

Hi.
Thanks, too quick a patch, i'll send v2.
Regards.

#6 lore raw

PATCH 1/3 gst1-plugins-bad: remove mpg123 plugin option

In reply to Gustavo Zacarias
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

The plugin was moved from -bad to -ugly so remove the option. Support in -ugly was added via 30cde9a3.
Add legacy entry to notify users of this, however we can't automatically select the ugly variant since ugly might be disabled.

Signed-off-by Gustavo Zacarias <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard