ath79: fix some minor defects
cover ath79: fix some minor defects
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute for ath79_soc_desc
arch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)
Signature · 1 line
1.9.1
cover ath79: fix some minor defects
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 11 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_desc
Quoted 6 lines
arch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)
all four patches applied to u-boot-mips/next, thanks!
Signature · 9 lines
- Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160415/f27174e1/attachment.sig>
cover ath79: fix some minor defects
Quoted 14 lines · Daniel Schwierzeck
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 11 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_desc
Quoted 9 lines
Quoted 6 lines
arch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)all four patches applied to u-boot-mips/next, thanks!
Can you please update next on top of u-boot/master , so I can submit the ar9344 ? Thanks!
Signature · 2 lines
Best regards, Marek Vasut
cover ath79: fix some minor defects
Am 03.05.2016 um 23:28 schrieb Marek Vasut:
Quoted 22 lines · Daniel Schwierzeck
Quoted 21 lines
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 17 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_descarch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)
Quoted 4 lines
Quoted 2 lines
all four patches applied to u-boot-mips/next, thanks!
Can you please update next on top of u-boot/master , so I can submit the ar9344 ? Thanks!
ok, done
Signature · 9 lines
- Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160504/c87e4f3a/attachment.sig>
cover ath79: fix some minor defects
Quoted 25 lines · Daniel Schwierzeck
Am 03.05.2016 um 23:28 schrieb Marek Vasut:
Quoted 22 lines · Daniel Schwierzeck
Quoted 21 lines
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 17 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_descarch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
all four patches applied to u-boot-mips/next, thanks!
Can you please update next on top of u-boot/master , so I can submit the ar9344 ? Thanks!
ok, done
Thank you!
Signature · 2 lines
Best regards, Marek Vasut
cover ath79: fix some minor defects
In reply to Daniel SchwierzeckHi Wills,
I'm getting a warning with gcc-5.3:
CC arch/mips/mach-ath79/ar933x/ddr.oarch/mips/mach-ath79/ar933x/ddr.c: In function ?ddr_tap_tuning?:arch/mips/mach-ath79/ar933x/ddr.c:329:15: warning: ?upper? may be used uninitialized in this function [-Wmaybe-uninitialized]
val = (upper + lower) / 2;
^Could you please look at it? I don't know which default values make sense for 'upper' and 'lower'.
Am 15.04.2016 um 13:19 schrieb Daniel Schwierzeck:
Quoted 23 lines
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 11 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_descQuoted 6 lines
arch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)all four patches applied to u-boot-mips/next, thanks!
Signature · 9 lines
- Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160506/95f2c203/attachment.sig>
cover ath79: fix some minor defects
Quoted 11 lines · Daniel Schwierzeck
Hi Wills,
I'm getting a warning with gcc-5.3:
CC arch/mips/mach-ath79/ar933x/ddr.o arch/mips/mach-ath79/ar933x/ddr.c: In function ?ddr_tap_tuning?: arch/mips/mach-ath79/ar933x/ddr.c:329:15: warning: ?upper? may be used uninitialized in this function [-Wmaybe-uninitialized] val = (upper + lower) / 2; ^
Quoted 2 lines
Could you please look at it? I don't know which default values make sense for 'upper' and 'lower'.
Ok, compiler might need explicit initializer.
I will add a patch for this later.
Quoted 22 lines
Am 15.04.2016 um 13:19 schrieb Daniel Schwierzeck:
Quoted 20 lines
Am 12.04.2016 um 05:09 schrieb Wills Wang:
Quoted 10 lines
These series of patch based on top of mips/next, it fix some defects on the previous patch series "add support for atheros ath79 based SOCs".
Wills Wang (4):
ath79: spi: Remove the explicit pinctrl setting
ar933x: serial: Remove the explicit pinctrl setting
ath79: ar933x: use BIT macro for bit shift operation
ath79: add readonly attribute forath79_soc_descQuoted 6 lines
arch/mips/mach-ath79/ar933x/ddr.c | 14 +++++++------- arch/mips/mach-ath79/cpu.c | 8 ++++---- drivers/serial/serial_ar933x.c | 16 ++-------------- drivers/spi/ath79_spi.c | 12 ------------ 4 files changed, 13 insertions(+), 37 deletions(-)all four patches applied to u-boot-mips/next, thanks!
Signature · 2 lines
Best Regards Wills