Skip to contentSkip to conversation

mips: Fix compiler warning in cpu.c

PATCH New Marek Vasut 2 participants 2 messages May 5, 2016 – May 6, 2016 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mips: Fix compiler warning in cpu.c

There really is zero reason for including netdev.h in generic mips CPU code. Removing the netdev.h from cpu.c also fixes the following compiler warning:

In file included from arch/mips/cpu/cpu.c:10:0:
include/netdev.h:204:41: warning: 'struct eth_device' declared inside parameter list [enabled by default]

 int fecmxc_register_mii_postcall(struct eth_device *dev, int (*cb)(int));
                                         ^

include/netdev.h:204:41: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Cc Paul Burton <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
---
 arch/mips/cpu/cpu.c | 1 -
 1 file changed, 1 deletion(-)
arch/mips/cpu/cpu.c +0 -1
index 8d3b2f5..391feb3 100644
@@ -7,7 +7,6 @@
 
 #include <common.h>
 #include <command.h>
-#include <netdev.h>
 #include <linux/compiler.h>
 #include <asm/mipsregs.h>
 #include <asm/reboot.h>
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 mips: Fix compiler warning in cpu.c

Am 05.05.2016 um 20:14 schrieb Marek Vasut:

Quoted 7 lines

There really is zero reason for including netdev.h in generic mips CPU code. Removing the netdev.h from cpu.c also fixes the following compiler warning:

In file included from arch/mips/cpu/cpu.c:10:0:
include/netdev.h:204:41: warning: 'struct eth_device' declared inside parameter list [enabled by default]

 int fecmxc_register_mii_postcall(struct eth_device *dev, int (*cb)(int));
                                         ^
Quoted 8 lines

include/netdev.h:204:41: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Cc Paul Burton <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
---
 arch/mips/cpu/cpu.c | 1 -
 1 file changed, 1 deletion(-)

applied to u-boot-mips/next, thanks

Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160506/adfa07a4/attachment.sig>