Skip to contentSkip to conversation

ARM: at91: sama5: Update defconfig

PATCH New Marek Vasut 2 participants 7 messages May 5, 2016 – May 10, 2016 Arm (32-bit)

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 ARM: at91: sama5: Update defconfig

Enable CGROUPS support, so we can boot userspace that uses systemd on top of kernel configured using this defconfig. The systemd userspace depends on cgroups and without them, it dies in mysterious ways.

Signed-off-by Marek Vasut <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Alexandre Belloni <[email protected]>
---
 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index afbda41..1b60be2 100644
@@ -3,6 +3,7 @@
 CONFIG_SYSVIPC=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_EMBEDDED=y
 CONFIG_SLAB=y
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 ARM: at91: sama5: Update defconfig

Le 05/05/2016 22:31, Marek Vasut a ?crit :

Quoted 7 lines

Enable CGROUPS support, so we can boot userspace that uses systemd on top of kernel configured using this defconfig. The systemd userspace depends on cgroups and without them, it dies in mysterious ways.

Signed-off-by Marek Vasut <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Alexandre Belloni <[email protected]>

Hi Marek,

Acked-by Nicolas Ferre <[email protected]>

BTW, isn't it something else required to run a systemd enabled image? I've seen that some of the option may be missing as well:

CONFIG_FHANDLE (libudev, mount and bind mount handling)
from: https://github.com/systemd/systemd/blob/master/README#L51

In the " Optional but strongly recommended:" I see interest in:
CONFIG_AUTOFS4_FS
CONFIG_TMPFS_XATTR CONFIG_{TMPFS,EXT4,XFS,BTRFS_FS,...}_POSIX_ACL

But it's maybe not so interesting for our little embedded systems.

I'm also puzzled about the need for more options about cgroups...

I add a couple of other people in Cc so we can figure out the proper configuration set...

Thanks Marek for having started the discussion, bye,

Quoted 17 lines
---
 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index afbda41..1b60be2 100644
@@ -3,6 +3,7 @@
 CONFIG_SYSVIPC=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_EMBEDDED=y
 CONFIG_SLAB=y
Signature · 1 line
Nicolas Ferre
author
#2 lore raw

PATCH 1/1 ARM: at91: sama5: Update defconfig

Quoted 10 lines · Nicolas Ferre

Le 05/05/2016 22:31, Marek Vasut a ?crit :

Quoted 7 lines

Enable CGROUPS support, so we can boot userspace that uses systemd on top of kernel configured using this defconfig. The systemd userspace depends on cgroups and without them, it dies in mysterious ways.

Signed-off-by Marek Vasut <[email protected]>
Cc Ludovic Desroches <[email protected]>
Cc Alexandre Belloni <[email protected]>

Hi Marek,

Hi!

Quoted 7 lines
Acked-by Nicolas Ferre <[email protected]>

BTW, isn't it something else required to run a systemd enabled image? I've seen that some of the option may be missing as well:

CONFIG_FHANDLE (libudev, mount and bind mount handling)
from: https://github.com/systemd/systemd/blob/master/README#L51

This one is absolutely mandatory, but this is also enabled by default already. Debian testing with systemd won't boot without FHANDLE too, so this is easy to trap for me.

Quoted 6 lines

In the " Optional but strongly recommended:" I see interest in:
CONFIG_AUTOFS4_FS
CONFIG_TMPFS_XATTR CONFIG_{TMPFS,EXT4,XFS,BTRFS_FS,...}_POSIX_ACL

But it's maybe not so interesting for our little embedded systems.

Hm, these are disabled, but I cannot comment on their significance.

Quoted 1 line

I'm also puzzled about the need for more options about cgroups...

Enabling CONFIG_CGROUPS is enough to make systemd happy and booting. I didn't probe further, sorry.

Quoted 2 lines

I add a couple of other people in Cc so we can figure out the proper configuration set...

Thanks!

Quoted 21 lines

Thanks Marek for having started the discussion, bye,

Quoted 17 lines
---
 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index afbda41..1b60be2 100644
@@ -3,6 +3,7 @@
 CONFIG_SYSVIPC=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_EMBEDDED=y
 CONFIG_SLAB=y
Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH 1/1 ARM: at91/defconfig: sama5: add CONFIG_FHANDLE

CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So explicitly enable it to allow easy use of systemd userspace.

Reported-by Marek Vasut <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Hi Marek,

It seems that on my side, CONFIG_FHANDLE is not selected automatically... So I add this patch: can you tell me your thoughts?

Bye,
Nico.

 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index 307f92b31e57..9cb1a85bb166 100644
@@ -1,6 +1,7 @@
 # CONFIG_LOCALVERSION_AUTO is not set
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
+CONFIG_FHANDLE=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y
Signature · 1 line
2.1.3
author
#4 lore raw

Re: [PATCH] ARM: at91/defconfig: sama5: add CONFIG_FHANDLE

Quoted 7 lines · Nicolas Ferre

CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So explicitly enable it to allow easy use of systemd userspace.

Reported-by Marek Vasut <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Hi Marek,

Hi!

Quoted 2 lines

It seems that on my side, CONFIG_FHANDLE is not selected automatically... So I add this patch: can you tell me your thoughts?

Uh, weird, I tried this on next just now:

linux-2.6$ git describe HEAD
next-20160510

linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-

linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
#

# configuration written to .config
#
CONFIG_FHANDLE=y
Quoted 19 lines

Bye,
Nico.

 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index 307f92b31e57..9cb1a85bb166 100644
@@ -1,6 +1,7 @@
 # CONFIG_LOCALVERSION_AUTO is not set
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
+CONFIG_FHANDLE=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y
Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw

Re: [PATCH] ARM: at91/defconfig: sama5: add CONFIG_FHANDLE

Quoted 30 lines · Marek Vasut
Quoted 7 lines · Nicolas Ferre

CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So explicitly enable it to allow easy use of systemd userspace.

Reported-by Marek Vasut <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Hi Marek,

Hi!

Quoted 2 lines

It seems that on my side, CONFIG_FHANDLE is not selected automatically... So I add this patch: can you tell me your thoughts?

Uh, weird, I tried this on next just now:

linux-2.6$ git describe HEAD
next-20160510

linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-

linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
#

Quoted 3 lines
# configuration written to .config
#
CONFIG_FHANDLE=y

Absolutely. The patch f76be61755c5 ("Make CONFIG_FHANDLE default y") has been added in v4.6-rc2... while I was doing my tests on at91-next that is based on v4.6-rc1 :-\

Anyway. It's in now. Thanks,

Bye,
Nicolas

Quoted 18 lines
Quoted 16 lines
 arch/arm/configs/sama5_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/sama5_defconfig +1 -0
index 307f92b31e57..9cb1a85bb166 100644
@@ -1,6 +1,7 @@
 # CONFIG_LOCALVERSION_AUTO is not set
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
+CONFIG_FHANDLE=y
 CONFIG_IRQ_DOMAIN_DEBUG=y
 CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y
Signature · 1 line
Nicolas Ferre
author
#6 lore raw

Re: [PATCH] ARM: at91/defconfig: sama5: add CONFIG_FHANDLE

Quoted 35 lines · Nicolas Ferre

Le 10/05/2016 14:31, Marek Vasut a ?crit :

Quoted 30 lines · Nicolas Ferre
Quoted 7 lines

CONFIG_FHANDLE is listed as a mandatory kernel option for systemd. So explicitly enable it to allow easy use of systemd userspace.

Reported-by Marek Vasut <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Hi Marek,

Hi!

Quoted 2 lines

It seems that on my side, CONFIG_FHANDLE is not selected automatically... So I add this patch: can you tell me your thoughts?

Uh, weird, I tried this on next just now:

linux-2.6$ git describe HEAD
next-20160510

linux-2.6$ export ARCH=arm ; export CROSS_COMPILE=arm-linux-gnueabi-

linux-2.6$ make sama5_defconfig ; grep FHANDLE .config
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
#

Quoted 3 lines
# configuration written to .config
#
CONFIG_FHANDLE=y
Quoted 5 lines

Absolutely. The patch f76be61755c5 ("Make CONFIG_FHANDLE default y") has been added in v4.6-rc2... while I was doing my tests on at91-next that is based on v4.6-rc1 :-\

Anyway. It's in now. Thanks,

Cool, thanks :)

Signature · 2 lines
Best regards,
Marek Vasut