Skip to contentSkip to conversation

ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC

PATCH New Boris Brezillon 2 participants 3 messages May 11, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC

The memory range assigned to the PMC (Power Management Controller) was not including the PMC_PCR register which are used to control peripheral clocks.

This was working fine thanks to the page granularity of ioremap(), but started to fail when we switched to syscon/regmap, because regmap is making sure that all accesses are falling into the reserved range.

Fixes 863a81c3be1d ("clk: at91: make use of syscon to share PMC registers in several drivers")

---
Hi Arnd,

This patch is fixing a regression reported by Richard. Since this regression was introduced in 4.6-rc1 it would be great if you could take it before 4.6 is released.

Thanks,

Boris

---
 arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91sam9x5.dtsi +1 -1
index 0827d59..cd0cd5f 100644
@@ -106,7 +106,7 @@
 
 			pmc: pmc at fffffc00 {
 				compatible = "atmel,at91sam9x5-pmc", "syscon";
-				reg = <0xfffffc00 0x100>;
+				reg = <0xfffffc00 0x200>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				interrupt-controller;
 				#address-cells = <1>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC

Le 11/05/2016 11:00, Boris Brezillon a �crit :

Quoted 8 lines

The memory range assigned to the PMC (Power Management Controller) was not including the PMC_PCR register which are used to control peripheral clocks.

This was working fine thanks to the page granularity of ioremap(), but started to fail when we switched to syscon/regmap, because regmap is making sure that all accesses are falling into the reserved range.

Quoted 5 lines
Fixes 863a81c3be1d ("clk: at91: make use of syscon to share PMC registers in several drivers")

Thanks Boris!

Quoted 6 lines

---
Hi Arnd,

This patch is fixing a regression reported by Richard. Since this regression was introduced in 4.6-rc1 it would be great if you could take it before 4.6 is released.

Arnd, arm-soc guys,

I can build a Pull-Request instantly today, if you wish: just tell me if you prefer.

Bye,

Quoted 18 lines
---
 arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91sam9x5.dtsi +1 -1
index 0827d59..cd0cd5f 100644
@@ -106,7 +106,7 @@
 
 			pmc: pmc@fffffc00 {
 				compatible = "atmel,at91sam9x5-pmc", "syscon";
-				reg = <0xfffffc00 0x100>;
+				reg = <0xfffffc00 0x200>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				interrupt-controller;
 				#address-cells = <1>;
Signature · 1 line
Nicolas Ferre
#2 lore raw

PATCH 1/1 ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC

Le 11/05/2016 12:11, Nicolas Ferre a �crit :

Quoted 23 lines

Le 11/05/2016 11:00, Boris Brezillon a �crit :

Quoted 8 lines

The memory range assigned to the PMC (Power Management Controller) was not including the PMC_PCR register which are used to control peripheral clocks.

This was working fine thanks to the page granularity of ioremap(), but started to fail when we switched to syscon/regmap, because regmap is making sure that all accesses are falling into the reserved range.

Quoted 5 lines
Fixes 863a81c3be1d ("clk: at91: make use of syscon to share PMC registers in several drivers")

Thanks Boris!

Quoted 3 lines

---
Hi Arnd,

Quoted 8 lines
Quoted 3 lines

This patch is fixing a regression reported by Richard. Since this regression was introduced in 4.6-rc1 it would be great if you could take it before 4.6 is released.

Arnd, arm-soc guys,

I can build a Pull-Request instantly today, if you wish: just tell me if you prefer.

Actually, I've just sent one so that we don't loose time:

"[GIT PULL] at91: fixes for 4.6 #2"

Bye,

Quoted 20 lines
Quoted 18 lines
---
 arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91sam9x5.dtsi +1 -1
index 0827d59..cd0cd5f 100644
@@ -106,7 +106,7 @@
 
 			pmc: pmc@fffffc00 {
 				compatible = "atmel,at91sam9x5-pmc", "syscon";
-				reg = <0xfffffc00 0x100>;
+				reg = <0xfffffc00 0x200>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				interrupt-controller;
 				#address-cells = <1>;
Signature · 1 line
Nicolas Ferre