Skip to contentSkip to conversation

4.1.24-stable: iwlwifi patch applied to wrong file

DISCUSSION Jens Rottmann 2 participants 2 messages May 11, 2016 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi again,

in 4.1.24-stable commit fdfdfc7cdf (iwlwifi: pcie: lower the debug level for RSA semaphore access) was applied to the wrong file. It patched drivers/net/wireless/intel/iwlwifi/pcie/trans.c whereas it should have patched drivers/net/wireless/iwlwifi/pcie/trans.c instead.

drivers/net/wireless/intel/iwlwifi/pcie/trans.c is a useless artifact created by a faulty patch, which went into 4.1.18 (d9d42b679e36 iwlwifi:
pcie: properly configure the debug buffer size for 8000) I already reported this a while ago ("4.1.18 introduced spurious copy of renamed iwlwifi trans.c").

For 4.1.25 please delete drivers/net/wireless/intel/iwlwifi/pcie/trans.c and reapply the "lower the debug level" patch to the correct file.

Thanks,
Jens

#1 lore raw
Quoted 7 lines · Jens Rottmann

Hi again,

in 4.1.24-stable commit fdfdfc7cdf (iwlwifi: pcie: lower the debug level for RSA semaphore access) was applied to the wrong file. It patched drivers/net/wireless/intel/iwlwifi/pcie/trans.c whereas it should have patched drivers/net/wireless/iwlwifi/pcie/trans.c instead.

Quoted 8 lines

drivers/net/wireless/intel/iwlwifi/pcie/trans.c is a useless artifact created by a faulty patch, which went into 4.1.18 (d9d42b679e36 iwlwifi:
pcie: properly configure the debug buffer size for 8000) I already reported this a while ago ("4.1.18 introduced spurious copy of renamed iwlwifi trans.c").

For 4.1.25 please delete drivers/net/wireless/intel/iwlwifi/pcie/trans.c and reapply the "lower the debug level" patch to the correct file.

Oh I thought that I removed that file after the previous mail about it :/

Fixed in queue now, and I'll make sure it's right before shipping .25

Thanks,
Sasha