Skip to contentSkip to conversation

Patch: V4L stable versions 4.5.3 and 4.5.4

PATCH David R 3 participants 4 messages May 11, 2016 Media (V4L/DVB)

lore
Share & tools
lore

David R

author
#0 lore raw

Hi

Please consider applying the attached patch (or something like it) to V4L2, and whatever is appropriate to the mainstream kernel. Without this my media server crashes and burns at boot.

See https://lkml.org/lkml/2016/5/7/88 for more details

Thanks
David

media/v4l2-core/videobuf2-core.c renamed from media/v4l2-core/videobuf2-core.c.old +1 -1
@@ -1665,7 +1665,7 @@ static int __vb2_get_done_vb(struct vb2_
 	 * Only remove the buffer from done_list if v4l2_buffer can handle all
 	 * the planes.
 	 */
-	ret = call_bufop(q, verify_planes_array, *vb, pb);
+	ret = pb ? call_bufop(q, verify_planes_array, *vb, pb) : 0;
 	if (!ret)
 		list_del(&(*vb)->done_entry);
 	spin_unlock_irqrestore(&q->done_lock, flags);
author
#1 lore raw
Quoted 11 lines · David R

Hi

Please consider applying the attached patch (or something like it) to V4L2, and whatever is appropriate to the mainstream kernel. Without this my media server crashes and burns at boot.

See https://lkml.org/lkml/2016/5/7/88 for more details

Thanks
David

I see the offending patch was reverted earlier today. My box is fine with my (more simple) alternative, but your call.

David

#2 lore raw

Hi David,

Em Wed, 11 May 2016 20:05:22 +0100
David R <[email protected]> escreveu:

Quoted 7 lines · David R
Quoted 6 lines

Hi

Please consider applying the attached patch (or something like it) to V4L2, and whatever is appropriate to the mainstream kernel. Without this my media server crashes and burns at boot.

Quoted 7 lines
Quoted 5 lines

See https://lkml.org/lkml/2016/5/7/88 for more details

Thanks
David

I see the offending patch was reverted earlier today. My box is fine with my (more simple) alternative, but your call.

Yes, I noticed the bug earlier today, while testing a DVB device. As this affects 2 stable releases plus the upcoming Kernel 4.6, I decided to just revert it for now, while we don't solve the issue.

Your patch looks good. So, eventually it will be merged on a new version of this patch, after we test it properly.

Thanks!
Mauro

#3 lore raw

Hi Mauro and David,

Quoted 20 lines · Mauro Carvalho Chehab

Hi David,

Em Wed, 11 May 2016 20:05:22 +0100
David R <[email protected]> escreveu:

Quoted 7 lines · David R
Quoted 6 lines

Hi

Please consider applying the attached patch (or something like it) to V4L2, and whatever is appropriate to the mainstream kernel. Without this my media server crashes and burns at boot.

Quoted 7 lines
Quoted 5 lines

See https://lkml.org/lkml/2016/5/7/88 for more details

Thanks
David

I see the offending patch was reverted earlier today. My box is fine with my (more simple) alternative, but your call.

Quoted 7 lines

Yes, I noticed the bug earlier today, while testing a DVB device. As this affects 2 stable releases plus the upcoming Kernel 4.6, I decided to just revert it for now, while we don't solve the issue.

Your patch looks good. So, eventually it will be merged on a new version of this patch, after we test it properly.

Indeed vb2_core_dqbuf() is called with pb == NULL in file I/O, which was unfortunately missed until now.

The proposed fix looks good to me.

Signature · 4 lines
Kind regards,

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]