serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
PATCH 1/1 serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
Enabling support for the UART on the ARM MPS2 platform only make sense when compiling for the ARM MPS2 platform, unless compile-testing.
--- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
@@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE config SERIAL_MPS2_UART bool "MPS2 UART port" - depends on ARM || COMPILE_TEST + depends on ARCH_MPS2 || COMPILE_TEST select SERIAL_CORE help This driver support the UART ports on ARM MPS2.
Signature · 1 line
1.9.1
PATCH 1/1 serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
Quoted 2 lines · Geert Uytterhoeven
Enabling support for the UART on the ARM MPS2 platform only make sense when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see SERIAL_STM32 for example) I'm wondering what makes MPS2 so special flake?
I was under impression that architecture/board specific guard must have only if we have something like
#include <asm/xyz.h>
or
#include <mach/xyz.h>
which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to get it known.
Cheers
Vladimir
Quoted 20 lines
Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/Kconfig +1
-1@@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE config SERIAL_MPS2_UART bool "MPS2 UART port" - depends on ARM || COMPILE_TEST + depends on ARCH_MPS2 || COMPILE_TEST select SERIAL_CORE help This driver support the UART ports on ARM MPS2.
PATCH 1/1 serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
Hi Vladimir,
Quoted 6 lines · Vladimir Murzin
Quoted 2 lines · Geert Uytterhoeven
Enabling support for the UART on the ARM MPS2 platform only make sense when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see
SERIAL_STM32for example) I'm wondering what makes MPS2 so special flake?
Nothing. SERIAL_STM32 should be fixed, too.
I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
Quoted 5 lines
I was under impression that architecture/board specific guard must have only if we have something like
#include <
asm/xyz.h>
Quoted 8 lines
or
#include <
mach/xyz.h>which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to get it known.
That's why there's an "|| COMPILE_TEST" in the dependency.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
Quoted 21 lines · Geert Uytterhoeven
Hi Vladimir,
Quoted 6 lines · Vladimir Murzin
Quoted 2 lines · Geert Uytterhoeven
Enabling support for the UART on the ARM MPS2 platform only make sense when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see
SERIAL_STM32for example) I'm wondering what makes MPS2 so special flake?Nothing.
SERIAL_STM32should be fixed, too.
I only fixedSERIAL_MPS2_UART, as it was a newly-introduced symbol.Quoted 7 lines
I was under impression that architecture/board specific guard must have only if we have something like
#include <
asm/xyz.h>or
Quoted 9 lines
Quoted 6 lines
#include <
mach/xyz.h>which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to get it known.
That's why there's an "||
COMPILE_TEST" in the dependency.
First of all sorry for the late response...
Secondly, I have no strong opinion on the patch, so I'd leave the final word to Greg
FWIW
Cheers
Vladimir
Quoted 12 lines
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds