Skip to contentSkip to conversation

mips: ath79: ar933x: Avoid warning with gcc5

PATCH New Wills Wang 3 participants 4 messages May 22, 2016 – May 25, 2016 MIPS

lore
Share & tools
lore

Wills Wang

author
#0 lore raw

PATCH v2 1/7 mips: ath79: ar933x: Avoid warning with gcc5

GCC 5.3 report a warning: 'upper' and 'lower' may be used uninitialized in this function [-Wmaybe-uninitialized]. Compiler might need explicit initializer.

Signed-off-by Wills Wang <[email protected]>

---

 arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/mach-ath79/ar933x/ddr.c +2 -0
index 91452bc..7f20d34 100644
@@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
 	dir = 1;
 	tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
 	val = tap;
+	upper = tap;
+	lower = tap;
 	while (!done) {
 		err = 0;
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/7 mips: ath79: ar933x: Avoid warning with gcc5

Quoted 16 lines · Wills Wang

GCC 5.3 report a warning: 'upper' and 'lower' may be used uninitialized in this function [-Wmaybe-uninitialized]. Compiler might need explicit initializer.

Signed-off-by Wills Wang <[email protected]>

---

 arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/mach-ath79/ar933x/ddr.c +0 -0
index 91452bc..7f20d34 100644

arch/mips/mach-ath79/ar933x/ddr.c void ddr_tap_tuning(void) · line 275

Quoted 8 lines
arch/mips/mach-ath79/ar933x/ddr.c +2 -0
@@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
 	dir = 1;
 	tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
 	val = tap;
+	upper = tap;
+	lower = tap;
 	while (!done) {
 		err = 0;

So what's new in V2 here ?

Signature · 2 lines
Best regards,
Marek Vasut
author
#2 lore raw

PATCH v2 1/7 mips: ath79: ar933x: Avoid warning with gcc5

Quoted 11 lines · Marek Vasut
Quoted 10 lines · Wills Wang

GCC 5.3 report a warning: 'upper' and 'lower' may be used uninitialized in this function [-Wmaybe-uninitialized]. Compiler might need explicit initializer.

Signed-off-by Wills Wang <[email protected]>

---

  arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
  1 file changed, 2 insertions(+)
Quoted 16 lines
Quoted 6 lines
arch/mips/mach-ath79/ar933x/ddr.c +0 -0
index 91452bc..7f20d34 100644

arch/mips/mach-ath79/ar933x/ddr.c void ddr_tap_tuning(void) · line 275

Quoted 8 lines
arch/mips/mach-ath79/ar933x/ddr.c +2 -0
@@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
  	dir = 1;
  	tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
  	val = tap;
+	upper = tap;
+	lower = tap;
  	while (!done) {
  		err = 0;

So what's new in V2 here ?

Capitalize the first letter in the sentence.

Signature · 2 lines
Best Regards
Wills
#3 lore raw

PATCH v2 1/7 mips: ath79: ar933x: Avoid warning with gcc5

In reply to Wills Wang

Am 22.05.2016 um 05:59 schrieb Wills Wang:

Quoted 10 lines

GCC 5.3 report a warning: 'upper' and 'lower' may be used uninitialized in this function [-Wmaybe-uninitialized]. Compiler might need explicit initializer.

Signed-off-by Wills Wang <[email protected]>

---

 arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
 1 file changed, 2 insertions(+)

applied to u-boot-mips, thanks.

Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160526/07a28e47/attachment.sig>