Fix compiler warnings about set-but-not-used variables

index d2cb8c5..74ac507 100755
@@ -42,7 +42,7 @@ CMDIF_DIR   = $(top_srcdir)/cmdif
 AM_CPPFLAGS = -I$(top_srcdir) -I$(srcdir) -I$(MTCR_DIR) -I$(MFLASH_DIR) -I$(COMMON_DIR) \
            -I$(LAYOUTS_DIR) -I$(MFT_UTILS_DIR) -I$(MTCR_INC_DIR)
 
-mstflint_CXXFLAGS = -Wall -W -g -MP -MD -pipe -DEXTERNAL
+mstflint_CXXFLAGS = -Wall -Wextra -Wno-unused-parameter -g -MP -MD -pipe -DEXTERNAL
 bin_PROGRAMS = mstflint
 
 mstflint_SOURCES = flint.cpp flint.h subcommands.cpp subcommands.h\

index 0bcc4ee..6d9e470 100644
@@ -930,10 +930,6 @@ bool SubCommand::unzipDataFile (std::vector<u_int8_t> data, std::vector<u_int8_t
     newData.resize(destLen + 1);
     return true;
 #else
-    // avoid warnings
-    (void) data;
-    (void) newData;
-    (void) sectionName;
     reportErr(true, FLINT_NO_ZLIB_ERROR);
     return false;
 #endif

@@ -966,7 +962,6 @@ bool SubCommand::dumpFile(const char* confFile, std::vector<u_int8_t>& data, con
 
 bool SubCommand::checkGuidsFlags (u_int16_t devType, u_int8_t fwType,
                             bool guidsSpecified, bool macsSpecified, bool uidSpecified, bool ibDev, bool ethDev) {
-    (void)ibDev;
     if (guidsSpecified || macsSpecified || uidSpecified) {
         if (uidSpecified && fwType != FIT_FS3) {
             reportErr(true, "-uid flag is applicable only for FS3 FW Only.\n");

@@ -4282,8 +4277,6 @@ FlintStatus TimeStampSubCommand::executeCommand()
     if (preFwOps() == FLINT_FAILED) {
         return FLINT_FAILED;
     }
-    _ops = _flintParams.device_specified ? _fwOps : _imgOps;
-    (void)_ops;
     switch (_operation) {
     case TimeStampSubCommand::TS_Set:
         rc = setTs();

index c45351a..12da860 100644
@@ -34,7 +34,7 @@
 AM_CPPFLAGS= -I. -I$(top_srcdir)/include/mtcr_ul -I$(top_srcdir)/common -I$(top_srcdir)/tools_layouts -I$(top_srcdir)/reg_access \
           -I$(top_srcdir)/cmdif -I$(top_srcdir)/tools_res_mgmt
 
-AM_CFLAGS = -MD -pipe -Wall -W -DMST_UL -g ${MFLASH_INBAND_FLAG}
+AM_CFLAGS = -MD -pipe -Wall -Wextra -Wno-unused-parameter -DMST_UL -g ${MFLASH_INBAND_FLAG}
 
 noinst_LIBRARIES = libmflash.a
 

index c9189aa..11865a4 100755
@@ -45,7 +45,7 @@ CMDIF_DIR = $(USER_DIR)/cmdif
 AM_CPPFLAGS = -I. -I$(USER_DIR) -I$(top_srcdir)/include/mtcr_ul -I$(MTCR_DIR) -I$(COMMON_DIR) $(WIN64_INC)\
            -I $(LAYOUTS_DIR) -I $(UTILS_DIR) -I$(DEV_MGT_DIR) -I$(CMDIF_DIR)
 
-AM_CXXFLAGS = -Wall -W -g -MP -MD -pipe
+AM_CXXFLAGS = -Wall -Wextra -Wno-unused-parameter -g -MP -MD -pipe
 bin_PROGRAMS = mstconfig
 
 mstconfig_LDADD = $(CMDIF_DIR)/libcmdif.a ../reg_access/libreg_access.a $(LAYOUTS_LIB) $(MTCR_DIR)/libmtcr_ul.a $(MLNXOS_PPC_LIBS) $(LIBSTD_CPP) $(UTILS_LIB) $(DEV_MGT_DIR)/libdev_mgt.a -ldl

index b247ea0..ae82423 100644
@@ -433,7 +433,6 @@ bool CfgParams::checkCfg(mfile* mf)
 bool CfgParams::softLimitCheck(mfile* mf)
 {
     // by default not implemented
-    (void)mf;
     return true;
 }
 

@@ -495,7 +494,6 @@ u_int32_t BootSettingsExtParams4thGen::getParam(mlxCfgParam paramType)
 
 bool BootSettingsExtParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)param;
     struct tools_open_query_def_params_global params;
     int rc;
     rc = getDefaultParams4thGen(mf, &params);

@@ -621,7 +619,6 @@ u_int32_t BootSettingsExtParams5thGen::getBootSettingsExtCapabilitiesTlvTypeBe()
 bool BootSettingsExtParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     u_int8_t tlvCapBuff[TOOLS_OPEN_OPTION_ROM_CAPABILITY_SIZE] = {0};
     struct tools_open_option_rom_capability optionRomCapabilitesTlv;
     bool suppRead, suppWrite;

@@ -754,8 +751,6 @@ bool SriovParams4thGen::hardLimitCheck()
 
 bool SriovParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)mf;
-    (void)param;
     return _devCapVec & SRIOV_MASK;
 }
 

@@ -941,8 +936,6 @@ u_int32_t WolParams4thGen::getDefaultParam(mlxCfgParam paramType)
 
 bool WolParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)mf;
-    (void)param;
     return ((_devCapVec & WOL_P1_MASK) && _port == 1) || ((_devCapVec & WOL_P2_MASK) && _port == 2 );
 }
 

@@ -1048,7 +1041,6 @@ u_int32_t WolParams5thGen::getDefaultParam(mlxCfgParam paramType)
 bool WolParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -1157,8 +1149,6 @@ void BarSzParams::setParams(u_int32_t logBarSz)
 
 bool BarSzParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)mf;
-    (void)param;
     return _devCapVec & BAR_SZ_MASK ;
 }
 

@@ -1390,8 +1380,6 @@ u_int32_t VpiParams4thGen::getDefaultParam(mlxCfgParam paramType)
 
 bool VpiParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)mf;
-    (void)param;
     return ((_devCapVec & VPI_P1_MASK) && _port == 1) || ((_devCapVec & VPI_P2_MASK) && _port == 2);
 }
 

@@ -1489,7 +1477,6 @@ bool VpiParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
     // get mtcr functions for this device (physical)
     // compare with port
     // send nvqc and check
-    (void)param;
     MError rc;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);

@@ -2013,7 +2000,6 @@ u_int32_t PciParams5thGen::calcTotalBar()
 
 bool PciParams5thGen::softLimitCheck(mfile* mf)
 {
-    (void)mf;
     if (_maxTotalBarValid == 1 && _maxTotalBar != 0 && _sriovEn == 1) {
         if(_userSpecifiedSRIOV || _userSpecifiedPfLogBarSize || _userSpecifiedVfLogBarSize){
             if(_fppEn == 1){

@@ -2078,7 +2064,6 @@ bool PciParams5thGen::softLimitCheck(mfile* mf)
 bool TptParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTptCapabilitiesTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -2271,7 +2256,6 @@ bool TptParams5thGen::hardLimitCheck()
 
 bool InfinibandBootSettingsParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)param;
     struct tools_open_query_def_params_per_port portParams;
     int rc;
     rc = getDefaultParams4thGen(mf, _port, &portParams);

@@ -2393,7 +2377,6 @@ bool InfinibandBootSettingsParams4thGen::hardLimitCheck()
 bool IBDCParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getDcCapabilitiesTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -2562,7 +2545,6 @@ void IBDCParams5thGen::updateClassDefaultAttrFromTlv(void* tlv)
 bool RoCENextProtocolParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -2673,7 +2655,6 @@ void RoCENextProtocolParams5thGen::updateClassDefaultAttrFromTlv(void* tlv)
 bool RoCECCParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -2802,7 +2783,6 @@ void RoCECCParams5thGen::updateClassDefaultAttrFromTlv(void* tlv)
 bool RoCECCEcnParams5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

@@ -3389,7 +3369,6 @@ void RoCECCEcnParams5thGen::updateClassDefaultAttrFromTlv(void* tlv)
 
 bool PrebootBootSettingsParams4thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
-    (void)param;
     struct tools_open_query_def_params_per_port portParams;
     int rc;
     rc = getDefaultParams4thGen(mf, _port, &portParams);

@@ -3581,7 +3560,6 @@ bool PrebootBootSettingsParams4thGen::hardLimitCheck()
 bool ExternalPort5thGen::cfgSupported(mfile* mf, mlxCfgParam param)
 {
     MError rc;
-    (void)param;
     bool suppRead, suppWrite;
     rc = nvqcCom5thGen(mf, getTlvTypeBe(), suppRead, suppWrite);
     if (rc) {

index 1e86d53..451cf84 100644
@@ -326,7 +326,7 @@ mlxCfgStatus MlxCfg::queryDevCfg(const char* dev,const char* pci, int devIndex,
     bool failedToGetCfg = false;
     bool nothingSupported = true;
     bool isParamsDiffer = false;
-    (void) pci;
+
     // print opening
     printf("\nDevice #%d:\n", devIndex);
     printf("----------\n\n");

index c309507..8df3185 100755
@@ -45,7 +45,7 @@ AM_CPPFLAGS = -I$(srcdir) -I$(MTCR_INC_DIR) -I$(MFLASH_DIR) -I$(top_srcdir)/ext_
 
 MLXFWOPS_VERSION = 1
 
-AM_CXXFLAGS = -Wall -W -g -MP -MD -pipe -DNO_MFA_SUPPORT
+AM_CXXFLAGS = -Wall -Wextra -Wno-unused-parameter -g -MP -MD -pipe -DNO_MFA_SUPPORT
 
 if ENABLE_OPENSSL
 else

index a580c78..7ed0978 100644
@@ -433,7 +433,6 @@ Tlv_Status_t ImageTimeStamp::setTimeStamp(struct tools_open_ts_entry& timestamp,
 
 Tlv_Status_t ImageTimeStamp::queryTimeStamp(struct tools_open_ts_entry& timestamp, struct tools_open_fw_version& fwVer, bool queryRunning)
 {
-    (void)queryRunning;
     aux_tlv tsTlv;
     struct tools_open_timestamp tsData;
     memset(&tsTlv, 0, sizeof(tsTlv));

index 3ed215e..329b4ed 100755
@@ -67,7 +67,6 @@ bool FImage::open(const char *fname, bool read_only, bool advErr)
     int                r_cnt;
     FILE              *fh;
 
-    (void)read_only;  // FImage can be opened only for read so we ignore compiler warnings
     _advErrors = advErr;
 
     fh = fopen(fname, "rb");

@@ -274,9 +273,9 @@ bool Flash::open(const char *device, bool force_lock, bool read_only, int num_of
 {
     // Open device
     int rc;
+
     _advErrors = advErr;
     _ignore_cache_replacement = ignore_cashe_replacement ? true : false;
-    (void)read_only; // not used , avoid compiler warnings TODO: remove this var from function def
     rc = mf_open_adv(&_mfl, device, num_of_banks, flash_params, ignore_cashe_replacement, cx3_fw_access);
     //printf("device: %s , forceLock: %s , read only: %s, num of banks: %d, flash params is null: %s, ocr: %d, rc: %d\n",
     //		device, force_lock? "true":"false", read_only?"true":"false", num_of_banks, flash_params? "no":"yes", ignore_cashe_replacement, rc);

@@ -419,22 +418,16 @@ bool Flash::write_phy(u_int32_t phy_addr, u_int32_t data)
 
 bool Flash::write_phy(u_int32_t phy_addr, void* data, int cnt, bool noerase)
 {
-    // Avoid warning
-    (void)noerase;
     NATIVE_PHY_ADDR_FUNC(write, (phy_addr, data, cnt));
 }
 
 bool Flash::read_modify_write_phy(u_int32_t phy_addr, void* data, int cnt, bool noerase)
 {
-    // Avoid warning
-    (void)noerase;
     NATIVE_PHY_ADDR_FUNC(write_with_erase, (phy_addr, data, cnt));
 }
 
 bool Flash::read_modify_write(u_int32_t phy_addr, void* data, int cnt, bool noerase)
 {
-    // Avoid warning
-    (void)noerase;
     return write_with_erase(phy_addr, data, cnt);
 }
 

index 785fa00..14ad15f 100644
@@ -575,9 +575,6 @@ bool Fs2Operations::Fs2Verify(VerifyCallBack verifyCallBackFunc, bool is_striped
 }
 bool Fs2Operations::FwVerify(VerifyCallBack verifyCallBackFunc, bool isStripedImage, bool showItoc)
 {
-    // avoid compiler warrning (showItoc is not used in fs2)
-    (void)showItoc;
-
     initSectToRead(FULL_VERIFY);
     if (!Fs2Verify(verifyCallBackFunc, isStripedImage)) {
         // empty the initSectToRead

@@ -900,10 +897,6 @@ bool Fs2Operations::Fs2FailSafeBurn(Fs2Operations &imageOps,
                                   bool      allow_nofs,
                                   const char* pre_message,
                                   ProgressCallBack progressFunc) {
-    //we do not use pre_message, avoid warrning
-	//TODO: remove pre_message from function definition
-    (void)pre_message;
-
     Flash  *f = (Flash*)(this->_ioAccess);
     FImage *fim = (FImage*)(imageOps._ioAccess);
 

@@ -1503,17 +1496,11 @@ bool Fs2Operations::FwReadRom(std::vector<u_int8_t>& romSect)
 
 bool Fs2Operations::FwSetMFG(fs3_uid_t baseGuid, PrintCallBack callBackFunc)
 {
-    // avoid compiler warrnings
-    (void)baseGuid;
-    (void)callBackFunc;
     return errmsg("This command is not supported for FS2 FW image.");
 }
 
 bool Fs2Operations::FwSetMFG(guid_t baseGuid, PrintCallBack callBackFunc)
 {
-    // avoid compiler warrnings
-    (void)baseGuid;
-    (void)callBackFunc;
     return errmsg("This command is not supported for FS2 FW image.");
 }
 

@@ -1539,7 +1526,6 @@ bool Fs2Operations::FwGetSection (u_int32_t sectType, std::vector<u_int8_t>& sec
 
 bool Fs2Operations::ModifyVSDSection(const char *vsd, ProgressCallBack callBackFunc)
 {
-	(void)callBackFunc; /* avoid compiler warning*/
     u_int32_t length = _fwImgInfo.lastImageAddr;
     vector<u_int8_t> data(length);
 

@@ -1737,10 +1723,8 @@ bool Fs2Operations::Fs2SetGuidsForBlank(sg_params_t& sgParam)
 
 bool Fs2Operations::Fs2SetGuids(sg_params_t& sgParam, PrintCallBack callBackFunc, ProgressCallBack progressFunc)
 {
-    // avoid compiler warrnings
-    (void)callBackFunc;
-    //
     bool ib_dev, eth_dev;
+
     // Get the FW types
     SetDevFlags(_fwImgInfo.ext_info.chip_type, _fwImgInfo.ext_info.dev_type, FIT_FS2, ib_dev, eth_dev);
     guid_t* old_guids = _fwImgInfo.imageOk ? _fs2ImgInfo.ext_info.guids : (guid_t*)NULL;

@@ -1766,10 +1750,6 @@ bool Fs2Operations::Fs2SetGuids(sg_params_t& sgParam, PrintCallBack callBackFunc
 bool Fs2Operations::FwSetGuids(sg_params_t& sgParam, PrintCallBack callBackFunc,
         ProgressCallBack progressFunc)
 {
-	/* avoid annoying mingw warnings*/
-	(void)callBackFunc;
-	(void)progressFunc;
-
     if (!Fs2IntQuery(true, sgParam.stripedImage)) {
         return false;
     }

@@ -1928,9 +1908,6 @@ bool Fs2Operations::FwDeleteRom(bool ignoreProdIdCheck, ProgressCallBack progres
 
 bool Fs2Operations::FwSetVSD(char* vsdStr, ProgressCallBack progressFunc, PrintCallBack printFunc)
 {
-    // avoid compiler warrnings
-    (void)printFunc;
-    //
     if (!Fs2IntQuery()) {
         return false;
     }

@@ -1955,16 +1932,11 @@ bool Fs2Operations::FwSetVSD(char* vsdStr, ProgressCallBack progressFunc, PrintC
 
 bool Fs2Operations::FwSetVPD(char* vpdFileStr, PrintCallBack callBackFunc)
 {
-    // avoid compiler warrnings
-    (void)vpdFileStr;
-    (void)callBackFunc;
     return errmsg("Setting VPD is not supported in FS2 image format.");
 }
 
 bool Fs2Operations::FwSetAccessKey(hw_key_t userKey, ProgressCallBack progressFunc)
 {
-	/*avoid compiler warning*/
-	(void)progressFunc;
     if (!Fs2IntQuery()) {
         return false;
     }

@@ -2045,8 +2017,6 @@ bool Fs2Operations::FwResetNvData()
 
 bool Fs2Operations::FwShiftDevData(PrintCallBack progressFunc)
 {
-    // avoid compiler warrnings
-    (void)progressFunc;
     return errmsg("Shifting device data sections is not supported in FS2 image format.");
 }
 

@@ -2061,7 +2031,6 @@ const char* Fs2Operations::FwGetResetRecommandationStr()
 bool Fs2Operations::FwCalcMD5(u_int8_t md5sum[16])
 {
 #if defined(UEFI_BUILD) || defined(NO_OPEN_SSL)
-    (void)md5sum;
     return errmsg("Operation not supported");
 #else
     // no support for striped image ATM

index 344279a..efa4f15 100644
@@ -237,7 +237,6 @@ bool Fs3Operations::GetImageInfo(u_int8_t *buff)
 
     // TODO: adrianc: use the version fields once they are available in tools layouts
     GET_IMAGE_INFO_VERSION(buff, IIMajor, IIMinor);
-    (void)IIMinor;
     if (!CHECK_IMAGE_INFO_VERSION(IIMajor)) {
         return errmsg(MLXFW_UNKNOWN_SECT_VER_ERR, "Unknown IMAGE_INFO format version (%d.%d).", IIMajor, IIMinor);
     }

@@ -501,9 +500,6 @@ bool Fs3Operations::VerifyTOC(u_int32_t dtoc_addr, bool& bad_signature, VerifyCa
 
 
 bool Fs3Operations::FwVerify(VerifyCallBack verifyCallBackFunc, bool isStripedImage, bool showItoc) {
-    //dummy assignment to avoid compiler warrning (isStripedImage is not used in fs3)
-    (void)isStripedImage;
-
     struct QueryOptions queryOptions;
     queryOptions.readRom = true;
     queryOptions.quickQuery = false;

@@ -684,8 +680,6 @@ bool Fs3Operations::getRunningFwVersion()
 bool Fs3Operations::FwQuery(fw_info_t *fwInfo, bool readRom, bool isStripedImage)
 {
     //isStripedImage flag is not needed in FS3 image format
-    // Avoid warning - no striped image in FS3
-    (void)isStripedImage;
     if (!Fs3IntQuery(readRom)) {
         return false;
     }

@@ -1208,9 +1202,6 @@ bool Fs3Operations::FwBurnAdvanced(FwOperations *imageOps, ExtBurnParams& burnPa
 
 bool Fs3Operations::FwBurnBlock(FwOperations *imageOps, ProgressCallBack progressFunc)
 {
-    // Avoid Warning!
-    (void)imageOps;
-    (void)progressFunc;
     return errmsg("FwBurnBlock is not supported anymore in FS3 image.");
 }
 

@@ -1256,7 +1247,6 @@ bool Fs3Operations::FwReadRom(std::vector<u_int8_t>& romSect)
 
 bool Fs3Operations::FwGetSection (u_int32_t sectType, std::vector<u_int8_t>& sectInfo, bool stripedImage)
 {
-    (void) stripedImage; // unused for FS3
     //FwGetSection only supports retrieving FS3_DBG_FW_INI section atm.
     if (sectType != FS3_DBG_FW_INI) {
         return errmsg("Unsupported section type.");

@@ -1312,9 +1302,8 @@ bool Fs3Operations::FwSetMFG(guid_t baseGuid, PrintCallBack callBackFunc)
 bool Fs3Operations::FwSetGuids(sg_params_t& sgParam, PrintCallBack callBackFunc, ProgressCallBack progressFunc)
 {
     fs3_uid_t usrGuid;
+
     memset(&usrGuid, 0, sizeof(usrGuid));
-    // Avoid Warning because there is no need for progressFunc
-    (void)progressFunc;
     if (sgParam.userGuids.empty()) {
         return errmsg("Base GUID not found.");
     }

@@ -1650,7 +1639,7 @@ bool Fs3Operations::Fs3UpdateMfgUidsSection(struct toc_info *curr_toc, std::vect
 {
     struct cibfw_mfg_info cib_mfg_info;
     struct cx4fw_mfg_info cx4_mfg_info;
-    (void)curr_toc;
+
     cibfw_mfg_info_unpack(&cib_mfg_info, (u_int8_t*)&section_data[0]);
 
     if (CHECK_MFG_OLD_FORMAT(cib_mfg_info)) {

@@ -1742,7 +1731,7 @@ bool Fs3Operations::Fs3UpdateUidsSection(struct toc_info *curr_toc, std::vector<
 {
     struct cibfw_device_info cib_dev_info;
     struct cx4fw_device_info cx4_dev_info;
-    (void)curr_toc;
+
     cibfw_device_info_unpack(&cib_dev_info, (u_int8_t*)&section_data[0]);
 
     if (CHECK_DEV_INFO_OLD_FORMAT(cib_dev_info)) {

@@ -1771,7 +1760,7 @@ bool Fs3Operations::Fs3UpdateVsdSection(struct toc_info *curr_toc, std::vector<u
         std::vector<u_int8_t>  &newSectionData)
 {
     struct cibfw_device_info dev_info;
-    (void)curr_toc;
+
     cibfw_device_info_unpack(&dev_info, (u_int8_t*)&section_data[0]);
     memset(dev_info.vsd, 0, sizeof(dev_info.vsd));
     strncpy(dev_info.vsd, user_vsd, TOOLS_ARR_SZ(dev_info.vsd) - 1);

@@ -1975,8 +1964,6 @@ bool  Fs3Operations::Fs3UpdateSection(void *new_info, fs3_section_t sect_type, b
 
 bool Fs3Operations::FwSetVSD(char* vsdStr, ProgressCallBack progressFunc, PrintCallBack printFunc)
 {
-    // Avoid warning
-    (void)progressFunc;
     if (!vsdStr) {
         return errmsg("Please specify a valid VSD string.");
     }

@@ -1997,8 +1984,6 @@ bool Fs3Operations::FwSetVSD(char* vsdStr, ProgressCallBack progressFunc, PrintC
 
 bool Fs3Operations::FwSetAccessKey(hw_key_t userKey, ProgressCallBack progressFunc)
 {
-    (void)userKey;
-    (void)progressFunc;
     return errmsg("Set access key not supported.");
 }
 

@@ -2566,7 +2551,6 @@ bool Fs3Operations::FixCX4WriteProtection(bool justCheck)
 bool Fs3Operations::FwCalcMD5(u_int8_t md5sum[16])
 {
 #if defined(UEFI_BUILD) || defined(NO_OPEN_SSL)
-    (void)md5sum;
     return errmsg("Operation not supported");
 #else
     if (!Fs3IntQuery(true, false)) {

index ca2dab6..41de4dd 100644
@@ -1049,10 +1049,6 @@ void FwOperations::WriteToErrBuff(char* errBuff, const char* errStr, int size)
 
 bool FwOperations::UpdateImgCache(u_int8_t *buff, u_int32_t addr, u_int32_t size)
 {
-    //avoid compiler warrnings
-    (void)buff;
-    (void)addr;
-    (void)size;
     //in FS2 we dont have ImgCache, just in FS3 so we define a defult behaviour.
     return true;
 }

@@ -1425,7 +1421,6 @@ bool FwOperations::ReadImageFile(const char *fimage, u_int8_t *&file_data, int &
 
 void FwOperations::SetDevFlags(chip_type_t chipType, u_int32_t devType, fw_img_type_t fwType, bool &ibDev, bool &ethDev) {
 
-    (void)devType;
     if (chipType == CT_IS4) {
         ibDev =  true;
         ethDev = false;

@@ -1591,8 +1586,6 @@ const char* FwOperations::expRomType2Str(u_int16_t type)
 
 bool FwOperations::FwSetTimeStamp(struct tools_open_ts_entry& timestamp, struct tools_open_fw_version& fwVer)
 {
-    (void)timestamp;
-    (void)fwVer;
     return errmsg("Operation not supported.");
 }
 

@@ -1603,8 +1596,5 @@ bool FwOperations::FwResetTimeStamp()
 
 bool FwOperations::FwQueryTimeStamp(struct tools_open_ts_entry& timestamp, struct tools_open_fw_version& fwVer, bool queryRunning)
 {
-    (void)timestamp;
-    (void)fwVer;
-    (void)queryRunning;
     return errmsg("Operation not supported.");
 }

index 007c865..15e91a4 100644
@@ -41,7 +41,7 @@ libmtcr_ul_a_SOURCES = mtcr_ul.c mtcr_ib.h  mtcr_int_defs.h\
 			mtcr_ul_icmd_cif.c mtcr_icmd_cif.h\
 			packets_common.c packets_common.h\
 			packets_layout.c packets_layout.h
-libmtcr_ul_a_CFLAGS = -W -Wall -g -MP -MD -fPIC -DMTCR_API="" -DMST_UL
+libmtcr_ul_a_CFLAGS = -Wall -Wextra -Wno-unused-parameter -fno-strict-aliasing -g -MP -MD -fPIC -DMTCR_API="" -DMST_UL
 
 if ENABLE_INBAND
 libmtcr_ul_a_SOURCES += mtcr_ib_ofed.c