bus/cdx: fix coverity issue
v2 cover bus/cdx: fix coverity issue
This series fixes coverity issues 385379, 385381, 385377
v2:
- Merged coverity fix patches into series
- Updated commit message
Abhijit Gangurde (3):
bus/cdx: remove ineffective code statement bus/cdx: move debug print before unmapping resource bus/cdx: fix resource leak
drivers/bus/cdx/cdx.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/3 bus/cdx: remove ineffective code statement
Remove ineffective code statement ret = 0 since it is overwritten in a loop.
Coverity issue: 385379
---
v2:
- Updated commit message
drivers/bus/cdx/cdx.c | 1 - 1 file changed, 1 deletion(-)
drivers/bus/cdx/cdx.c +0 -1
@@ -452,7 +452,6 @@ cdx_probe(void) dev->name); rte_errno = errno; failed++; - ret =0 ; } }
Signature · 1 line
2.25.1
PATCH v2 2/3 bus/cdx: move debug print before unmapping resource
In reply to Abhijit GangurdeMove debug print before unmapping requested address to fix use after free coverity issue.
Coverity issue: 385381
---
v2:
- Updated commit message
drivers/bus/cdx/cdx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bus/cdx/cdx.c +2 -1
@@ -322,12 +322,13 @@ cdx_unmap_resource(void *requested_addr, size_t size)if (requested_addr ==NULL )return ; +CDX_BUS_DEBUG ("Unmapping CDX memory at %p" , requested_addr); +/* Unmap the CDX memory resource of device */ if (rte_mem_unmap (requested_addr, size)) {CDX_BUS_ERR ("%s(): cannot mem unmap(%p, %#zx): %s" , __func__, requested_addr, size,rte_strerror (rte_errno)); } -CDX_BUS_DEBUG ("CDX memory unmapped at %p" , requested_addr); }/* * Match the CDX Driver and Device using device id and vendor id.
Signature · 1 line
2.25.1
PATCH v2 3/3 bus/cdx: fix resource leak
In reply to Abhijit GangurdeFree the allocated device memory and interrupt handler on error scenarios.
Coverity issue: 385377
---
v2:
- Updated commit message
drivers/bus/cdx/cdx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/bus/cdx/cdx.c +6 -4
@@ -208,8 +208,8 @@ cdx_scan_one(const char *dirname, const char *dev_name) ret =cdx_get_kernel_driver_by_path (filename, driver,sizeof (driver));if (ret <0 ) {CDX_BUS_ERR ("Fail to get kernel driver" ); - ret =-1 ; - goto err; +free (dev); +return -1 ; }/* Allocate interrupt instance for cdx device */
@@ -218,6 +218,7 @@ cdx_scan_one(const char *dirname, const char *dev_name)if (dev->intr_handle ==NULL ) {CDX_BUS_ERR ("Failed to create interrupt instance for %s" , dev->device.name); +free (dev);return -ENOMEM ; }
@@ -241,8 +242,8 @@ cdx_scan_one(const char *dirname, const char *dev_name)/* get device id */ snprintf (filename,sizeof (filename),"%s/device" , dirname);if (eal_parse_sysfs_value (filename, &tmp) <0 ) { -free (dev); -return -1 ; + ret =-1 ; + goto err; } dev->id.device_id = (uint16_t )tmp;
@@ -251,6 +252,7 @@ cdx_scan_one(const char *dirname, const char *dev_name)return 0 ; err: +rte_intr_instance_free (dev->intr_handle);free (dev);return ret; }
Signature · 1 line
2.25.1
Please use in-reply-to while sending subsequent version of patches.
Quoted 5 lines · Abhijit Gangurde
This series fixes coverity issues 385379, 385381, 385377
v2:
- Merged coverity fix patches into series
- Updated commit message
Series Acked-by: Nipun Gupta <[email protected]>
Thomas Monjalon
Applied19/06/2023 05:58, Nipun Gupta:
Quoted 11 lines
Please use in-reply-to while sending subsequent version of patches.
Quoted 5 lines · Abhijit Gangurde
This series fixes coverity issues 385379, 385381, 385377
v2:
- Merged coverity fix patches into series
- Updated commit messageSeries Acked-by: Nipun Gupta <[email protected]>
Applied, thanks.