board: ge: bx50v3: don't configure the backlight when there's no display

PATCH New Andrew Shadura 2 participants 6 messages May 20, 2016 – May 24, 2016

lore

Share & tools

lore

Andrew Shadura

author

2016-05-20 12:22 UTC #0 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set.

Signed-off-by Andrew Shadura <[email protected]>

---
 board/ge/bx50v3/bx50v3.c | 3 +++
 1 file changed, 3 insertions(+)

board/ge/bx50v3/bx50v3.c +3 -0

index e167cd5..fb112ee 100644
@@ -601,6 +601,8 @@ int board_late_init(void)
 #ifdef CONFIG_CMD_BMODE
 	add_board_boot_modes(board_boot_modes);
 #endif
+
+#ifdef CONFIG_VIDEO_IPUV3
 	/* We need at least 200ms between power on and backlight on
 	 * as per specifications from CHI MEI */
 	mdelay(250);

@@ -615,6 +617,7 @@ int board_late_init(void)
 	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
 
 	pwm_enable(0);
+#endif
 
 	return 0;
 }

Signature · 1 line

2.7.4

Stefano Babic

2016-05-24 14:07 UTC #1 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Hi Andrew,

Quoted 21 lines · Andrew Shadura

Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set.

Signed-off-by Andrew Shadura <[email protected]>

---
 board/ge/bx50v3/bx50v3.c | 3 +++
 1 file changed, 3 insertions(+)

board/ge/bx50v3/bx50v3.c +2 -0

index e167cd5..fb112ee 100644
@@ -601,6 +601,8 @@ int board_late_init(void)
 #ifdef CONFIG_CMD_BMODE
 	add_board_boot_modes(board_boot_modes);
 #endif
+
+#ifdef CONFIG_VIDEO_IPUV3
 	/* We need at least 200ms between power on and backlight on
 	 * as per specifications from CHI MEI */
 	mdelay(250);

board/ge/bx50v3/bx50v3.c int board_late_init(void) · line 620

Quoted 4 lines

board/ge/bx50v3/bx50v3.c +1 -0

@@ -615,6 +617,7 @@ int board_late_init(void)
 	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
 
 	pwm_enable(0);
+#endif

...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that means your changes works on a out-of-tree version of the board.

To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Andrew Shadura

author

2016-05-24 14:09 UTC #2 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Quoted 26 lines · Stefano Babic

Hi Andrew,

Quoted 23 lines · Andrew Shadura

Quoted 23 lines

Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set.

Signed-off-by Andrew Shadura <[email protected]>

---
 board/ge/bx50v3/bx50v3.c | 3 +++
 1 file changed, 3 insertions(+)

board/ge/bx50v3/bx50v3.c +2 -0

index e167cd5..fb112ee 100644
@@ -601,6 +601,8 @@ int board_late_init(void)
 #ifdef CONFIG_CMD_BMODE
 	add_board_boot_modes(board_boot_modes);
 #endif
+
+#ifdef CONFIG_VIDEO_IPUV3
 	/* We need at least 200ms between power on and backlight on
 	 * as per specifications from CHI MEI */
 	mdelay(250);

@@ -615,6 +617,7 @@ int board_late_init(void)
 	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);

Quoted 7 lines

Quoted 2 lines
board/ge/bx50v3/bx50v3.c int board_late_init(void) · line 620
Quoted 2 lines
board/ge/bx50v3/bx50v3.c +1 -0
 	pwm_enable(0);
+#endif
...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that means your changes works on a out-of-tree version of the board.
To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h.

The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them.

Signature · 10 lines

Cheers,
  Andrew

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160524/8a2690fc/attachment.sig>

Stefano Babic

2016-05-24 15:26 UTC #3 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Hi Andrew,

Quoted 32 lines · Andrew Shadura

Quoted 31 lines · Stefano Babic
Hi Andrew,
Quoted 23 lines · Andrew Shadura
Quoted 23 lines
Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set.
Signed-off-by Andrew Shadura <[email protected]>
---
 board/ge/bx50v3/bx50v3.c | 3 +++
 1 file changed, 3 insertions(+)
board/ge/bx50v3/bx50v3.c +2 -0
index e167cd5..fb112ee 100644
@@ -601,6 +601,8 @@ int board_late_init(void)
 #ifdef CONFIG_CMD_BMODE
 	add_board_boot_modes(board_boot_modes);
 #endif
+
+#ifdef CONFIG_VIDEO_IPUV3
 	/* We need at least 200ms between power on and backlight on
 	 * as per specifications from CHI MEI */
 	mdelay(250);
@@ -615,6 +617,7 @@ int board_late_init(void)
 	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
 
Quoted 2 lines
board/ge/bx50v3/bx50v3.c int board_late_init(void) · line 620
Quoted 2 lines
board/ge/bx50v3/bx50v3.c +1 -0
 	pwm_enable(0);
+#endif
...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that means your changes works on a out-of-tree version of the board.

Quoted 5 lines

Quoted 2 lines
To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h.
The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them.

I suggest you send all your changes in a single patchset - this let possible to understand all your changes and we can provide a better review.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Andrew Shadura

author

2016-05-24 15:28 UTC #4 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Quoted 10 lines · Stefano Babic

Quoted 8 lines
Quoted 8 lines
...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that
Quoted 4 lines
Quoted 4 lines
means your changes works on a out-of-tree version of the board.
To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h.
The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them.
I suggest you send all your changes in a single patchset - this let possible to understand all your changes and we can provide a better review.

That's what I did, I've resent all patches at once.

Signature · 10 lines

Cheers,
  Andrew

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160524/b1a4152a/attachment.sig>

Stefano Babic

2016-05-24 15:33 UTC #5 lore raw

PATCH 1/1 board: ge: bx50v3: don't configure the backlight when there's no display

Quoted 7 lines · Andrew Shadura

Quoted 6 lines · Stefano Babic
Quoted 6 lines
Quoted 6 lines
...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that
Quoted 4 lines
Quoted 4 lines
means your changes works on a out-of-tree version of the board.
To get this real working, you need to set CONFIG_VIDEO_IPUV3 via menuconfig, that is outside ge_bx50v3.h.

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
The next change in the patchset makes use of this bit. I put this patch first so that I don't break things and only then fix them.
I suggest you send all your changes in a single patchset - this let possible to understand all your changes and we can provide a better review.
That's what I did, I've resent all patches at once.

I see, but you missed again to send them to the board Maintainer (Martin).

Martin, can you also track them ?

Regards,
Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================