scsi: add PCIe to sata converter Marvell chip 88SE9170
PATCH 1/2 scsi: add PCIe to sata converter Marvell chip 88SE9170
Add to the command scsi device list.
--- cmd/scsi.c | 5 +++++ 1 file changed, 5 insertions(+)
cmd/scsi.c +5 -0
@@ -31,6 +31,11 @@#define SCSI_VEND_ID 0x10b9#define SCSI_DEV_ID 0x5288 +#elif definedCONFIG_SATA_88SE9170 + +#define SCSI_VEND_ID 0x1b4b +#define SCSI_DEV_ID 0x9170 +#elif !defined(CONFIG_SCSI_AHCI_PLAT )#error no scsi device defined#endif
Signature · 1 line
2.1.0.27.g96db324
PATCH 1/2 scsi: add PCIe to sata converter Marvell chip 88SE9170
Quoted 14 lines · Po Liu
Add to the command scsi device list.
Signed-off-by Po Liu <[email protected]>--- cmd/scsi.c | 5 +++++ 1 file changed, 5 insertions(+)cmd/scsi.c +0
-0@@ -31,6 +31,11 @@#define SCSI_VEND_ID 0x10b9
cmd/scsi.c line 41
Quoted 10 lines
cmd/scsi.c +5
-0#define SCSI_DEV_ID 0x5288 +#elif definedCONFIG_SATA_88SE9170 + +#define SCSI_VEND_ID 0x1b4b +#define SCSI_DEV_ID 0x9170 +#elif !defined(CONFIG_SCSI_AHCI_PLAT )#error no scsi device defined#endif
Po,
Would it be a better idea to define CONFIG_SCSI_DEV_LIST in your board header file? You can merge your two patches into one.
York
PATCH 1/2 scsi: add PCIe to sata converter Marvell chip 88SE9170
Quoted 37 lines
-----Original Message-----
From: York Sun [mailto:york.sun at nxp.com]
Sent: Tuesday, May 17, 2016 12:03 AM
To: Po Liu
Cc: u-boot at lists.denx.de; Simon Glass; Bin Meng; osp at andrep.de; mark.langsdorf at gmail.com
Subject: Re: [PATCH 1/2] scsi: add PCIe to sata converter Marvell chip 88SE9170Quoted 13 lines · Po Liu
Add to the command scsi device list.
Signed-off-by Po Liu <[email protected]>--- cmd/scsi.c | 5 +++++ 1 file changed, 5 insertions(+)cmd/scsi.c +0
-0@@ -31,6 +31,11 @@#define SCSI_VEND_ID 0x10b9cmd/scsi.c line 41
Quoted 10 lines
cmd/scsi.c +5
-0#define SCSI_DEV_ID 0x5288 +#elif definedCONFIG_SATA_88SE9170 + +#define SCSI_VEND_ID 0x1b4b +#define SCSI_DEV_ID 0x9170 + #elif !defined(CONFIG_SCSI_AHCI_PLAT) #error no scsi device defined#endif Po,
Quoted 3 lines
Would it be a better idea to define
CONFIG_SCSI_DEV_LISTin your board header
file? You can merge your two patches into one.
Ok, Understand.
Quoted 3 lines
York
PATCH 1/1 ls1043ardb: add support scsi command and pcie to sata converter
In reply to Po LiuAdd scsi command and enable supporting the pcie2sata chip 88SE9170 from Marvell.
---
merge to one patch only.
include/configs/ls1043ardb.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
include/configs/ls1043ardb.h +21 -0
@@ -285,6 +285,27 @@#define CONFIG_USB_STORAGE #endif +/* SATA */ +#define CONFIG_LIBATA +#define CONFIG_SCSI_AHCI +#define CONFIG_CMD_SCSI +#ifndef CONFIG_CMD_FAT +#define CONFIG_CMD_FAT +#endif +#ifndef CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT2 +#endif +#define CONFIG_DOS_PARTITION +#define CONFIG_BOARD_LATE_INIT +#define CONFIG_SYS_SCSI_MAX_SCSI_ID 2 +#define CONFIG_SYS_SCSI_MAX_LUN 2 +#define CONFIG_SYS_SCSI_MAX_DEVICE (CONFIG_SYS_SCSI_MAX_SCSI_ID * \ + CONFIG_SYS_SCSI_MAX_LUN) +#define SCSI_VEND_ID 0x1b4b +#define SCSI_DEV_ID 0x9170 +#define CONFIG_SCSI_DEV_LIST {SCSI_VEND_ID, SCSI_DEV_ID} +#define CONFIG_PCI +#include <asm/fsl_secure_boot.h> #endif /* __LS1043ARDB_H__ */
Signature · 1 line
2.1.0.27.g96db324
PATCH 1/1 ls1043ardb: add support scsi command and pcie to sata converter
Quoted 9 lines · Po Liu
Add scsi command and enable supporting the pcie2sata chip 88SE9170 from Marvell.
Signed-off-by Po Liu <[email protected]>---
merge to one patch only.include/configs/ls1043ardb.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
Minor adjustment to commit subject and message. Applied to u-boot-fsl-qoriq master, awaiting upstream.
Thanks.
York