Skip to contentSkip to conversation

staging: slicoss: fix camel case check

PATCH In review Jaime Arrocha 2 participants 2 messages May 29, 2016 – May 30, 2016 Staging

lore
Share & tools
lore

Jaime Arrocha

author
#0 lore raw

PATCH 2/2 staging: slicoss: fix camel case check

From: Jaime Arrocha <[email protected]>

Fixed several checks about camel case use provided by checkpatch.pl.
CHECK: Avoid CamelCase
Changes verified to work by compiling module.

Signed-off-by Jaime Arrocha <[email protected]>
---
 drivers/staging/slicoss/slic.h    | 30 +++++++++++------------
 drivers/staging/slicoss/slicoss.c | 50 +++++++++++++++++++--------------------
 2 files changed, 40 insertions(+), 40 deletions(-)
drivers/staging/slicoss/slic.h +15 -15
index 6722743..2c1d819 100644
@@ -52,8 +52,8 @@
 
 #define GB_RCVUCODE_VERS_STRING  "1.2"
 #define GB_RCVUCODE_VERS_DATE    "2006/03/27 15:12:15"
-static u32 OasisRcvUCodeLen = 512;
-static u32 GBRcvUCodeLen = 512;
+static u32 oasis_rcvucodelen = 512;
+static u32 gb_rcvucodelen = 512;
 #define SECTION_SIZE 65536
 
 #define SLIC_RSPQ_PAGES_GB	  10

@@ -370,20 +370,20 @@ struct slic_upr {
 struct slic_ifevents {
 	uint        oflow802;
 	uint        uflow802;
-	uint        Tprtoflow;
+	uint        tprtoflow;
 	uint        rcvearly;
-	uint        Bufov;
-	uint        Carre;
-	uint        Longe;
-	uint        Invp;
-	uint        Crc;
-	uint        Drbl;
-	uint        Code;
-	uint        IpHlen;
-	uint        IpLen;
-	uint        IpCsum;
-	uint        TpCsum;
-	uint        TpHlen;
+	uint        bufov;
+	uint        carre;
+	uint        longe;
+	uint        invp;
+	uint        crc;
+	uint        drbl;
+	uint        code;
+	uint        iphlen;
+	uint        iplen;
+	uint        ipcsum;
+	uint        tpcsum;
+	uint        tphlen;
 };
 
 struct adapter {
drivers/staging/slicoss/slicoss.c +25 -25

114 lines not on this page · raw message

Signature · 1 line
2.1.4
#1 lore raw
Quoted 7 lines · Jaime Arrocha

From: Jaime Arrocha <[email protected]>

Fixed several checks about camel case use provided by checkpatch.pl.
CHECK: Avoid CamelCase
Changes verified to work by compiling module.

Signed-off-by Jaime Arrocha <[email protected]>

Purpose of the patch is good but it fails to apply in my clone of the staging-testing branch. Not sure why.

Can you check it applies cleanly in your side?

Thanks,
Luis