Skip to contentSkip to conversation

mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig

PATCH In review Marek Vasut 3 participants 5 messages May 31, 2016 – Jun 3, 2016

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig

This fixes the last remaining libgcc warning, where the symbol was defined twice.

Signed-off-by Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Cc Tom Rini <[email protected]>
---
 configs/tplink_wdr4300_defconfig | 1 +
 include/configs/tplink_wdr4300.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
configs/tplink_wdr4300_defconfig +1 -0
index b1af2f6..3eec4c2 100644
@@ -1,6 +1,7 @@
 CONFIG_MIPS=y
 CONFIG_ARCH_ATH79=y
 CONFIG_BOARD_TPLINK_WDR4300=y
+CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_SYS_NS16550=y
 CONFIG_DM_SERIAL=y
include/configs/tplink_wdr4300.h +0 -2
index 6273711..abe1da2 100644
@@ -78,8 +78,6 @@
 #define CONFIG_SYS_MEMTEST_END		0x83f00000
 #define CONFIG_CMD_MEMTEST
 
-#define CONFIG_USE_PRIVATE_LIBGCC
-
 #define CONFIG_CMD_MII
 #define CONFIG_PHY_GIGE
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig

Quoted 6 lines · Marek Vasut

This fixes the last remaining libgcc warning, where the symbol was defined twice.

Signed-off-by Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160531/55e89143/attachment.sig>
#2 lore raw

PATCH 1/1 mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig

Hi Tom,

Am 01.06.2016 um 00:55 schrieb Tom Rini:

Quoted 11 lines · Marek Vasut
Quoted 7 lines

This fixes the last remaining libgcc warning, where the symbol was defined twice.

Signed-off-by Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>

could you apply this patch or shall I create a PR?

Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160601/23ccc9eb/attachment.sig>
#3 lore raw

PATCH 1/1 mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig

Quoted 8 lines · Daniel Schwierzeck

Hi Tom,

Am 01.06.2016 um 00:55 schrieb Tom Rini:

Quoted 5 lines · Marek Vasut
Quoted 4 lines

This fixes the last remaining libgcc warning, where the symbol was defined twice.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>

could you apply this patch or shall I create a PR?

I'll pick it up prior to applying the libgcc series, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160601/714a871d/attachment.sig>
#4 lore raw
In reply to Marek Vasut
Quoted 7 lines · Marek Vasut

This fixes the last remaining libgcc warning, where the symbol was defined twice.

Signed-off-by Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160603/2586cbe9/attachment.sig>