Skip to contentSkip to conversation

zynqmp: remove CONFIG_BOOTP_SERVERIP

PATCH New Alexander Graf 2 participants 2 messages Jun 1, 2016 – Jun 2, 2016 Arm/Zynq architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zynqmp: remove CONFIG_BOOTP_SERVERIP

When the CONFIG_BOOTP_SERVERIP option is set, we ignore all dhcp values for the tftp server and use our own serverip and file name instead.

This is usually not what we want and I doubt it's set for a good reason on ZynqMP. It definitely hurts if we want to support uEFI PXE boot on it. So just remove the option for now.

---
 include/configs/xilinx_zynqmp.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/xilinx_zynqmp.h +0 -1
index 6800d34..9c55c08 100644
@@ -76,7 +76,6 @@
 #define CONFIG_BOOTP_GATEWAY
 #define CONFIG_BOOTP_HOSTNAME
 #define CONFIG_BOOTP_MAY_FAIL
-#define CONFIG_BOOTP_SERVERIP
 #define CONFIG_BOOTP_DNS
 #define CONFIG_BOOTP_PXE
 #define CONFIG_BOOTP_SUBNETMASK
Signature · 1 line
1.8.5.6
#1 lore raw

PATCH 1/1 zynqmp: remove CONFIG_BOOTP_SERVERIP

Quoted 19 lines · Alexander Graf

When the CONFIG_BOOTP_SERVERIP option is set, we ignore all dhcp values for the tftp server and use our own serverip and file name instead.

This is usually not what we want and I doubt it's set for a good reason on ZynqMP. It definitely hurts if we want to support uEFI PXE boot on it. So just remove the option for now.

---
 include/configs/xilinx_zynqmp.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/xilinx_zynqmp.h +0 -0
index 6800d34..9c55c08 100644

include/configs/xilinx_zynqmp.h line 81

Quoted 7 lines
include/configs/xilinx_zynqmp.h +0 -1
@@ -76,7 +76,6 @@
 #define CONFIG_BOOTP_GATEWAY
 #define CONFIG_BOOTP_HOSTNAME
 #define CONFIG_BOOTP_MAY_FAIL
-#define CONFIG_BOOTP_SERVERIP
 #define CONFIG_BOOTP_DNS
 #define CONFIG_BOOTP_PXE
 #define CONFIG_BOOTP_SUBNETMASK

Looks reasonable.

Applied with changed subject ARM64: zynqmp: Remove...

Thanks,
Michal