usb: dwc3: Correct datatype of base to unsigned long
PATCH 1/1 usb: dwc3: Correct datatype of base to unsigned long
From: Siva Durga Prasad Paladugu <[email protected]>
Correct type of varibale base to unsigned long as
keeping it as int causes usb failures if MSB of
the base address is set.
---
include/dwc3-uboot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/dwc3-uboot.h +1 -1
@@ -13,7 +13,7 @@#include <linux/usb/otg.h> struct dwc3_device { -int base; +unsigned long base;enum usb_dr_mode dr_mode;u32 maximum_speed;unsigned tx_fifo_resize:1 ;
Signature · 1 line
1.9.1
PATCH 1/1 usb: dwc3: Correct datatype of base to unsigned long
Quoted 8 lines · Michal Simek
From: Siva Durga Prasad Paladugu <[email protected]>
Correct type of varibale base to unsigned long as
keeping it as int causes usb failures if MSB of
the base address is set.Signed-off-by Siva Durga Prasad Paladugu <[email protected]>Signed-off-by Michal Simek <[email protected]>
I can verify that with this patch the "usb start" doesn't crash the system anymore and it seems to start doing something intelligible (I don't have usb devices plugged in, so can't verify whether they also work).
Alex
PATCH 1/1 usb: dwc3: Correct datatype of base to unsigned long
Hi Marek,
Quoted 9 lines · Alexander Graf
Quoted 6 lines · Michal Simek
From: Siva Durga Prasad Paladugu <[email protected]>
Correct type of varibale base to unsigned long as
keeping it as int causes usb failures if MSB of
the base address is set.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Siva Durga Prasad Paladugu <[email protected]>Signed-off-by Michal Simek <[email protected]>I can verify that with this patch the "usb start" doesn't crash the system anymore and it seems to start doing something intelligible (I don't have usb devices plugged in, so can't verify whether they also work).
Tested-by Alexander Graf <[email protected]>
Can you please look at it?
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160602/75377091/attachment.sig>
PATCH 1/1 usb: dwc3: Correct datatype of base to unsigned long
Quoted 1 line · Michal Simek
Hi Marek,
Hi,
Quoted 13 lines · Alexander Graf
Quoted 12 lines · Michal Simek
Quoted 8 lines
From: Siva Durga Prasad Paladugu <[email protected]>
Correct type of varibale base to unsigned long as
keeping it as int causes usb failures if MSB of
the base address is set.Signed-off-by Siva Durga Prasad Paladugu <[email protected]>Signed-off-by Michal Simek <[email protected]>
Quoted 7 lines
Quoted 5 lines
I can verify that with this patch the "usb start" doesn't crash the system anymore and it seems to start doing something intelligible (I don't have usb devices plugged in, so can't verify whether they also work).
Tested-by Alexander Graf <[email protected]>Can you please look at it?
It's in u-boot-usb, PR is coming
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 usb: dwc3: Correct datatype of base to unsigned long
Quoted 22 lines · Marek Vasut
Quoted 1 line · Michal Simek
Hi Marek,
Hi,
Quoted 17 lines · Alexander Graf
Quoted 16 lines · Michal Simek
Quoted 8 lines
From: Siva Durga Prasad Paladugu <[email protected]>
Correct type of varibale base to unsigned long as
keeping it as int causes usb failures if MSB of
the base address is set.Signed-off-by Siva Durga Prasad Paladugu <[email protected]>Signed-off-by Michal Simek <[email protected]>I can verify that with this patch the "usb start" doesn't crash the system anymore and it seems to start doing something intelligible (I don't have usb devices plugged in, so can't verify whether they also work).
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Tested-by Alexander Graf <[email protected]>Can you please look at it?
It's in u-boot-usb, PR is coming
Thanks,
Michal