spl: fit: Fix non-matching DT names console output
PATCH 1/1 spl: fit: Fix non-matching DT names console output
When no DTB can be matched successfully to the board that's being used a list of available FIT-embedded DTBs will be output to the console for diagnostic purposes. But rather than the contents of the "description" FDT property a non-existent property was accessed and as a result "NULL" was output instead of the actual name(s) of the DTB(s). Fix this issue by using the correct property which is also the exact same property that's used earlier during the actual board matching process.
--- common/spl/spl_fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_fit.c +1 -1
@@ -77,7 +77,7 @@ static int spl_fit_select_fdt(const void *fdt, int images, int *fdt_offsetp)for (node =fdt_first_subnode (fdt, conf); node >=0 ; node =fdt_next_subnode (fdt, node)) { - name =fdt_getprop (fdt, node,"name" , &len); + name =fdt_getprop (fdt, node,"description" , &len);printf (" %s\n" , name); }#endif
Signature · 1 line
2.7.2
PATCH 1/1 spl: fit: Fix non-matching DT names console output
Quoted 7 lines · Andreas Dannenberg
When no DTB can be matched successfully to the board that's being used a list of available FIT-embedded DTBs will be output to the console for diagnostic purposes. But rather than the contents of the "description" FDT property a non-existent property was accessed and as a result "NULL" was output instead of the actual name(s) of the DTB(s). Fix this issue by using the correct property which is also the exact same property that's used earlier during the actual board matching process.
Thanks and regards,
Lokesh
Quoted 20 lines
Signed-off-by Andreas Dannenberg <[email protected]>--- common/spl/spl_fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/spl/spl_fit.c +1
-1@@ -77,7 +77,7 @@ static int spl_fit_select_fdt(const void *fdt, int images, int *fdt_offsetp)for (node =fdt_first_subnode (fdt, conf); node >=0 ; node =fdt_next_subnode (fdt, node)) { - name =fdt_getprop (fdt, node,"name" , &len); + name =fdt_getprop (fdt, node,"description" , &len);printf (" %s\n" , name); }#endif
PATCH 1/1 spl: fit: Fix non-matching DT names console output
In reply to Andreas DannenbergQuoted 9 lines · Andreas Dannenberg
When no DTB can be matched successfully to the board that's being used a list of available FIT-embedded DTBs will be output to the console for diagnostic purposes. But rather than the contents of the "description" FDT property a non-existent property was accessed and as a result "NULL" was output instead of the actual name(s) of the DTB(s). Fix this issue by using the correct property which is also the exact same property that's used earlier during the actual board matching process.
Signed-off-by Andreas Dannenberg <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160606/71a65351/attachment.sig>
PATCH 1/1 spl: fit: Fix non-matching DT names console output
In reply to Andreas DannenbergQuoted 9 lines · Andreas Dannenberg
When no DTB can be matched successfully to the board that's being used a list of available FIT-embedded DTBs will be output to the console for diagnostic purposes. But rather than the contents of the "description" FDT property a non-existent property was accessed and as a result "NULL" was output instead of the actual name(s) of the DTB(s). Fix this issue by using the correct property which is also the exact same property that's used earlier during the actual board matching process.
Signed-off-by Andreas Dannenberg <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160606/13144a32/attachment.sig>
PATCH 1/1 spl: fit: Fix non-matching DT names console output
In reply to Andreas DannenbergQuoted 8 lines · Andreas Dannenberg
When no DTB can be matched successfully to the board that's being used a list of available FIT-embedded DTBs will be output to the console for diagnostic purposes. But rather than the contents of the "description" FDT property a non-existent property was accessed and as a result "NULL" was output instead of the actual name(s) of the DTB(s). Fix this issue by using the correct property which is also the exact same property that's used earlier during the actual board matching process.
Quoted 4 lines
Signed-off-by Andreas Dannenberg <[email protected]>--- common/spl/spl_fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)