usb: dwc2_udc_otg: support 8-bit interface
Subsystems (4)
PATCH v2 1/1 usb: dwc2_udc_otg: support 8-bit interface
Define CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 to allow the physical interface to be 8-bit (rather than 16-bit).
---
from [1] (line ~124)
/* The Kona PHY supports an 8-bit wide UTMI interface */
[...snip...]
module_platform_driver(bcm_kona_usb2_driver);
MODULE_ALIAS("platform:bcm-kona-usb2");
MODULE_AUTHOR("Matt Porter <[email protected]>");
MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
MODULE_LICENSE("GPL v2");[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c
Changes in v2:
- implement as Kconfig
configs/bcm11130_defconfig | 1 + configs/bcm11130_nand_defconfig | 1 + configs/bcm28155_ap_defconfig | 1 + configs/bcm28155_w1d_defconfig | 1 + drivers/usb/gadget/Kconfig | 10 ++++++++++ drivers/usb/gadget/dwc2_udc_otg.c | 4 ++++ 6 files changed, 18 insertions(+)
configs/bcm11130_defconfig +1 -0
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1
configs/bcm11130_nand_defconfig +1 -0
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1
configs/bcm28155_ap_defconfig +1 -0
@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1
configs/bcm28155_w1d_defconfig +1 -0
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1
drivers/usb/gadget/Kconfig +10 -0
@@ -52,6 +52,16 @@ config USB_GADGET_DWC2_OTG driver to operate in Peripheral mode. This option requires USB_GADGET to be enabled. +if USB_GADGET_DWC2_OTG + +config USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + bool "DesignWare USB2.0 HS OTG controller PHY interface width" + help + Set the Designware USB2.0 high-speed OTG controller + PHY interface width to 8 bits, rather than the default (16 bits). + +endif # USB_GADGET_DWC2_OTG + config CI_UDC bool "ChipIdea device controller" select USB_GADGET_DUALSPEED
drivers/usb/gadget/dwc2_udc_otg.c +4 -0
@@ -415,7 +415,11 @@ static void reconfig_usbd(struct dwc2_udc *dev) |0<<7 /* Ulpi DDR sel*/ |0 <<6 /* 0: high speed utmi+, 1: full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ +#ifdef CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + |0 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#else |1 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#endif |0x7 <<0 ;/* HS/FS Timeout**/ if (dev->pdata->usb_gusbcfg)
Signature · 1 line
1.8.5
PATCH v2 1/1 usb: dwc2_udc_otg: support 8-bit interface
Quoted 4 lines · Steve Rae
Define
CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8to allow the physical interface to be 8-bit (rather than 16-bit).Signed-off-by Steve Rae <[email protected]>
Hi, minor nits below.
Quoted 67 lines
---
from [1] (line ~124)/* The Kona PHY supports an 8-bit wide UTMI interface */ [...snip...] module_platform_driver(bcm_kona_usb2_driver); MODULE_ALIAS("platform:bcm-kona-usb2"); MODULE_AUTHOR("Matt Porter <[email protected]>"); MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver"); MODULE_LICENSE("GPL v2");[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c
Changes in v2:
- implement asKconfigconfigs/bcm11130_defconfig | 1 + configs/bcm11130_nand_defconfig | 1 + configs/bcm28155_ap_defconfig | 1 + configs/bcm28155_w1d_defconfig | 1 + drivers/usb/gadget/Kconfig | 10 ++++++++++ drivers/usb/gadget/dwc2_udc_otg.c | 4 ++++ 6 files changed, 18 insertions(+)configs/bcm11130_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm11130_nand_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_ap_defconfig +1
-0@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_w1d_defconfig +0
-0
configs/bcm28155_w1d_defconfig CONFIG_SYS_NS16550=y · line 24
Quoted 7 lines
configs/bcm28155_w1d_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1
Config file changes should go through the bcm tree or whoever picks those.
drivers/usb/gadget/Kconfig config USB_GADGET_DWC2_OTG · line 58
Quoted 12 lines
drivers/usb/gadget/Kconfig +4
-0@@ -52,6 +52,16 @@ config USB_GADGET_DWC2_OTG driver to operate in Peripheral mode. This option requires USB_GADGET to be enabled. +if USB_GADGET_DWC2_OTG + +config USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + bool "DesignWare USB2.0 HS OTG controller PHY interface width"
Rename it to "8-bit PHY bus width", otherwise the boolean value won't make sense here.
Quoted 26 lines
drivers/usb/gadget/Kconfig +6
-0+ help + Set the Designware USB2.0 high-speed OTG controller + PHY interface width to 8 bits, rather than the default (16 bits). + +endif # USB_GADGET_DWC2_OTG + config CI_UDC bool "ChipIdea device controller" select USB_GADGET_DUALSPEEDdrivers/usb/gadget/dwc2_udc_otg.c +4
-0@@ -415,7 +415,11 @@ static void reconfig_usbd(struct dwc2_udc *dev) |0<<7 /* Ulpi DDR sel*/ |0 <<6 /* 0: high speed utmi+, 1: full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ +#ifdef CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + |0 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#else |1 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#endif |0x7 <<0 ;/* HS/FS Timeout**/ if (dev->pdata->usb_gusbcfg)
Signature · 2 lines
Best regards, Marek Vasut
PATCH v2 1/1 usb: dwc2_udc_otg: support 8-bit interface
Quoted 76 lines · Marek Vasut
Quoted 4 lines · Steve Rae
Define
CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8to allow the physical interface to be 8-bit (rather than 16-bit).Signed-off-by Steve Rae <[email protected]>Hi, minor nits below.
Quoted 68 lines
---
from [1] (line ~124)/* The Kona PHY supports an 8-bit wide UTMI interface */ [...snip...] module_platform_driver(bcm_kona_usb2_driver); MODULE_ALIAS("platform:bcm-kona-usb2"); MODULE_AUTHOR("Matt Porter <[email protected]>"); MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver"); MODULE_LICENSE("GPL v2");[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c
Changes in v2:
- implement asKconfigconfigs/bcm11130_defconfig | 1 + configs/bcm11130_nand_defconfig | 1 + configs/bcm28155_ap_defconfig | 1 + configs/bcm28155_w1d_defconfig | 1 + drivers/usb/gadget/Kconfig | 10 ++++++++++ drivers/usb/gadget/dwc2_udc_otg.c | 4 ++++ 6 files changed, 18 insertions(+)configs/bcm11130_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm11130_nand_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_ap_defconfig +1
-0@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_w1d_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y
Quoted 8 lines
configs/bcm28155_w1d_defconfig CONFIG_SYS_NS16550=y · line 24
Quoted 6 lines
configs/bcm28155_w1d_defconfig +1
-0CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1Config file changes should go through the bcm tree or whoever picks those.
As far as I know, "nobody" is assigned to pick the "bcm tree" I've added Albert (arm) ?!?!?
Quoted 9 lines
Quoted 9 lines
drivers/usb/gadget/Kconfig +0
-0@@ -52,6 +52,16 @@ config USB_GADGET_DWC2_OTG driver to operate in Peripheral mode. This option requires USB_GADGET to be enabled.
Quoted 7 lines
drivers/usb/gadget/Kconfig config USB_GADGET_DWC2_OTG · line 58
Quoted 4 lines
drivers/usb/gadget/Kconfig +4
-0+if USB_GADGET_DWC2_OTG + +config USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + bool "DesignWare USB2.0 HS OTG controller PHY interface width"Rename it to "8-bit PHY bus width", otherwise the boolean value won't make sense here.
DONE = v3
Quoted 32 lines
Quoted 17 lines
drivers/usb/gadget/Kconfig +6
-0+ help + Set the Designware USB2.0 high-speed OTG controller + PHY interface width to 8 bits, rather than the default (16 bits). + +endif # USB_GADGET_DWC2_OTG + config CI_UDC bool "ChipIdea device controller" select USB_GADGET_DUALSPEEDdrivers/usb/gadget/dwc2_udc_otg.c +0
-0@@ -415,7 +415,11 @@ static void reconfig_usbd(struct dwc2_udc *dev) |0<<7 /* Ulpi DDR sel*/drivers/usb/gadget/dwc2_udc_otg.c static void reconfig_usbd(struct dwc2_udc *dev) · line 425
Quoted 10 lines
drivers/usb/gadget/dwc2_udc_otg.c +4
-0|0<<6 /* 0: high speed utmi+, 1: full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ +#ifdef CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + |0 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#else |1 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#endif |0x7 <<0 ;/* HS/FS Timeout**/ if (dev->pdata->usb_gusbcfg)--
Best regards,
Marek Vasut
PATCH v2 1/1 usb: dwc2_udc_otg: support 8-bit interface
Quoted 85 lines · Steve Rae
Quoted 76 lines · Marek Vasut
Quoted 4 lines · Steve Rae
Define
CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8to allow the physical interface to be 8-bit (rather than 16-bit).Signed-off-by Steve Rae <[email protected]>Hi, minor nits below.
Quoted 68 lines
---
from [1] (line ~124)/* The Kona PHY supports an 8-bit wide UTMI interface */ [...snip...] module_platform_driver(bcm_kona_usb2_driver); MODULE_ALIAS("platform:bcm-kona-usb2"); MODULE_AUTHOR("Matt Porter <[email protected]>"); MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver"); MODULE_LICENSE("GPL v2");[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c
Changes in v2:
- implement asKconfigconfigs/bcm11130_defconfig | 1 + configs/bcm11130_nand_defconfig | 1 + configs/bcm28155_ap_defconfig | 1 + configs/bcm28155_w1d_defconfig | 1 + drivers/usb/gadget/Kconfig | 10 ++++++++++ drivers/usb/gadget/dwc2_udc_otg.c | 4 ++++ 6 files changed, 18 insertions(+)configs/bcm11130_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm11130_nand_defconfig +1
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_ap_defconfig +1
-0@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1configs/bcm28155_w1d_defconfig +0
-0@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y CONFIG_USB=yQuoted 8 lines
configs/bcm28155_w1d_defconfig CONFIG_SYS_NS16550=y · line 24
Quoted 6 lines
configs/bcm28155_w1d_defconfig +1
-0CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DWC2_OTG=y +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation" CONFIG_G_DNL_VENDOR_NUM=0x18d1Config file changes should go through the bcm tree or whoever picks those.
Quoted 2 lines
As far as I know, "nobody" is assigned to pick the "bcm tree" I've added Albert (arm) ?!?!?
Yeah, either Albert or Tom then. Still ... this might be an indication that this situation needs to be fixed ;-)
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/usb/gadget/Kconfig +0
-0@@ -52,6 +52,16 @@ config USB_GADGET_DWC2_OTG driver to operate in Peripheral mode. This option requires USB_GADGET to be enabled.
Quoted 8 lines
Quoted 7 lines
drivers/usb/gadget/Kconfig config USB_GADGET_DWC2_OTG · line 58
Quoted 4 lines
drivers/usb/gadget/Kconfig +4
-0+if USB_GADGET_DWC2_OTG + +config USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + bool "DesignWare USB2.0 HS OTG controller PHY interface width"Rename it to "8-bit PHY bus width", otherwise the boolean value won't make sense here.
DONE = v3
Thanks
Quoted 31 lines
Quoted 31 lines
Quoted 16 lines
drivers/usb/gadget/Kconfig +6
-0+ help + Set the Designware USB2.0 high-speed OTG controller + PHY interface width to 8 bits, rather than the default (16 bits). + +endif # USB_GADGET_DWC2_OTG + config CI_UDC bool "ChipIdea device controller" select USB_GADGET_DUALSPEEDdrivers/usb/gadget/dwc2_udc_otg.c +0
-0@@ -415,7 +415,11 @@ static void reconfig_usbd(struct dwc2_udc *dev) |0<<7 /* Ulpi DDR sel*/drivers/usb/gadget/dwc2_udc_otg.c static void reconfig_usbd(struct dwc2_udc *dev) · line 425
Quoted 10 lines
drivers/usb/gadget/dwc2_udc_otg.c +4
-0|0<<6 /* 0: high speed utmi+, 1: full speed serial*/ |0<<4 /* 0: utmi+, 1:ulpi*/ +#ifdef CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 + |0 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#else |1 <<3 /* phy i/f 0:8bit, 1:16bit*/ +#endif |0x7 <<0 ;/* HS/FS Timeout**/ if (dev->pdata->usb_gusbcfg)--
Best regards,
Marek Vasut
Signature · 2 lines
Best regards, Marek Vasut