Skip to contentSkip to conversation

arm: mxs: Remove misleading comments

PATCH New Michael Heimpold 3 participants 3 messages Jun 6, 2016 – Jun 7, 2016

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Michael Heimpold

author
#0 lore raw

PATCH 1/1 arm: mxs: Remove misleading comments

Both comments look like being copy & paste errors.

Signed-off-by Michael Heimpold <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/mxs/mxs.c +2 -2
index a6af0fc..2298620 100644
@@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)
 {
 	switch (imxtype) {
 	case MXC_CPU_MX23:
-		return "23";	/* Quad-Plus version of the mx6 */
+		return "23";
 	case MXC_CPU_MX28:
-		return "28";	/* Dual-Plus version of the mx6 */
+		return "28";
 	default:
 		return "??";
 	}
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/1 arm: mxs: Remove misleading comments

Hi Michael

Quoted 8 lines

-----Original Message-----
From: Michael Heimpold [mailto:michael.heimpold at i2se.com]
Sent: Monday, June 06, 2016 8:27 PM
To: u-boot at lists.denx.de
Cc: Michael Heimpold <[email protected]>; Peng Fan <[email protected]>; Stefano Babic <[email protected]>
Subject: [PATCH] arm: mxs: Remove misleading comments

Quoted 5 lines

Both comments look like being copy & paste errors.

Signed-off-by Michael Heimpold <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
Reviewed-by Peng Fan <[email protected]>

Regards,
Peng.

Quoted 22 lines
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/mxs/mxs.c +2 -3
index a6af0fc..2298620 100644
@@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)  {
 	switch (imxtype) {
 	case MXC_CPU_MX23:
-		return "23";	/* Quad-Plus version of the mx6 */
+		return "23";
 	case MXC_CPU_MX28:
-		return "28";	/* Dual-Plus version of the mx6 */
+		return "28";
 	default:
 		return "??";
 	}
--

2.6.1

#2 lore raw

PATCH 1/1 arm: mxs: Remove misleading comments

In reply to Michael Heimpold
Quoted 16 lines · Michael Heimpold

Both comments look like being copy & paste errors.

Signed-off-by Michael Heimpold <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/mxs/mxs.c +0 -0
index a6af0fc..2298620 100644
@@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)
 {

arch/arm/cpu/arm926ejs/mxs/mxs.c const char *get_imx_type(u32 imxtype) · line 175

Quoted 10 lines
arch/arm/cpu/arm926ejs/mxs/mxs.c +2 -2
 	switch (imxtype) {
 	case MXC_CPU_MX23:
-		return "23";	/* Quad-Plus version of the mx6 */
+		return "23";
 	case MXC_CPU_MX28:
-		return "28";	/* Dual-Plus version of the mx6 */
+		return "28";
 	default:
 		return "??";
 	}

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================