usb: dwc2_udc_otg: support 8-bit interface

PATCH Superseded Steve Rae 2 participants 4 messages Jun 7, 2016

Subsystems (4)

USB Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture Broadcom iproc Arm architecture

lore

Share & tools

lore

Steve Rae

author

2016-06-07 15:57 UTC #0 lore raw

PATCH v4 1/2 usb: dwc2_udc_otg: support 8-bit interface

Define CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8 to allow the physical interface to be 8-bit (rather than 16-bit).

Signed-off-by Steve Rae <[email protected]>

---
from [1] (line ~124)

    /* The Kona PHY supports an 8-bit wide UTMI interface */
    [...snip...]

    module_platform_driver(bcm_kona_usb2_driver);

    MODULE_ALIAS("platform:bcm-kona-usb2");
    MODULE_AUTHOR("Matt Porter <[email protected]>");
    MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
    MODULE_LICENSE("GPL v2");

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c

Changes in v4:
- split defconfig's into separate patch (per Marek)

Changes in v3:
- implement Marek's suggestion

Changes in v2:
- implement as Kconfig

 drivers/usb/gadget/Kconfig        | 10 ++++++++++
 drivers/usb/gadget/dwc2_udc_otg.c |  4 ++++
 2 files changed, 14 insertions(+)

drivers/usb/gadget/Kconfig +10 -0

index a35a1c7..ae62476 100644
@@ -52,6 +52,16 @@ config USB_GADGET_DWC2_OTG
 	  driver to operate in Peripheral mode. This option requires
 	  USB_GADGET to be enabled.
 
+if USB_GADGET_DWC2_OTG
+
+config USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8
+	bool "DesignWare USB2.0 HS OTG controller 8-bit PHY bus width"
+	help
+	  Set the Designware USB2.0 high-speed OTG controller
+	  PHY interface width to 8 bits, rather than the default (16 bits).
+
+endif # USB_GADGET_DWC2_OTG
+
 config CI_UDC
 	bool "ChipIdea device controller"
 	select USB_GADGET_DUALSPEED

drivers/usb/gadget/dwc2_udc_otg.c +4 -0

index cb20b00..a23278d 100644
@@ -415,7 +415,11 @@ static void reconfig_usbd(struct dwc2_udc *dev)
 		|0<<7		/* Ulpi DDR sel*/
 		|0<<6		/* 0: high speed utmi+, 1: full speed serial*/
 		|0<<4		/* 0: utmi+, 1:ulpi*/
+#ifdef CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8
+		|0<<3		/* phy i/f  0:8bit, 1:16bit*/
+#else
 		|1<<3		/* phy i/f  0:8bit, 1:16bit*/
+#endif
 		|0x7<<0;	/* HS/FS Timeout**/
 
 	if (dev->pdata->usb_gusbcfg)

Signature · 1 line

1.8.5

Steve Rae

author

2016-06-07 15:57 UTC #1 lore raw

PATCH v4 2/2 USB: DWC2: choose 8-bit phy bus width

The Kona PHY supports an 8-bit wide UTMI interface, therefore, choose this Kconfig setting.

Signed-off-by Steve Rae <[email protected]>

---
from [1] (line ~124)

    /* The Kona PHY supports an 8-bit wide UTMI interface */
    [...snip...]

    module_platform_driver(bcm_kona_usb2_driver);

    MODULE_ALIAS("platform:bcm-kona-usb2");
    MODULE_AUTHOR("Matt Porter <[email protected]>");
    MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
    MODULE_LICENSE("GPL v2");

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c

Changes in v4:
- added this patch

Changes in v3: None
Changes in v2: None

 configs/bcm11130_defconfig      | 1 +
 configs/bcm11130_nand_defconfig | 1 +
 configs/bcm28155_ap_defconfig   | 1 +
 configs/bcm28155_w1d_defconfig  | 1 +
 4 files changed, 4 insertions(+)

configs/bcm11130_defconfig +1 -0

index b8ec8ac..2716868 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm11130_nand_defconfig +1 -0

index 6021fd2..8e01c52 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_ap_defconfig +1 -0

index 4404f32..eb58401 100644
@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_w1d_defconfig +1 -0

index 60eb328..35d04af 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

Signature · 1 line

1.8.5

Marek Vasut

2016-06-07 22:24 UTC #2 lore raw

PATCH v4 2/2 USB: DWC2: choose 8-bit phy bus width

Quoted 4 lines · Steve Rae

The Kona PHY supports an 8-bit wide UTMI interface, therefore, choose this Kconfig setting.
Signed-off-by Steve Rae <[email protected]>

Shouldn't the tags in this patch be ARM: bcm: ? They certainly shouldn't be USB: DWC2 as this affects the BCM platforms.

Otherwise OK, thanks!

Quoted 76 lines

---
from [1] (line ~124)

    /* The Kona PHY supports an 8-bit wide UTMI interface */
    [...snip...]

    module_platform_driver(bcm_kona_usb2_driver);

    MODULE_ALIAS("platform:bcm-kona-usb2");
    MODULE_AUTHOR("Matt Porter <[email protected]>");
    MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
    MODULE_LICENSE("GPL v2");

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c

Changes in v4:
- added this patch

Changes in v3: None
Changes in v2: None

 configs/bcm11130_defconfig      | 1 +
 configs/bcm11130_nand_defconfig | 1 +
 configs/bcm28155_ap_defconfig   | 1 +
 configs/bcm28155_w1d_defconfig  | 1 +
 4 files changed, 4 insertions(+)

configs/bcm11130_defconfig +1 -0

index b8ec8ac..2716868 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm11130_nand_defconfig +1 -0

index 6021fd2..8e01c52 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_ap_defconfig +1 -0

index 4404f32..eb58401 100644
@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_w1d_defconfig +1 -0

index 60eb328..35d04af 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

Signature · 2 lines

Best regards,
Marek Vasut

Steve Rae

author

2016-06-07 22:25 UTC #3 lore raw

PATCH v4 2/2 USB: DWC2: choose 8-bit phy bus width

Quoted 10 lines · Marek Vasut

Quoted 4 lines · Steve Rae
The Kona PHY supports an 8-bit wide UTMI interface, therefore, choose this Kconfig setting.
Signed-off-by Steve Rae <[email protected]>
Shouldn't the tags in this patch be ARM: bcm: ? They certainly shouldn't be USB: DWC2 as this affects the BCM platforms.
Otherwise OK, thanks!

OK -- Thank you....

Quoted 82 lines

Quoted 70 lines

---
from [1] (line ~124)

    /* The Kona PHY supports an 8-bit wide UTMI interface */
    [...snip...]

    module_platform_driver(bcm_kona_usb2_driver);

    MODULE_ALIAS("platform:bcm-kona-usb2");
    MODULE_AUTHOR("Matt Porter <[email protected]>");
    MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
    MODULE_LICENSE("GPL v2");

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c

Changes in v4:
- added this patch

Changes in v3: None
Changes in v2: None

 configs/bcm11130_defconfig      | 1 +
 configs/bcm11130_nand_defconfig | 1 +
 configs/bcm28155_ap_defconfig   | 1 +
 configs/bcm28155_w1d_defconfig  | 1 +
 4 files changed, 4 insertions(+)

configs/bcm11130_defconfig +1 -0

index b8ec8ac..2716868 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm11130_nand_defconfig +1 -0

index 6021fd2..8e01c52 100644
@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_ap_defconfig +1 -0

index 4404f32..eb58401 100644
@@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

configs/bcm28155_w1d_defconfig +0 -0

index 60eb328..35d04af 100644

configs/bcm28155_w1d_defconfig CONFIG_SYS_NS16550=y · line 24

Quoted 7 lines

configs/bcm28155_w1d_defconfig +1 -0

@@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
 CONFIG_G_DNL_VENDOR_NUM=0x18d1

--
Best regards,
Marek Vasut