Skip to contentSkip to conversation

e1000e: Add support for Comet Lake

PATCH New Sasha Neftin 3 participants 5 messages Oct 10, 2019 – Sep 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: Add support for Comet Lake

Add devices ID's for the next LOM generations that will be available on the next Intel Client platform (Comet Lake) This patch provides the initial support for these devices

---
 drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
 drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
 2 files changed, 12 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +6 -0
index eff75bd8a8f0..11fdc27faa82 100644
@@ -86,6 +86,12 @@ struct e1000_hw;
 #define E1000_DEV_ID_PCH_ICP_I219_V8		0x15E0
 #define E1000_DEV_ID_PCH_ICP_I219_LM9		0x15E1
 #define E1000_DEV_ID_PCH_ICP_I219_V9		0x15E2
+#define E1000_DEV_ID_PCH_CMP_I219_LM10		0x0D4E
+#define E1000_DEV_ID_PCH_CMP_I219_V10		0x0D4F
+#define E1000_DEV_ID_PCH_CMP_I219_LM11		0x0D4C
+#define E1000_DEV_ID_PCH_CMP_I219_V11		0x0D4D
+#define E1000_DEV_ID_PCH_CMP_I219_LM12		0x0D53
+#define E1000_DEV_ID_PCH_CMP_I219_V12		0x0D55
 
 #define E1000_REVISION_4	4
 
drivers/net/ethernet/intel/e1000e/netdev.c +6 -0
index cc4363e67072..2dedeed74cd4 100644
@@ -7753,6 +7753,12 @@ static const struct pci_device_id e1000_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
 
 	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
 };
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 e1000e: Add support for Comet Lake

Quoted 10 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Sasha Neftin
Sent: Thursday, October 10, 2019 3:16 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support for Comet Lake

Add devices ID's for the next LOM generations that will be available on the next Intel Client platform (Comet Lake) This patch provides the initial support for these devices

Quoted 6 lines
---
 drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
 drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
 2 files changed, 12 insertions(+)
#2 lore raw

PATCH 1/1 e1000e: Add support for Comet Lake

In reply to Sasha Neftin

Dear Sasha, dear Jeff,

Am 10.10.19 um 12:15 schrieb Sasha Neftin:

Quoted 34 lines

Add devices ID's for the next LOM generations that will be available on the next Intel Client platform (Comet Lake) This patch provides the initial support for these devices

---
  drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
  drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
  2 files changed, 12 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +6 -0
index eff75bd8a8f0..11fdc27faa82 100644
@@ -86,6 +86,12 @@ struct e1000_hw;
  #define E1000_DEV_ID_PCH_ICP_I219_V8		0x15E0
  #define E1000_DEV_ID_PCH_ICP_I219_LM9		0x15E1
  #define E1000_DEV_ID_PCH_ICP_I219_V9		0x15E2
+#define E1000_DEV_ID_PCH_CMP_I219_LM10		0x0D4E
+#define E1000_DEV_ID_PCH_CMP_I219_V10		0x0D4F
+#define E1000_DEV_ID_PCH_CMP_I219_LM11		0x0D4C
+#define E1000_DEV_ID_PCH_CMP_I219_V11		0x0D4D
+#define E1000_DEV_ID_PCH_CMP_I219_LM12		0x0D53
+#define E1000_DEV_ID_PCH_CMP_I219_V12		0x0D55
 
  #define E1000_REVISION_4	4
 
drivers/net/ethernet/intel/e1000e/netdev.c +0 -0
index cc4363e67072..2dedeed74cd4 100644
@@ -7753,6 +7753,12 @@ static const struct pci_device_id e1000_pci_tbl[] = {
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), board_pch_cnp },
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), board_pch_cnp },

drivers/net/ethernet/intel/e1000e/netdev.c static const struct pci_device_id e1000_pci_tbl[] = { · line 7764

Quoted 10 lines
drivers/net/ethernet/intel/e1000e/netdev.c +6 -0
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
 
  	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
  };

This landed in Linux 5.5, and we would really like to see it in the 5.4 stable series. As it?s just adding new PCI device codes, this sounds easily doable.

What is the process of getting it into the stable series? I remember the net subsystem having a different process than just adding `CC:
stable at vger.kernel.org`, which is too late for this anyway, as it?s already in Linus? master branch.

Kind regards,

Paul

#3 lore raw

PATCH 1/1 e1000e: Add support for Comet Lake

Quoted 62 lines · Paul Menzel

Dear Sasha, dear Jeff,

Am 10.10.19 um 12:15 schrieb Sasha Neftin:

Quoted 45 lines

Add devices ID's for the next LOM generations that will be available on the next Intel Client platform (Comet Lake) This patch provides the initial support for these devices

---
? drivers/net/ethernet/intel/e1000e/hw.h???? | 6 ++++++ ? drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ ? 2 files changed, 12 insertions(+)

drivers/net/ethernet/intel/e1000e/hw.h +0 -0
index eff75bd8a8f0..11fdc27faa82 100644
@@ -86,6 +86,12 @@ struct e1000_hw;

? #define E1000_DEV_ID_PCH_ICP_I219_V8??????? 0x15E0 ? #define E1000_DEV_ID_PCH_ICP_I219_LM9??????? 0x15E1 ? #define E1000_DEV_ID_PCH_ICP_I219_V9??????? 0x15E2

drivers/net/ethernet/intel/e1000e/hw.h +6 -0
+#define E1000_DEV_ID_PCH_CMP_I219_LM10??????? 0x0D4E
+#define E1000_DEV_ID_PCH_CMP_I219_V10??????? 0x0D4F
+#define E1000_DEV_ID_PCH_CMP_I219_LM11??????? 0x0D4C
+#define E1000_DEV_ID_PCH_CMP_I219_V11??????? 0x0D4D
+#define E1000_DEV_ID_PCH_CMP_I219_LM12??????? 0x0D53
+#define E1000_DEV_ID_PCH_CMP_I219_V12??????? 0x0D55

? #define E1000_REVISION_4??? 4

drivers/net/ethernet/intel/e1000e/netdev.c +0 -0
index cc4363e67072..2dedeed74cd4 100644
@@ -7753,6 +7753,12 @@ static const struct pci_device_id 
 e1000_pci_tbl[] = {
 ????? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), 
 board_pch_cnp },
 ????? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), 
 board_pch_cnp },
 ????? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), 

board_pch_cnp },
+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },

Quoted 8 lines

+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
+??? { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
????? { 0, 0, 0, 0, 0, 0, 0 }??? /* terminate list */ ? };

This landed in Linux 5.5, and we would really like to see it in the 5.4 stable series. As it?s just adding new PCI device codes, this sounds easily doable.

Quoted 4 lines

What is the process of getting it into the stable series? I remember the net subsystem having a different process than just adding `CC:
stable at vger.kernel.org`, which is too late for this anyway, as it?s already in Linus? master branch.

Tony, can you help here?
(If I recall correctly Greg Kroah-Hartman own the stable version domain)

Quoted 5 lines

Kind regards,

Paul

#4 lore raw

PATCH 1/1 e1000e: Add support for Comet Lake

Quoted 11 lines · Sasha
Quoted 10 lines · Paul Menzel

Dear Sasha, dear Jeff,

Am 10.10.19 um 12:15 schrieb Sasha Neftin:

Quoted 6 lines

Add devices ID's for the next LOM generations that will be available on the next Intel Client platform (Comet Lake) This patch provides the initial support for these devices

---

<snip>

Quoted 13 lines
Quoted 6 lines

This landed in Linux 5.5, and we would really like to see it in the 5.4
stable series. As it?s just adding new PCI device codes, this sounds
easily doable.

Quoted 6 lines

What is the process of getting it into the stable series? I remember the
net subsystem having a different process than just adding `CC:
stable at vger.kernel.org`, which is too late for this anyway, as it?s
already in Linus? master branch.

Quoted 3 lines

Tony, can you help here?
(If I recall correctly Greg Kroah-Hartman own the stable version domain)

I've made the request see if this can be added to 5.4 stable.

Thanks,
Tony