Skip to contentSkip to conversation

ARM: bcm: fix missing include of kona_l2_cache.h

PATCH New Ben Dooks 3 participants 3 messages Jun 8, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 ARM: bcm: fix missing include of kona_l2_cache.h

Fix a warning of kona_l2_cache_init() not being declared by including the header file kona_l2_cache.h which defines it thus fixing:

arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol 'kona_l2_cache_init' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Florian Fainelli <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: bcm-kernel-feedback-list at broadcom.com
Cc: linux-arm-kernel at lists.infradead.org

---
 arch/arm/mach-bcm/kona_l2_cache.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-bcm/kona_l2_cache.c +1 -0
index b319703..59ad863 100644
@@ -17,6 +17,7 @@
 #include <asm/hardware/cache-l2x0.h>
 
 #include "bcm_kona_smc.h"
+#include "kona_l2_cache.h"
 
 void __init kona_l2_cache_init(void)
 {
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 ARM: bcm: fix missing include of kona_l2_cache.h

Hi Ben,

Quoted 23 lines · Ben Dooks

Fix a warning of kona_l2_cache_init() not being declared by including the header file kona_l2_cache.h which defines it thus fixing:

arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol 'kona_l2_cache_init' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Florian Fainelli <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: bcm-kernel-feedback-list at broadcom.com
Cc: linux-arm-kernel at lists.infradead.org

---
 arch/arm/mach-bcm/kona_l2_cache.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-bcm/kona_l2_cache.c +0 -0
index b319703..59ad863 100644

arch/arm/mach-bcm/kona_l2_cache.c line 23

Quoted 7 lines
arch/arm/mach-bcm/kona_l2_cache.c +1 -0
@@ -17,6 +17,7 @@
 #include <asm/hardware/cache-l2x0.h>
 
 #include "bcm_kona_smc.h"
+#include "kona_l2_cache.h"
 
 void __init kona_l2_cache_init(void)
 {

Thanks for fixing all these.

Acked-by Ray Jui <[email protected]>
Applied
#2 lore raw

PATCH 1/1 ARM: bcm: fix missing include of kona_l2_cache.h

Quoted 7 lines · Ray Jui

Hi Ben,

Quoted 4 lines · Ben Dooks

Fix a warning of kona_l2_cache_init() not being declared by including the header file kona_l2_cache.h which defines it thus fixing:

Quoted 5 lines
Quoted 4 lines

arch/arm/mach-bcm/kona_l2_cache.c:21:13: warning: symbol 'kona_l2_cache_init' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>
Acked-by Ray Jui <[email protected]>

Applied, thanks!

Signature · 1 line
Florian