Skip to contentSkip to conversation

power: vexpress: make dev_attr_active static

PATCH New Ben Dooks 2 participants 2 messages Jun 8, 2016 – Jun 9, 2016

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 power: vexpress: make dev_attr_active static

The dev_attr_active is not exported or defined to be used outside the driver, so make it static to avoid the following warning:

drivers/power/reset/vexpress-poweroff.c:77:1: warning: symbol 'dev_attr_active' was not declared. Should it be static?

---
Cc: Sebastian Reichel <[email protected]>
Cc: Dmitry Eremin-Solenikov <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Liviu Dudau <[email protected]>
Cc: Sudeep Holla <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Cc: linux-pm at vger.kernel.org
Cc: linux-pm at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/power/reset/vexpress-poweroff.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/reset/vexpress-poweroff.c +2 -2
index 6a9bf70..102f95a 100644
@@ -74,8 +74,8 @@ static ssize_t vexpress_reset_active_store(struct device *dev,
 	return err ? err : count;
 }
 
-DEVICE_ATTR(active, S_IRUGO | S_IWUSR, vexpress_reset_active_show,
-		vexpress_reset_active_store);
+static DEVICE_ATTR(active, S_IRUGO | S_IWUSR, vexpress_reset_active_show,
+		   vexpress_reset_active_store);
 
 
 enum vexpress_reset_func { FUNC_RESET, FUNC_SHUTDOWN, FUNC_REBOOT };
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 power: vexpress: make dev_attr_active static

Quoted 6 lines · Ben Dooks

The dev_attr_active is not exported or defined to be used outside the driver, so make it static to avoid the following warning:

drivers/power/reset/vexpress-poweroff.c:77:1: warning: symbol 'dev_attr_active' was not declared. Should it be static?

Quoted 7 lines

---
Cc: Sebastian Reichel <[email protected]>
Cc: Dmitry Eremin-Solenikov <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Liviu Dudau <[email protected]>
Cc: Sudeep Holla <[email protected]>

Pulled into vexpress-for-v4.8/fixes[1] along with other 3 vexpress related patches. Thanks.

Signature · 4 lines
Regards,
Sudeep

[1] git.kernel.org/sudeep.holla/linux/h/vexpress-for-v4.8/fixes