tst_test.h: include tst_kvercmp.h
PATCH 1/1 tst_test.h: include tst_kvercmp.h
tst_kvercmp.h is included in test.h, but is not included in tst_test.h. Fixed it.
--- include/tst_test.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/tst_test.h +1 -0
@@ -31,6 +31,7 @@#include "tst_cpu.h" #include "tst_process_state.h" #include "tst_atomic.h" +#include "tst_kvercmp.h" /* * Reports testcase result.
Signature · 1 line
1.7.1
PATCH 1/1 tst_test.h: include tst_kvercmp.h
Quoted 13 lines · Stanislav Kholmanskikh
tst_kvercmp.his included intest.h, but is not included intst_test.h. Fixed it.Signed-off-by Stanislav Kholmanskikh <[email protected]>--- include/tst_test.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/tst_test.h +0
-0
include/tst_test.h line 34
Quoted 4 lines
include/tst_test.h +1
-0@@ -31,6 +31,7 @@#include "tst_cpu.h" #include "tst_process_state.h" #include "tst_atomic.h" +#include "tst_kvercmp.h"
In the tst_test.h file, there have achieved a kernel comparative method:
struct tst_test {
...
const char *min_kver;
...
};but sometimes we have to make choice in a specific condition judgement, so it would be better to include that and remove the line:
#include "tst_kvercmp.h" from other place(ie. /kernel/syscalls/madvise/madvise06.c) at the same time.
Signature · 3 lines
Regards, Li Wang Email: [email protected]
PATCH 1/1 tst_test.h: include tst_kvercmp.h
In reply to Stanislav KholmanskikhHi!
Quoted 2 lines
tst_kvercmp.his included intest.h, but is not included intst_test.h. Fixed it.
We should remove the include from lib/tst_test.c in this patch as well.
Other than that acked.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 tst_test.h: include tst_kvercmp.h
Hi!
Quoted 8 lines · Cyril Hrubis
Hi!
Quoted 2 lines
tst_kvercmp.his included intest.h, but is not included intst_test.h. Fixed it.We should remove the include from
lib/tst_test.cin this patch as well.Other than that acked.
Li, Cyril, the patch was updated to remove all explicit includes of tst_kvercmp.h in .c files and pushed.
Thank you for your feedback.