arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

RFC PATCH New Marek Vasut 2 participants 9 messages May 25, 2016 – Jun 10, 2016

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Rockchip

lore

Share & tools

lore

Marek Vasut

author

2016-05-25 00:15 UTC #0 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.

Signed-off-by Marek Vasut <[email protected]>

Cc Tom Rini <[email protected]>

Cc Simon Glass <[email protected]>

---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

arch/arm/mach-rockchip/Kconfig +0 -6

index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
 	  and video codec support. Peripherals include Gigabit Ethernet,
 	  USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-	default y
-
-config SPL_SYS_MALLOC_SIMPLE
-	default y
-
 config SPL_DM
 	default y

Signature · 1 line

2.7.0

Simon Glass

2016-05-25 03:29 UTC #1 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Hi Marek,

Quoted 28 lines · Marek Vasut

Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -7
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
--

Quoted 2 lines

2.7.0

Will these still be enabled some other way?

Regards,
Simon

Marek Vasut

author

2016-05-25 12:26 UTC #2 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Quoted 30 lines · Simon Glass

Hi Marek,
Quoted 27 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -6
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 

Quoted 5 lines

Quoted 3 lines
--
2.7.0
Will these still be enabled some other way?

That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?

Quoted 3 lines

Regards,
Simon

Signature · 2 lines

Best regards,
Marek Vasut

Simon Glass

2016-06-08 02:43 UTC #3 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Hi Marek,

Quoted 31 lines · Marek Vasut

Quoted 30 lines · Simon Glass
Hi Marek,
Quoted 27 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -6
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 

Quoted 8 lines

Quoted 5 lines
Quoted 3 lines
--
2.7.0
Will these still be enabled some other way?
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?

Well, Rockchip boards cannot work without these, which is why they default to y.

Regards,
Simon

Marek Vasut

author

2016-06-08 03:02 UTC #4 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Quoted 1 line · Simon Glass

Hi Marek,

Hi!

Quoted 38 lines · Marek Vasut

Quoted 37 lines · Simon Glass
Quoted 35 lines
Hi Marek,
Quoted 28 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -7
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
--
Quoted 2 lines
2.7.0
Will these still be enabled some other way?

Quoted 4 lines

Quoted 2 lines
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?
Well, Rockchip boards cannot work without these, which is why they default to y.

I understand that, but these Kconfig options are generic, so they shouldn't be defined in the mach-rockchip/Kconfig file, but in some generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in some defconfig , right ?

Signature · 2 lines

Best regards,
Marek Vasut

Simon Glass

2016-06-08 04:44 UTC #5 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Hi Marek,

Quoted 46 lines · Marek Vasut

Quoted 1 line · Simon Glass
Hi Marek,
Hi!
Quoted 41 lines · Marek Vasut
Quoted 39 lines · Simon Glass
Quoted 30 lines
Hi Marek,
Quoted 27 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -6
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
Quoted 5 lines
Quoted 3 lines
--
2.7.0
Will these still be enabled some other way?
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?

Quoted 6 lines

Quoted 1 line
Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they shouldn't be defined in the mach-rockchip/Kconfig file, but in some generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in some defconfig , right ?

They are not being defined, just their default value is being set.

Regards,
Simon

Marek Vasut

author

2016-06-08 13:18 UTC #6 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Quoted 49 lines · Simon Glass

Hi Marek,
Quoted 46 lines · Marek Vasut
Quoted 1 line · Simon Glass
Hi Marek,
Hi!
Quoted 41 lines · Marek Vasut
Quoted 39 lines · Simon Glass
Quoted 30 lines
Hi Marek,
Quoted 27 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -6
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
Quoted 5 lines
Quoted 3 lines
--
2.7.0
Will these still be enabled some other way?
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they shouldn't be defined in the mach-rockchip/Kconfig file, but in some generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in some defconfig , right ?
They are not being defined, just their default value is being set.

Checking with git grep, they are defined in the top-level Kconfig. I recall when I tried using those on mips, it complained about the entries in mach-rockchip though. So why are the defaults selected this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't that how it's usually done ?

Signature · 2 lines

Best regards,
Marek Vasut

Simon Glass

2016-06-10 00:34 UTC #7 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Hi Marek,

Quoted 57 lines · Marek Vasut

Quoted 56 lines · Simon Glass
Hi Marek,
Quoted 52 lines · Marek Vasut
Quoted 1 line · Simon Glass
Hi Marek,
Hi!
Quoted 38 lines · Marek Vasut
Quoted 37 lines · Simon Glass
Quoted 35 lines
Hi Marek,
Quoted 28 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -7
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
--
Quoted 2 lines
2.7.0
Will these still be enabled some other way?
Quoted 4 lines
Quoted 2 lines
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?
Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they shouldn't be defined in the mach-rockchip/Kconfig file, but in some generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in some defconfig , right ?

Quoted 7 lines

Quoted 1 line
They are not being defined, just their default value is being set.
Checking with git grep, they are defined in the top-level Kconfig. I recall when I tried using those on mips, it complained about the entries in mach-rockchip though. So why are the defaults selected this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't that how it's usually done ?

That's odd, because these are inside an 'if ARCH_ROCKCHIP' clause. But I'm fine with moving to 'select' for these if that is better. It is unlikely anyone would want to disable these. But as it stands, your patch breaks things :-)

Regards,
Simon

Marek Vasut

author

2016-06-10 00:59 UTC #8 lore raw

RFC PATCH 1/1 arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE

Quoted 1 line · Simon Glass

Hi Marek,

Hi!

Quoted 66 lines · Marek Vasut

Quoted 57 lines · Simon Glass
Quoted 56 lines
Hi Marek,
Quoted 52 lines · Marek Vasut
Quoted 1 line · Simon Glass
Hi Marek,
Hi!
Quoted 38 lines · Marek Vasut
Quoted 37 lines · Simon Glass
Quoted 35 lines
Hi Marek,
Quoted 28 lines · Marek Vasut
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options, drop them from the rockchip-specific Kconfig file.
Signed-off-by Marek Vasut <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/mach-rockchip/Kconfig +0 -7
index d3bddb7..5f6046a 100644
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
 
-config SYS_MALLOC_F
-       default y
-
-config SPL_SYS_MALLOC_SIMPLE
-       default y
-
 config SPL_DM
        default y
 
--
Quoted 2 lines
2.7.0
Will these still be enabled some other way?
Quoted 4 lines
Quoted 2 lines
That's why it's RFC, I believe the rockchip platforms would need to add those to their defconfig, right ?
Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they shouldn't be defined in the mach-rockchip/Kconfig file, but in some generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in some defconfig , right ?
Quoted 7 lines
Quoted 1 line
They are not being defined, just their default value is being set.
Checking with git grep, they are defined in the top-level Kconfig. I recall when I tried using those on mips, it complained about the entries in mach-rockchip though. So why are the defaults selected this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't that how it's usually done ?

Quoted 4 lines

That's odd, because these are inside an 'if ARCH_ROCKCHIP' clause. But I'm fine with moving to 'select' for these if that is better. It is unlikely anyone would want to disable these. But as it stands, your patch breaks things :-)

OK, I am not really sure about this patch and I have no real use for it, so let's drop it for now.

Signature · 2 lines

Best regards,
Marek Vasut