ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Subsystems (3)
PATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-tegra/cpuidle.c +1 -0
@@ -25,6 +25,7 @@#include <linux/module.h> #include <soc/tegra/fuse.h> +#include <soc/tegra/cpuidle.h> #include "cpuidle.h"
Signature · 1 line
2.8.1
PATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Quoted 13 lines · Ben Dooks
The prototype of
tegra_cpuidle_pcie_irqs_in_use()is missing from thecpuidle.cfile, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
Quoted 3 lines
--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/ffcc37ab/attachment.sig>
Jon Hunter
maintainerPATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Quoted 20 lines · Thierry Reding
* PGP Signed by an unknown key
Quoted 13 lines · Ben Dooks
The prototype of
tegra_cpuidle_pcie_irqs_in_use()is missing from thecpuidle.cfile, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.orgQuoted 3 lines
--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)
Quoted 4 lines
I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that.
I think you did send them out ;-)
http://patchwork.ozlabs.org/patch/616249/
http://patchwork.ozlabs.org/patch/616250/
http://patchwork.ozlabs.org/patch/616251/
http://patchwork.ozlabs.org/patch/616252/
Jon
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Quoted 27 lines · Jon Hunter
Quoted 20 lines · Thierry Reding
* PGP Signed by an unknown key
Quoted 13 lines · Ben Dooks
The prototype of
tegra_cpuidle_pcie_irqs_in_use()is missing from thecpuidle.cfile, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.orgQuoted 3 lines
--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)Quoted 4 lines
I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that.
Quoted 6 lines
I think you did send them out ;-)
http://patchwork.ozlabs.org/patch/616249/
http://patchwork.ozlabs.org/patch/616250/
http://patchwork.ozlabs.org/patch/616251/
http://patchwork.ozlabs.org/patch/616252/
Hah! Excellent. No more guilty conscience for me. =)
I've pulled those patches into the Tegra tree now.
Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/9ea84b50/attachment.sig>
Jon Hunter
maintainerPATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
Quoted 32 lines · Thierry Reding
* PGP Signed by an unknown key
Quoted 29 lines · Jon Hunter
Quoted 20 lines · Thierry Reding
Quoted 1 line
Old Signed by an unknown key
Quoted 13 lines · Ben Dooks
The prototype of
tegra_cpuidle_pcie_irqs_in_use()is missing from thecpuidle.cfile, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.orgQuoted 3 lines
--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)Quoted 4 lines
I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that.
I think you did send them out ;-)
Quoted 8 lines
Quoted 4 lines
http://patchwork.ozlabs.org/patch/616249/
http://patchwork.ozlabs.org/patch/616250/
http://patchwork.ozlabs.org/patch/616251/
http://patchwork.ozlabs.org/patch/616252/Hah! Excellent. No more guilty conscience for me. =)
I've pulled those patches into the Tegra tree now.
Great! I have sent you a list of some others from patchwork that I think we should merge as well.
Jon
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: fix missing include <soc/tegra/cpuidle.h>
In reply to Jon HunterQuoted 22 lines · Jon Hunter
Quoted 20 lines · Thierry Reding
* PGP Signed by an unknown key
Quoted 16 lines · Ben Dooks
The prototype of
tegra_cpuidle_pcie_irqs_in_use()is missing from thecpuidle.cfile, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?Signed-off-by Ben Dooks <[email protected]>---
Cc: Stephen Warren <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org--- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 4 lines
I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that.
Given it is likely that gcc warning flags will be updated it'd be good to get these issues sorted out.
Signature · 2 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius