Skip to contentSkip to conversation

Call cmp with "-s" instead of "--quiet"

PATCH In review Sean Bruno 3 participants 3 messages Jun 11, 2016 – Jun 12, 2016 Kbuild

lore
Share & tools
lore

Sean Bruno

author
#0 lore raw

PATCH 1/1 Call cmp with "-s" instead of "--quiet"

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

- --quiet isn't available on FreeBSD and doesn't seem to be used in other places. This fixes some non-fatal build errors on FreeBSD. The use of "-s" over "--quiet" seems to be the preferred use in the Makefile.

Makefile +0 -0
index ed4032a..a7a356a 100644

- --- a/Makefile
+++ b/Makefile
@@ -185,7 +185,7 @@ qemu-version.h: FORCE

                                printf '""\n'; \
                        fi; \
                fi) > [email protected])

- - $(call quiet-command, cmp --quiet $@ [email protected] || mv [email protected] $@)
+ $(call quiet-command, cmp -s $@ [email protected] || mv [email protected] $@)

config-host.h: config-host.h-timestamp
config-host.h-timestamp: config-host.mak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJXXEcgXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kpWgIAI/ZzRYWUWNYXF9D8NuvPlub Arh2F7qBBvukaMra5fVQwJcNji82WdEHmClsV5782rPM19LC7QVqiiga494WFbQ2 mGWVJF0w9w0dA0lCz65mlWwqX0U/u0No8Z/RMoBtublTvbHtLfy/OUAMJrV940X2 EbPu0x/0vBlUCfgf2KUNcs6O6lt9AUJFvrSzeTJgLNHml7hchyHVMQujMv/2YggH 4TscRWswBcmikP8Rorxf59mBQx/om2n3omgnWxlAuvrgqm0ief42pYYkyIqTaPr0 C1dubmrV8ArcMWlGStUAhV2W1ibsph3ZSgoUuHqkpv5iz5BFizIqS+EvWfo1OBM= =x1ai
-----END PGP SIGNATURE-----

Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Sean Bruno

--quiet isn't available on FreeBSD and doesn't seem to be used in other places. This fixes some non-fatal build errors on FreeBSD. The use of "-s" over "--quiet" seems to be the preferred use in the Makefile.

Makefile +0 -0
index ed4032a..a7a356a 100644

Makefile qemu-version.h: FORCE · line 188

Quoted 5 lines
Makefile +1 -1
@@ -185,7 +185,7 @@ qemu-version.h: FORCE
                                printf '""\n'; \
                        fi; \
                fi) > [email protected])
-       $(call quiet-command, cmp --quiet $@ [email protected] || mv [email protected] $@)
+       $(call quiet-command, cmp -s $@ [email protected] || mv [email protected] $@)
Reviewed-by Eric Blake <[email protected]>
Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
#2 lore raw
In reply to Sean Bruno
Quoted 14 lines · Sean Bruno

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

- --quiet isn't available on FreeBSD and doesn't seem to be used in other places. This fixes some non-fatal build errors on FreeBSD. The use of "-s" over "--quiet" seems to be the preferred use in the Makefile.

Makefile +1 -1
index ed4032a..a7a356a 100644
- --- a/Makefile
+++ b/Makefile

Makefile qemu-version.h: FORCE · line 191

Quoted 8 lines
Makefile +1 -1
@@ -185,7 +185,7 @@ qemu-version.h: FORCE
                                printf '""\n'; \
                        fi; \
                fi) > [email protected])
- -       $(call quiet-command, cmp --quiet $@ [email protected] || mv [email protected] $@)
+       $(call quiet-command, cmp -s $@ [email protected] || mv [email protected] $@)
 
 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak

Can you provide a Signed-off-by: for this patch, please? We can't apply it without one.

(Providing it as a patch in the usual git format with commit message would also be nice, but optional.)

thanks
-- PMM